[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)

2018-02-23 Thread George Wilson
grwilson approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/558#pullrequestreview-99102002 -- openzfs-developer Arch

[developer] [openzfs/openzfs] 9186 performance test suite should use checksum=edonr (#572)

2018-02-23 Thread brad-lewis
Reviewed by: Paul Dagnelie Reviewed by: Dan Kimmel Reviewed by: John Kennedy The zfs performance test suite should be using checksum=edonr. Upstream bug: DLPX-50672 You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/572 -- Commit Summar

[developer] [openzfs/openzfs] 9195 New coreadm config causes failure in zpool_003_pos (#571)

2018-02-23 Thread brad-lewis
Reviewed by: Serapheim Dimitropoulos Reviewed by: Dan Kimmel dan.kim...@delphix.com If a core file is not created in the cwd the test fails. The solution is to invoke `coreadm -i core` just before running this test. Also included are Makefile changes in zfstest cannot cope with empty directories

[developer] Re: [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

2018-02-23 Thread Allan Jude
Would be nice to have this. On FreeBSD we currently use the global tunable zfs.min_auto_ashift to accomplish this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/570#issuecomment-3681

[developer] Re: [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

2018-02-23 Thread Allan Jude
allanjude approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/570#pullrequestreview-9909 -- openzfs-developer Arc

[developer] [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

2018-02-23 Thread brad-lewis
Reviewed by: Serapheim Dimitropoulos Reviewed by: Prakash Surya There should be a mechanism to override the ashift reported by the underlying devices, at pool creation time. For now, it will be a global tunable. Upstream bug: DLPX-50992 You can view, comment on, or merge this pull request onli

[developer] Re: [openzfs/openzfs] 9188 increase size of dbuf cache to reduce indirect block decompression (#564)

2018-02-23 Thread Allan Jude
allanjude approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/564#pullrequestreview-99086879 -- openzfs-developer Arc

[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)

2018-02-23 Thread Allan Jude
@allanjude pushed 1 commit. 73ea8bd fixup! arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/558/files/ca78e6e459f4d99efb0fefbbc27b6087c238

[developer] [openzfs/openzfs] 9193 bootcfg -C doesn't work (#569)

2018-02-23 Thread brad-lewis
Reviewed by: Name Chris Williamson Reviewed by: Name Sebastien Roy When given an empty string as a rootds value, bootcfg -C fails with the error message 'could not set nextboot: '' is an invalid name'. This should be allowed because it represents clearing the nextboot configuration. Upstream bu

[developer] [openzfs/openzfs] 9192 explicitly pass good_writes to vdev_uberblock/label_sync (#568)

2018-02-23 Thread brad-lewis
Reviewed by: Pavel Zakharov Reviewed by: George Wilson Currently vdev_label_sync and vdev_uberblock_sync take a zio_t and assume that its io_private is a pointer to the good_writes count. They should instead accept this argument explicitly. Upstream bug: DLPX-49206 You can view, comment on, or

[developer] [openzfs/openzfs] 9191 dump vdev tree to zfs_dbgmsg when spa load fails due to missing … (#567)

2018-02-23 Thread brad-lewis
…log devices Reviewed by: George Wilson Reviewed by: Prakash Surya Reviewed by: Matt Ahrens Add vdev_print_tree() in spa_check_for_missing_logs() when some log devices are missing to ease debugging Upstream bug: DLPX-49060 You can view, comment on, or merge this pull request online at: htt

[developer] [openzfs/openzfs] 9190 Fix cleanup routine in import_cachefile_device_replaced.ksh (#566)

2018-02-23 Thread brad-lewis
Reviewed by: Dan Kimmel Reviewed by: John Kennedy Must clear slow-disk zinject injections in test cleanup routine. Otherwise, when this test fails, it causes most subsequent tests to fail. Upstream bug: DLPX-48060 You can view, comment on, or merge this pull request online at: https://github

[developer] [openzfs/openzfs] 9189 Add debug to vdev_label_read_config when txg check fails (#565)

2018-02-23 Thread brad-lewis
Reviewed by: George Wilson Reviewed by: Prashanth Sreenivasa These changes were added to help debug issue #9187. Essentially, in the original bug, vdev_validate() seems to fails in vdev_label_read_config() and prints "failed reading config". This could happen because either: 1. The labels are a

[developer] [openzfs/openzfs] 9188 increase size of dbuf cache to reduce indirect block decompression (#564)

2018-02-23 Thread brad-lewis
Reviewed by: Dan Kimmel Reviewed by: Prashanth Sreenivasa Reviewed by: Paul Dagnelie With compressed ARC (bug #6950) we use up to 25% of our CPU to decompress indirect blocks, under a workload of random cached reads. To reduce this decompression cost, we would like to increase the size of the d

[developer] [openzfs/openzfs] 9187 racing condition between vdev label and spa_last_synced_txg in v… (#563)

2018-02-23 Thread brad-lewis
…dev_validate Reviewed by: George Wilson Reviewed by: Matt Ahrens ztest failed with uncorrectable IO error despite having the fix for #7163. Both sides of the mirror have CANT_OPEN_BAD_LABEL, which also distinguishes it from that issue. Definitely seems like a racing condition between the vdev

[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)

2018-02-23 Thread George Wilson
grwilson requested changes on this pull request. This change looks good, can you also change `arc_loan_buf` to mimic this change. I think we should always rely on `arc_buf_size` to determine the correct value to pass to `arc_loaned_bytes_update` -- You are receiving this because you are subs