[developer] Re: [openzfs/openzfs] 9102 zfs should be able to initialize storage devices (#586)

2018-03-09 Thread Daniel Carosone
Why not just dd a file to a scratch dataset (with no compression, copies=3, a suitable quota to prevent filling, and whatever other properties you think might be relevant). The use case is legitimate, but the need for more code to address it seems dubious. On Sat., 10 Mar. 2018, 13:11 George

[developer] [openzfs/openzfs] 9102 zfs should be able to initialize storage devices (#586)

2018-03-09 Thread George Wilson
Reviewed by: John Wren Kennedy Reviewed by: Matthew Ahrens Reviewed by: Pavel Zakharov Reviewed by: Prakash Surya PROBLEM The first access to a block incurs a performance penalty on some

[developer] Re: [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

2018-03-09 Thread Richard Elling
richardelling commented on this pull request. > @@ -1431,6 +1433,7 @@ vdev_open(vdev_t *vd) vd->vdev_asize = asize; vd->vdev_max_asize = max_asize; vd->vdev_ashift = MAX(ashift, vd->vdev_ashift); + vd->vdev_ashift =

[developer] Re: [openzfs/openzfs] 9256 zfs send space estimation off by > 10% on some datasets (#585)

2018-03-09 Thread Matthew Ahrens
ahrens commented on this pull request. > @@ -66,6 +66,11 @@ int zfs_send_set_freerecords_bit = B_TRUE; static char *dmu_recv_tag = "dmu_recv_tag"; const char *recv_clone_name = "%recv"; +/* + * Use this to override the recordsize calculation for fast zfs send estimates. + */ +uint64_t

[developer] [openzfs/openzfs] 9256 zfs send space estimation off by > 10% on some datasets (#585)

2018-03-09 Thread brad-lewis
Reviewed by: Matt Ahrens Reviewed by: John Kennedy Here is an instance where we see a big discrepancy. estimate is : 431217656 bytes actual size is : 492215048 bytes Without the -e flag, the discrepancy is much higher. Upstream bug: DLPX-45514 You

[developer] [openzfs/openzfs] 9255 obsolete_counts feature should be documented in zpool-features.5… (#584)

2018-03-09 Thread brad-lewis
… manpage Reviewed by: Sebastien Roy Reviewed by: Serapheim Dimitropoulos Reviewed by: Steve Gonczi This is part of device removal that should be documented. Upstream bug: DLPX-47652 You can view, comment on,