[developer] Re: [openzfs/openzfs] 9284 arc_reclaim_thread has 2 jobs (#590)

2018-03-19 Thread Dan McDonald
Make sure your RTI requests mentioned your above post. Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/590#issuecomment-374427208 -- ope

[developer] Re: [openzfs/openzfs] 9284 arc_reclaim_thread has 2 jobs (#590)

2018-03-19 Thread Matthew Ahrens
Testing: On a VM with 100GB RAM, I run a script that fills up memory by reading a large file, and a dtrace script that observes ARC activity, specifically calls to kmem_depot_ws_reap(), arc_shrink(), and the size of the ARC and amount of free memory in the system. I also configured the abd chun

[developer] Re: [openzfs/openzfs] 9326 nuke spa_dbgmsg (#580)

2018-03-19 Thread brad-lewis
@brad-lewis pushed 1 commit. 9a4f19a Merge branch 'master' into openzfs-DLPX-49012 -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/580/files/8d8a56690529bd2addca6c6602ee0ea1e1bbb8b3..9a4f19a1ae289812092408c7d748c23

[developer] Re: [openzfs/openzfs] 9286 want refreservation=auto (#592)

2018-03-19 Thread Matthew Ahrens
ahrens approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/592#pullrequestreview-105111205 -- openzfs: openzfs-develo

[developer] Re: [openzfs/openzfs] 9286 want refreservation=auto (#592)

2018-03-19 Thread Mike Gerdts
@mgerdts pushed 1 commit. ef3ac53 Do not support reservation=auto -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/592/files/7ae70bd8497e1c3d6f2ce959c1a28cae2d5acea8..ef3ac53c583c89a095abb0d400021a7a0c567508 --

[developer] Re: [openzfs/openzfs] 9102 zfs should be able to initialize storage devices (#586)

2018-03-19 Thread Prakash Surya
@grwilson can you rebase this with the last master code when you get a chance? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/586#issuecomment-374339130 ---

[developer] Re: [openzfs/openzfs] 9235 rename zpool_rewind_policy_t to zpool_load_policy_t (#579)

2018-03-19 Thread Prakash Surya
Closed #579 via d2b1e4496e6b72693ca0b37c8648ef50c3aadff5. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/579#event-1529294030 -- openzfs: openzf

[developer] Re: [openzfs/openzfs] 9191 dump vdev tree to zfs_dbgmsg when spa load fails due to missing … (#567)

2018-03-19 Thread Prakash Surya
Closed #567 via c5c02e56ee3fbcfc7adc1cffabab0e6e1cdb698f. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/567#event-1529292952 -- openzfs: openzf

[developer] Re: [openzfs/openzfs] 9193 bootcfg -C doesn't work (#569)

2018-03-19 Thread Prakash Surya
Closed #569 via 504645d227fd2c93a59bec13c05e8e247f798f53. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/569#event-1529292227 -- openzfs: openzf

[developer] Re: [openzfs/openzfs] 9190 Fix cleanup routine in import_cachefile_device_replaced.ksh (#566)

2018-03-19 Thread Prakash Surya
Closed #566 via 762c6b4b351a9b9ded1248de0f01f1bbf6a063a6. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/566#event-1529291484 -- openzfs: openzf

[developer] Re: [openzfs/openzfs] 9076 ZFS Performance test concurrency should be lowered for better la… (#562)

2018-03-19 Thread Prakash Surya
Closed #562 via 2c4dc038d44c1466475262b294dffd48a800dfc5. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/562#event-1529289685 -- openzfs: openzf

[developer] Re: [openzfs/openzfs] 9187 racing condition between vdev label and spa_last_synced_txg in v… (#563)

2018-03-19 Thread Prakash Surya
Closed #563 via 805fda723784e8ad8906cb8e001201f814ea. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/563#event-1529290577 -- openzfs: openzf

[developer] Re: [openzfs/openzfs] 9286 want refreservation=auto (#592)

2018-03-19 Thread Mike Gerdts
mgerdts commented on this pull request. > @@ -1250,6 +1252,33 @@ zprop_parse_value(libzfs_handle_t *hdl, nvpair_t > *elem, int prop, prop == ZFS_PROP_SNAPSHOT_LIMIT)) { *ivalp = UINT64_MAX; } + + /* +* Spe

[developer] Re: [openzfs/openzfs] 9286 want refreservation=auto (#592)

2018-03-19 Thread Mike Gerdts
mgerdts commented on this pull request. > + } + + props = fnvlist_alloc(); + + fnvlist_add_uint64(props, zfs_prop_to_name(ZFS_PROP_VOLBLOCKSIZE), + zfs_prop_get_int(zhp, ZFS_PROP_VOLBLOCKSIZE)); + + if (nvlist_lookup_uint64(nvl, zfs_prop_to_name(ZFS_PROP_VOLSIZE),

[developer] Re: [openzfs/openzfs] 9286 want refreservation=auto (#592)

2018-03-19 Thread Mike Gerdts
mgerdts commented on this pull request. > Consequently, writes to a sparse volume can fail with .Er ENOSPC when the pool is low on space. For a sparse volume, changes to .Sy volsize are not reflected in the reservation. +A volume that is not sparse is said to be +.Qq thick provisioned . +A

[developer] Re: [openzfs/openzfs] 9286 want refreservation=auto (#592)

2018-03-19 Thread Matthew Ahrens
ahrens commented on this pull request. > Consequently, writes to a sparse volume can fail with .Er ENOSPC when the pool is low on space. For a sparse volume, changes to .Sy volsize are not reflected in the reservation. +A volume that is not sparse is said to be +.Qq thick provisioned . +A

[developer] Re: [openzfs/openzfs] 9102 zfs should be able to initialize storage devices (#586)

2018-03-19 Thread Matthew Ahrens
Igor K has also reviewed and tested this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/586#issuecomment-374275520 -- openzfs: openzfs-develope

[developer] Re: [openzfs/openzfs] 9290 device removal reduces redundancy of mirrors (#591)

2018-03-19 Thread Matthew Ahrens
@ahrens pushed 1 commit. 0e2e20f no repair when readonly -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/591/files/51e5ea3e26b27f2007876718ae5b6664fa017e2c..0e2e20fd09a283f1e4157f229fd82f462caa411e ---

[developer] Re: [openzfs/openzfs] 9290 device removal reduces redundancy of mirrors (#591)

2018-03-19 Thread Matthew Ahrens
ahrens commented on this pull request. > + if (is->is_child[is->is_good_child].ic_data == NULL) { + ret = EIO; + goto next; + } + + abd_copy_off(zio->io_abd, +

Re: [developer] Input on refreservation=auto

2018-03-19 Thread Richard Elling
> On Mar 19, 2018, at 7:40 AM, Mike Gerdts wrote: > > > On Fri, Mar 16, 2018 at 5:38 PM, Richard Elling > mailto:richard.ell...@richardelling.com>> > wrote: >> On Mar 15, 2018, at 9:48 PM, Mike Gerdts > > wrote: >> I had started down that route, then convinced my

Re: [developer] Input on refreservation=auto

2018-03-19 Thread Mike Gerdts
On Fri, Mar 16, 2018 at 5:38 PM, Richard Elling < richard.ell...@richardelling.com> wrote: > On Mar 15, 2018, at 9:48 PM, Mike Gerdts wrote: > I had started down that route, then convinced myself that it may be there > for good reason. Can you explain how a refreservation greater than the > size

[developer] Re: [openzfs/openzfs] 9286 want refreservation=auto (#592)

2018-03-19 Thread Andrew Stormont
andy-js approved this pull request. Good job. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/592#pullrequestreview-104984091 -- openzfs: open

[developer] Re: [openzfs/openzfs] 9286 want refreservation=auto (#592)

2018-03-19 Thread Mike Gerdts
@mgerdts pushed 1 commit. 7ae70bd s/dense/thick provisioned/g -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/592/files/2178fd5c901f3686646d4741c2eb4c694b49bff1..7ae70bd8497e1c3d6f2ce959c1a28cae2d5acea8 --

[developer] Re: [openzfs/openzfs] 9286 want refreservation=auto (#592)

2018-03-19 Thread Mike Gerdts
@allanjude You understand correctly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/592#issuecomment-374221055 -- openzfs: openzfs-developer Per