ahrens approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/630#pullrequestreview-160563120
--
openzfs:
ahrens requested changes on this pull request.
> @@ -2644,6 +2644,17 @@ receive_read_record(struct receive_arg *ra)
uint32_t size = P2ROUNDUP(drro->drr_bonuslen, 8);
void *buf = kmem_zalloc(size, KM_SLEEP);
dmu_object_info_t doi;
+
+
allanjude approved this pull request.
> @@ -92,124 +93,146 @@
* growth all other writers and readers must be excluded.
This comment should be updated to reflect that 128kb is no longer the maximum
block size
> - */
- if (new->r_type == RL_APPEND)
> @allanjude can you open an illumos bug for this?
https://www.illumos.org/issues/9861
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/630#issuecomment-426119431
lundman commented on this pull request.
>*/
- if (sdd->progress) {
That does seem to be the preference.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
lundman commented on this pull request.
> (void) fprintf(stderr, "TIMESENT SNAPSHOT\n");
/*
* Print the progress from ZFS_IOC_SEND_PROGRESS every second.
*/
for (;;) {
- (void) sleep(1);
+
+ /*
+
ahrens commented on this pull request.
> @@ -392,6 +392,22 @@ static int
dump_freeobjects(dmu_sendarg_t *dsp, uint64_t firstobj, uint64_t numobjs)
{
struct drr_freeobjects *drrfo = &(dsp->dsa_drr->drr_u.drr_freeobjects);
+ uint64_t maxobj = DNODES_PER_BLOCK *
+
@waikontse pushed 1 commit.
bbc5f9c Update code comments based on PR comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Merged #698 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/698#event-1877541632
--
openzfs: openzfs-developer
Permalink:
prakashsurya approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/698#pullrequestreview-160437849
--
openzfs:
Closed #615.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/615#event-1877521835
--
openzfs: openzfs-developer
Permalink:
zfs-FUSE is incredibly out of date and I would very much not recommend
using it.
On October 1, 2018 13:20:40 Richard Elling
wrote:
On Oct 1, 2018, at 9:47 AM, Chuck Tuffli wrote:
The OpenZFS Projects page lists some bullet points for a Userland ZFS
implementation. I have a ZFS related
> On Oct 1, 2018, at 9:47 AM, Chuck Tuffli wrote:
>
> The OpenZFS Projects page lists some bullet points for a Userland ZFS
> implementation. I have a ZFS related experiment that would benefit from
> running in user-space and was wondering if this is done, a work-in-progress,
> etc.. Are
The OpenZFS Projects page lists some bullet points for a Userland ZFS
implementation. I have a ZFS related experiment that would benefit from running
in user-space and was wondering if this is done, a work-in-progress, etc.. Are
there any pointers to previous discussions of this and how it was
pcd1193182 requested changes on this pull request.
I like the idea overall, just a few questions about details of the
implementation.
>*/
- if (sdd->progress) {
We could still have this conditional, just `if(sdd->progress || sdd->siginfo)`
Might be best to keep
grwilson approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/687#pullrequestreview-160374250
--
openzfs:
@sdimitro can you rebase this and then we'll get it integrated.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/664#issuecomment-425963430
--
17 matches
Mail list logo
