@ahrens i have reported about it on slack, but it was not fixed?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/674#issuecomment-422734700
--
op
integrated by:
https://github.com/illumos/illumos-gate/commit/857c96d257470e097e846ab8886580991b329c32
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/658#issuecomment-413246271
-
Closed #658.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/658#event-1790371756
--
openzfs: openzfs-developer
Permalink:
https://openzfs.topic
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/679#pullrequestreview-142050367
--
openzfs: openzfs-de
thanks!
ship it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/679#issuecomment-409293000
--
openzfs: openzfs-developer
Permalink:
https://ope
could you please provide steps with testing and how it was found?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/679#issuecomment-409284902
--
o
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/669#pullrequestreview-141188388
--
openzfs: openzfs-de
ikozhukhov commented on this pull request.
> @@ -1,4 +1,4 @@
-#!/usr/bin/ksh -p
+#!/bin/ksh -p
John, you can close this PR.
also, i'd like to see the rules for zfs tests, because based on grep report i
can see a lot of inconsistency. All tests should be fixed to use the same rules.
also, we a
ikozhukhov commented on this pull request.
> if (strcmp(strval, "") == 0)
error = ENOENT;
}
break;
+ }
is it correct for '}' before `break` ?
--
You are receiving this because you are subscribed to thi
ikozhukhov commented on this pull request.
> @@ -1,4 +1,4 @@
-#!/usr/bin/ksh -p
+#!/bin/ksh -p
try to understand : ZFS is not on illumos only now - and have to look and hear
other projects - because they are needs try to find solutions with: how to
play/adopt updates every time.
you try dicta
ikozhukhov commented on this pull request.
> @@ -1,4 +1,4 @@
-#!/usr/bin/ksh -p
+#!/bin/ksh -p
take a look grep what i posted early - my changes based on others shebang
updates, but to be more consistent with others platforms like zfsonlinux - and
they are no need update these tests again on
ikozhukhov commented on this pull request.
> @@ -1,4 +1,4 @@
-#!/usr/bin/ksh -p
+#!/bin/ksh -p
шt can be separate issue and you can do it, but it is not related to current
update
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on G
ikozhukhov commented on this pull request.
> @@ -1,4 +1,4 @@
-#!/usr/bin/ksh -p
+#!/bin/ksh -p
these changes more related to OpenZFS and should be discussed/approved on
related topic - because they are using outside illumos a lot.
no - i'm not proposing to update this shebang by build time - i
ikozhukhov commented on this pull request.
> @@ -1,4 +1,4 @@
-#!/usr/bin/ksh -p
+#!/bin/ksh -p
@jwk404 based on my grep output - it is not the same for all places - probably
it was fixed to be more applicable between platforms to use `#!/bin/ksh`
and to me personally - `#!/bin/ksh` will be wor
ikozhukhov commented on this pull request.
> @@ -1,4 +1,4 @@
-#!/usr/bin/ksh -p
+#!/bin/ksh -p
@behlendorf and your vote to use `#!/bin/ksh` for KSH scripts as default?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
http
ikozhukhov commented on this pull request.
> @@ -1,4 +1,4 @@
-#!/usr/bin/ksh -p
+#!/bin/ksh -p
if it will be available on OpenZFS related distros - why not - you can do it,
but i looked changes in others tests before my updates and have no found
degradations to use #!/bin/ksh on illumos based
ikozhukhov commented on this pull request.
> @@ -1,4 +1,4 @@
-#!/usr/bin/ksh -p
+#!/bin/ksh -p
because the same on Debian - it is available at #!/bin/ksh as others shell and
it is available in /etc/shells:
```# /etc/shells: valid login shells
/bin/sh
/bin/dash
/bin/bash
/bin/rbash
/bin/ksh93
/
You can view, comment on, or merge this pull request online at:
https://github.com/openzfs/openzfs/pull/662
-- Commit Summary --
* 9635 we should enable user after creation with zfs tests
-- File Changes --
M usr/src/test/zfs-tests/include/commands.cfg (2)
M usr/src/test/zfs-tests
You can view, comment on, or merge this pull request online at:
https://github.com/openzfs/openzfs/pull/661
-- Commit Summary --
* 9634 move reservation zfs tests to use KSH
-- File Changes --
M usr/src/test/zfs-tests/tests/functional/reservation/cleanup.ksh (2)
M usr/src/test/zfs
@ahrens can I RTI this patch?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/658#issuecomment-400649279
--
openzfs: openzfs-developer
Permalink
@yuripv could you please send me email with your correct ID for Reviewed by:
field.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/658#issuecomment-400648990
-
i have no found the reason why it failed.
based on logs with zfs tests i can see:
Test: /opt/zfs-tests/tests/functional/pool_checkpoint/checkpoint_big_rewind
(run as root) [05:40] [PASS]
Cannot contact i-08feb8d6a44bfffce: java.lang.InterruptedException
Test: /opt/zfs-tests/tests/functional/pool_c
it is part of another changes for reduce of gcc warnings
You can view, comment on, or merge this pull request online at:
https://github.com/openzfs/openzfs/pull/658
-- Commit Summary --
* 9626 move 'static xuio_stats_t xuio_stats' to file where it use
-- File Changes --
M usr/src/uts/c
Hi all,
i try merge chnges from pull https://github.com/openzfs/openzfs/pull/172 over
latest changes based on DilOS(with latest openzfs updates)
https://bitbucket.org/dilos/dilos-illumos/commits/e39ad9e6d45a827329da4138625d3474e9cafcc0
and ask for review.
after merge, i have panic on boot with:
what is progress?
i tried to test it and have issues with some panic too with the same as with
zfs tests.
ideas - how to try to fix it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull
what is it status of this implementation ?
how to hard rebase it to latest master?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/172#issuecomment-397102771
--
could you push your update with -f again - we have no build issues, but on
tests VM lost connection
update will initiate build + test peocess
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs
another lint fix:
https://bitbucket.org/dilos/dilos-illumos/commits/3c076d1276e401d40ab0837423ef1e9bc236de17
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/648#issuecomment-396003222
https://bitbucket.org/dilos/dilos-illumos/commits/d6cc4eed5a5720864f0d91f5c278d5bed3f55815
proposed lint fixes
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/648#issuecomment-395954213
it is much better.
you need this fix i think:
https://bitbucket.org/dilos/dilos-illumos/commits/076d22e0ff7e589389449d9caded99b30eac1f9d
for illumos compiling
next issue - it is :
https://cl.ly/2L0W1X2S3K0I
https://cl.ly/1019091k0f2p
have to try figure out - why we have this warning on illumos base
well, right now will be better:
- get openzfs tree with latest updates from master
- create your branch and put changes on it
- commit all in one over latest openzfs tree
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https
huh - did you try rebase to master and just push your changes with -f (force)?
right now your changes are overloaded
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/642#issuecomment-395
merge conflict in dsl_scan.c:
```<<< HEAD
/* Embedded BP's have phys_birth==0, so we reject them above. */
ASSERT(!BP_IS_EMBEDDED(bp));
f (BP_IS_EMBEDDED(bp)) {
count_block(scn, dp->dp_blkstats, bp);
https://github.com/openzfs/openzfs/commit/f539f1eb707e3af0ec4617c664b67dff46a0c173
it is change.
at line:
https://github.com/openzfs/openzfs/commit/f539f1eb707e3af0ec4617c664b67dff46a0c173#diff-a52d460452258191b59886bbcfaa23b3R129
--
You are receiving this because you are subscribed to this thre
well, right now, illumos sources are using range_tree_create(range_tree_ops_t
*ops, void *arg) - with 2 parameters, not 3.
it was changed with device removal.
i think, have to recheck your implementation with new function
range_tree_create(range_tree_ops_t *ops, void *arg)
--
You are receiving
have to update changes with changed API in range_tree_create(range_tree_ops_t
*ops, void *arg)
instead of to use additional (3) parameter for mutex.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs
done by:
git commit 84f2736904a911587ccd1cf1e4543493fcab31f4
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/418#issuecomment-395550132
--
openz
Closed #418.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/418#event-1669473683
--
openzfs: openzfs-developer
Permalink:
https://openzfs.topic
@lundman i hope it can be integrated before next year anniversary :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/489#issuecomment-389523909
-
ikozhukhov commented on this pull request.
> @@ -176,6 +176,8 @@ export KEEP="^$(echo $KEEP | sed 's/ /$|^/g')\$"
num_disks=$(echo $DISKS | awk '{print NF}')
[[ $num_disks -lt 3 ]] && fail "Not enough disks to run ZFS Test Suite"
+sudo -k coreadm -e process
i think will be better to save cu
ikozhukhov approved this pull request.
tested on DilOS
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/635#pullrequestreview-117950909
--
open
what is status of this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/596#issuecomment-384450444
--
openzfs: openzfs-developer
Permalink:
h
what is ti status of this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/586#issuecomment-384447851
--
openzfs: openzfs-developer
Permalink:
good idea in general: kill studio lint :) because this one eat a lot of RAM +
swap :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/600#issuecomment-381636138
---
hey - you have to move TMPDIR to another place from /tmp by:
export TMPDIR=/var/tmp
because /tmp=swapfs and it is depend on SWAP size.
also - add more space to swap
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://git
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/609#pullrequestreview-110526486
--
openzfs: openzfs-de
ikozhukhov commented on this pull request.
> @@ -350,6 +350,9 @@ typedef struct dmu_buf {
*/
uint64_t dmu_object_alloc(objset_t *os, dmu_object_type_t ot,
int blocksize, dmu_object_type_t bonus_type, int bonus_len, dmu_tx_t *tx);
+uint64_t dmu_object_alloc_ibs(objset_t *os, dmu_object_ty
ikozhukhov commented on this pull request.
> @@ -350,6 +350,9 @@ typedef struct dmu_buf {
*/
uint64_t dmu_object_alloc(objset_t *os, dmu_object_type_t ot,
int blocksize, dmu_object_type_t bonus_type, int bonus_len, dmu_tx_t *tx);
+uint64_t dmu_object_alloc_ibs(objset_t *os, dmu_object_ty
ikozhukhov commented on this pull request.
> @@ -350,6 +350,9 @@ typedef struct dmu_buf {
*/
uint64_t dmu_object_alloc(objset_t *os, dmu_object_type_t ot,
int blocksize, dmu_object_type_t bonus_type, int bonus_len, dmu_tx_t *tx);
+uint64_t dmu_object_alloc_ibs(objset_t *os, dmu_object_ty
ikozhukhov commented on this pull request.
> @@ -350,6 +350,9 @@ typedef struct dmu_buf {
*/
uint64_t dmu_object_alloc(objset_t *os, dmu_object_type_t ot,
int blocksize, dmu_object_type_t bonus_type, int bonus_len, dmu_tx_t *tx);
+uint64_t dmu_object_alloc_ibs(objset_t *os, dmu_object_ty
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/610#pullrequestreview-110265929
--
openzfs: openzfs-de
i think - it is incorrect. for example - if you try to import several devices
with this error - you'll have the same devid at all and it is very bad. more
correct will be - update parser/implement it to resolve this issue.
--
You are receiving this because you are subscribed to this thread.
Rep
ikozhukhov commented on this pull request.
> @@ -34,7 +34,6 @@
*/
#define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C))
#define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C))
-#define iscntrl(C) C) >= 0) && ((C) <= 0x1f)) || ((C) == 0x7f))
ikozhukhov commented on this pull request.
> @@ -34,7 +34,6 @@
*/
#define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C))
#define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C))
-#define iscntrl(C) C) >= 0) && ((C) <= 0x1f)) || ((C) == 0x7f))
ikozhukhov approved this pull request.
thanks!
wanted this feature a long time
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/600#pullrequestreview-107637378
---
it should be rebased.
i have tested it in 2 weeks without problems
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/548#issuecomment-375434450
--
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/548#pullrequestreview-106275184
--
openzfs: openzfs-de
will do
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/418#issuecomment-375416490
--
openzfs: openzfs-developer
Permalink:
https://openzfs.topi
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/569#pullrequestreview-102338928
--
openzfs: openzfs-de
ikozhukhov commented on this pull request.
put 'void' here too
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/578#pullrequestreview-102326991
---
ikozhukhov commented on this pull request.
i prever to put 'void' to this line, the same in prototype where we have it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/578#pullrequest
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/557#pullrequestreview-100119780
--
openzfs-developer
A
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/564#pullrequestreview-99154096
--
openzfs-developer
Ar
ikozhukhov approved this pull request.
thanks for update
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/570#pullrequestreview-99114330
--
ope
what is it status of this update?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/451#issuecomment-362007731
--
openzfs-developer
Archives:
htt
ikozhukhov commented on this pull request.
> @@ -46,7 +46,7 @@ log_must zfs create -o compress=lz4 $sendfs
log_must zfs create -o compress=lz4 $recvfs
typeset dir=$(get_prop mountpoint $sendfs)
# Don't use write_compressible: we want compressible but undedupable data here.
-log_must cp /kerne
ikozhukhov approved this pull request.
will see :)
i can build dilos by gcc-5.5.0 & gcc-6.4.0, but will see how you can be fine
with gcc6
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/
tested by build on dilos with gcc55 and gcc64
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/528#issuecomment-359195348
--
openzfs-developer
Ar
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/528#pullrequestreview-90312008
--
openzfs-developer
Ar
sorry, my bad, you are right
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/528#issuecomment-359194594
--
openzfs-developer
Archives:
https://o
i have found 3 variables:
```igor@z172:~/users/igor/dilos-illumos$ g diff
diff --git a/usr/src/cmd/zpool/zpool_main.c b/usr/src/cmd/zpool/zpool_main.c
index 5ca9a4e4f4..c7e5e4d875 100644
--- a/usr/src/cmd/zpool/zpool_main.c
+++ b/usr/src/cmd/zpool/zpool_main.c
@@ -412,7 +412,7 @@ static int
add_p
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/526#pullrequestreview-89571313
--
openzfs-developer
Ar
ikozhukhov commented on this pull request.
> @@ -202,7 +202,7 @@ function plus_sign_check_v #
return 1
fi
- ls -vd $obj | nawk '(NR == 1) {print $1}' | grep "+\>" > /dev/null
+ ls -vd $obj | nawk '(NR == 1) {print $1}' | grep "+$" > /dev/null
why in line 18
i'm personally still using it on my dilos-illumos fork because i have no LINT
steps and i have no sunstudio installed for LINT.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/418#issu
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/507#pullrequestreview-84883681
--
openzfs-developer
Ar
ikozhukhov commented on this pull request.
> @@ -6653,6 +6566,9 @@ spa_sync(spa_t *spa, uint64_t txg)
ddt_sync(spa, txg);
dsl_scan_sync(dp, tx);
+ if (spa->spa_vdev_removal != NULL)
+ svr_sync(spa, tx);
+
while
ikozhukhov approved this pull request.
i have tested update - no issues found
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/482#pullrequestreview-82790660
-
ikozhukhov approved this pull request.
i have tested with dilos build and internal test - have no degradations
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/504#pullrequestreview-8
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/501#pullrequestreview-82351507
--
openzfs-developer
Ar
ikozhukhov approved this pull request.
i have tested it by integration to dilos with some manual tests in different
scenarios
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/482#pu
what is it status of this PR?
maybe we can update it later/by next changes for taskq?
i'd like to see it integrated
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/451#issuecomment-3470
hey, what is status of this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/482#issuecomment-347062681
--
openzfs-developer
Archives:
https
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/490#pullrequestreview-73575209
--
openzfs-developer
Ar
i think single commit will be fine.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/124#issuecomment-336411528
--
openzfs-developer
Archives:
h
you can use 'print' instead of 'echo' - it is applicable for portability.
zfs-tests was developed on illumos based platform and for more
universal/portable way we can update it.
for example: with DilOS i have GNU coreutils in primary place instead of
illumos tools and i have the same issues what
you can use 'print' instead of 'echo' - more portable with formatted output if
needed.
illumos 'echo' a bit different with GNU echo from coreutils and it is big pain
try to avoid portability with it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email direct
hey, when we can see it integrated? :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/251#issuecomment-45916
--
openzfs-developer
Archives:
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/473#pullrequestreview-65354605
--
openzfs-developer
Ar
ikozhukhov commented on this pull request.
we have 'err' here, but we have no check it anymore and no return error if we
have it?
> for (int i = 0; i < sharearg->zhandle_len; ++i) {
zfs_handle_t *fs_handle =
((zfs_handle_t **)(sharearg->zhandle_arr))[i];
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/470#pullrequestreview-64628626
--
openzfs-developer
Ar
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/468#pullrequestreview-64404530
--
openzfs-developer
Ar
@prakashsurya i have found interest issue on my env with boot_archive updates
and have fixed it.
i can confirm - your current change works fine and have fixed panic.
confirmation log is:
```Igors-MacBook-Pro:~ igork$ ssh root@192.168.1.227
DilOS (based on illumos) Version 1.3.7.202-20170916-2+8
ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/462#pullrequestreview-63189063
--
openzfs-developer
Ar
reproduced on VMware VM:
``` root@dilos-test:~# format
Searching for disks...done
AVAILABLE DISK SELECTIONS:
0. c2t0d0
/pci@0,0/pci15ad,7a0@15/pci15ad,7c0@0/disk@0,0
1. c2t1d0
/pci@0,0/pci15ad,7a0@15/pci15ad,7c0@0/disk@1,0
2. c2t2d0
/pci@0,0/
panic dump:
```root@shelf1:/var/crash/myhost# mdb *.0
Loading modules: [ unix genunix specfs dtrace mac cpu.generic uppc apix
scsi_vhci zfs sata sd ip hook neti sockfs arp usba stmf stmf_sbd mm mpt_sas
random crypto ptm ufs logindmux smbsrv nfs nsmb ipc ]
> ::status
debugging crash dump vmcore.0
for the record from slack - i have reproduced issue on real hw with local SAS
drives attached to LSI 3008
```igork@sshgate:~$ ssh root@10.10.10.51
DilOS (based on illumos) Version 1.3.7.202-20170911-3+462 2017-09-11
root@shelf1:~# diskinfo
TYPEDISKVID PID
@prakashsurya we are using iSCSI setup.
3 targets with raidz1 = 6drives.
1 initiator - where we have attached drives from targets and created zpool
based on iSCSI drives from targets.
pool: tstpool3
id: 3733871914129874332
state: ONLINE
action: The pool can be imported using its name o
ikozhukhov approved this pull request.
thanks, i have the same/similar changes on DilOS and using a long time
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/466#pullrequestreview-62
@avg-I we are creating fresh pool every time with scenarios.
i have asked our QA try to reproduce panic on new non-DEBUG build on fresh env
and have confirmation.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://githu
additional comment - by ZFS tests you are using reports based on DEBUG builds.
I have tested non-DEBUG build. i didn't test DEBUG build.
just FYI.
probably on DEBUG build you have no this panic, but on non-DEBUG build with
this patch - it still present, but with another message.
--
You are rece
1 - 100 of 122 matches
Mail list logo
