[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)

jwk404 approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/619#pullrequestreview-159035992 -- openzfs:

[developer] Re: [openzfs/openzfs] 9634 move reservation zfs tests to use KSH (#661)

jwk404 commented on this pull request. > @@ -1,4 +1,4 @@ -#!/usr/bin/ksh -p +#!/bin/ksh -p I'd be fine with that too. The main benefit is that it's the same everyplace in the suite. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

[developer] Re: [openzfs/openzfs] 9634 move reservation zfs tests to use KSH (#661)

jwk404 commented on this pull request. > @@ -1,4 +1,4 @@ -#!/usr/bin/ksh -p +#!/bin/ksh -p I agree with @yuripv, it would be nice to have them all be the same. I do have a preference for `#!/usr/bin/ksh` because it matches what's in the prototypes file. -- You are receiving this because

[developer] Re: [openzfs/openzfs] 9635 we should enable user after creation with zfs tests (#662)

jwk404 approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/662#pullrequestreview-133708540 -- openzfs:

[developer] [openzfs/openzfs] 9184 Add ZFS performance test for fixed blocksize random read/write IO (#659)

Reviewed by: Dan Kimmel Reviewed by: John Kennedy Work by Ahmed Gahnem This change introduces a new performance test which does random reads and writes, but instead of using `bssplit` to determine the block size, it uses a fixed blocksize. Additionally, some new IO sizes are added to other

[developer] Re: [openzfs/openzfs] 9591 ms_shift can be incorrectly changed in MOS config for indirect vdevs that have been historically expanded (#651)

jwk404 requested changes on this pull request. The Makefile in tests/functional/removal is the old style, which required enumeration of all the tests. Rather than add this test to that file, could you convert it to look like the one in use at Delphix? -- You are receiving this because you

[developer] Re: [openzfs/openzfs] 9082 Add ZFS performance test targeting ZIL latency (#634)

Pool creation could definitely be made more efficient. Things to watch out for would be that different tests with different numbers of threads would want more or fewer files, which would mean they'd want to be different sizes. Also, tests should be able to run in any order, so we can't make

[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)

jwk404 requested changes on this pull request. > + end + + args = ... + + argv = args["argv"] + + list_recursive(argv[1], argv[2]) + + results = {} + results["succeeded"] = succeeded + results["failed"] = failed + return results +EOF + +# 1. Compare

[developer] Re: [openzfs/openzfs] 9195 New coreadm config causes failure in zpool_003_pos (#571)

jwk404 commented on this pull request. > @@ -15,6 +15,6 @@ .PARALLEL: $(SUBDIRS) -SUBDIRS:sh = find ./* -maxdepth 0 -type d +SUBDIRS:sh = ls */Makefile 2>/dev/null | sed 's/\/Makefile//g' This is part of a Delphix fix that solved 7710 a little differently. It shouldn't be upstreamed. >

[developer] [openzfs/openzfs] 9082 Add ZFS performance test targeting ZIL latency (#634)

Reviewed by: Dan Kimmel Reviewed by: Matthew Ahrens This adds a new test to measure ZIL performance. - A new DTrace collection script to measure latency, and another to collect stacks of threads scheduled off a cpu for creation of flamegraphs. -

[developer] Re: [openzfs/openzfs] 9512 zfs remap poolname@snapname dumps core (#633)

jwk404 approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/633#pullrequestreview-116428397 -- openzfs:

[developer] Re: [openzfs/openzfs] 9286 want refreservation=auto (#592)

jwk404 approved this pull request. Apologies for the delay. LGTM. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/592#pullrequestreview-106155659

[developer] [openzfs/openzfs] 9076 ZFS Performance test concurrency should be lowered for better la… (#562)

…tency Reviewed by: Dan Kimmel Reviewed by: John Kennedy Work by Stephen Blinick. Nightly performance runs typically consist of two levels of concurrency; and both are fairly high. Since the IO runs are to a ZFS filesystem, within a zpool,

[developer] Re: [openzfs/openzfs] 9064 ZFS test remove_mirror should wait for device removal to complete (#537)

jwk404 approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/537#pullrequestreview-94780084 -- openzfs-developer

[developer] Re: [openzfs/openzfs] 9004 Some ZFS tests used files removed with 32 bit kernel (#532)

jwk404 commented on this pull request. > @@ -46,7 +46,7 @@ log_must zfs create -o compress=lz4 $sendfs log_must zfs create -o compress=lz4 $recvfs typeset dir=$(get_prop mountpoint $sendfs) # Don't use write_compressible: we want compressible but undedupable data here. -log_must cp

[developer] [openzfs/openzfs] 9004 Some ZFS tests used files removed with 32 bit kernel (#532)

The tests should avoid using OS files that might disappear if possible. You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/532 -- Commit Summary -- * 9004 Some ZFS tests used files removed with 32 bit kernel -- File Changes -- M

[developer] Re: [openzfs/openzfs] 8965 zfs_acl_ls_001_pos fails due to no longer supported grep regex (#522)

jwk404 commented on this pull request. > @@ -202,7 +202,7 @@ function plus_sign_check_v # return 1 fi - ls -vd $obj | nawk '(NR == 1) {print $1}' | grep "+\>" > /dev/null + ls -vd $obj | nawk '(NR == 1) {print $1}' | grep "+$" > /dev/null Sure. -- You

[developer] [openzfs/openzfs] 8965 zfs_acl_ls_001_pos fails due to no longer supported grep regex (#522)

Reviewed by: Pavel Zakharov Reviewed by: Akash Ayare The test used `\>` to detect the end of a string, but this no longer works, so use `$` which works as well since the string ends the line anyway. You can view, comment on, or merge this pull

[developer] Re: [openzfs/openzfs] 8204 Makefile changes in zfstest cannot cope with empty directories (#402)

jwk404 approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/402#pullrequestreview-43766525 -- openzfs-developer

[developer] Re: [openzfs/openzfs] 8311 ZFS_READONLY is a little too strict (#392)

The dos_ro binary should be added to commands.cfg (in the same directory). default.cfg is no longer used that way. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: