Re: [developer] Fwd: macos panic trying to interlock destroyed mutex

2019-08-13 Thread Jorgen Lundman
Hello! You should probably redirect the OsX/macOS questions over here: https://openzfsonosx.org/ Either forum or IRC - but since it is a panic, you might as well create an issue for it on github under: https://github.com/openzfsonosx/zfs/issues Sincerely, Lund Simon Casady wrote: Subj

Re: [developer] Call For Testing of FreeBSD + ZoL

2019-04-24 Thread Jorgen Lundman
EAD > > https://pkg.trueos.org/iso/freebsd13-zol/ > > > Please report issues on our GitHub tracker at: > > https://github.com/zfsonfreebsd/ZoF > > Thanks and happy testing! > -- Jorgen Lundman | Unix Administrator | +81 (0)90-5578-8500

Re: [developer] ZoL porting issues

2019-04-23 Thread Jorgen Lundman
uio->uio_iov[vec_idx].iov_len -> uio_getiov(uio, vec_idx, NULL, &iov_len); But that's just one of those platform differences to live with. I doubt upstream would want to add pointless wrappers. Lund -- Jorgen Lundman | Unix Administrator | +81 (0)90-5578-8500 Shibuy

Re: [developer] ZFS feature notifications

2019-03-21 Thread Jorgen Lundman
/illumos-gate/usr/src/uts/common/sys/vnode.h#644 > in case anything there helps. > > I bring these up just in hopes of avoiding unnecessary duplication of > functionality in ways that might interfere with portability of > datasets between ZFS implementations.

Re: [developer] ZFS feature notifications

2019-01-10 Thread Jorgen Lundman
_DRIVELETTER, "driveletter" Since there is no (easy) way to do automounted snapshot mounting, we have extended the "zfs mount" (and unmount) commands to also accept snapshots. Ie, "zfs mount pool/dataset@snapshot". The mountpoint location is the same. I may have

[developer] zdb as desperate recovery

2018-12-06 Thread Jorgen Lundman
Hello list, Currently working on a 3rd user who has lost his pool and can not import it. It occurred to us that as a last-ditch recovery it would be nice if zdb could be enhanced to (attempt) copy out a file from the pool. I believe you can already "list" directories with the right set of m

Re: [developer] problems with ZFS on Linux, FreeBSD, OSX, and others

2018-11-28 Thread Jorgen Lundman
27;d like to pretend we are close to stable enough to call it "alpha". Maybe. Lund -- Jorgen Lundman | Unix Administrator | +81 (0)90-5578-8500 Shibuya-ku, Tokyo| Japan -- openzfs: openzfs-developer Permalink: https://openzfs.topi

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-10-03 Thread Jorgen Lundman
Refcounted DSL added - one missing `zvol_create_minors()` call in illumos, but I believe that is as expected. Added a couple of `(void)` before `refcount_add()` due to lint. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: h

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-10-03 Thread Jorgen Lundman
@lundman pushed 1 commit. bc64070 Refcounted DSL Crypto Key Mappings -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/e2df9b70741ea3c091a30c03c08847c7bacec46e..bc640707c92028b91bfe86437929b63fe484ea9f ---

[developer] Re: [openzfs/openzfs] Add SIGINFO feature to zfs send (#638)

2018-10-01 Thread Jorgen Lundman
lundman commented on this pull request. >*/ - if (sdd->progress) { That does seem to be the preference. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull

[developer] Re: [openzfs/openzfs] Add SIGINFO feature to zfs send (#638)

2018-10-01 Thread Jorgen Lundman
lundman commented on this pull request. > (void) fprintf(stderr, "TIMESENT SNAPSHOT\n"); /* * Print the progress from ZFS_IOC_SEND_PROGRESS every second. */ for (;;) { - (void) sleep(1); + + /* +

[developer] Re: [openzfs/openzfs] Add SIGINFO feature to zfs send (#638)

2018-09-17 Thread Jorgen Lundman
lundman commented on this pull request. > + pa.pa_zhp = zhp; + pa.pa_fd = outfd; + pa.pa_parsable = flags->parsable; + pa.pa_progress = flags->progress; + pa.pa_siginfo = flags->siginfo; + + if (pa.pa_siginfo) { +

[developer] Re: [openzfs/openzfs] 9688 aggsum_fini leaks memory (#679)

2018-08-22 Thread Jorgen Lundman
When running this commit on OsX, which is a little more strict with mutex release; we get this situation: ``` frame #4: kernel.development`panic(mutex_enter on destroyed mutex) at debug.c:605 [opt] frame #5: spl`spl_mutex_enter(mp=0xff886f557b00, file="aggsum.c", line=190) at spl-

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-07-24 Thread Jorgen Lundman
@lundman pushed 1 commit. 3972768 Do not call dmu_objset_disown twice -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/6f85552ff7a285fef0af14f31d322cc82bebd07c..3972768dc18f2f6b4b2c3c90ac9ce516f8e1cf99 -

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-07-24 Thread Jorgen Lundman
Woo, I contributed! \o/ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-407324973 -- openzfs: openzfs-developer Permalink: htt

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-07-13 Thread Jorgen Lundman
In the interest in making `dsl_crypto.c` and `zio_crypto.c` to be the same as ZOL - I added a few commits that messed around in there. [1] The 3a5bf20 commit will replace the gist I pasted in https://github.com/openzfs/openzfs/pull/489#issuecomment-404715592 [1] minus the QAT changes. -- You

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-07-13 Thread Jorgen Lundman
@lundman pushed 4 commits. 5c1f23d ZFS send fails to dump objects larger than 128PiB c97f857 Fix hash_lock / keystore.sk_dk_lock lock inversion 3010896 Separate the error code for already unloaded key 3a5bf20 Refactor arc_hdr_realloc_crypt() -- You are receiving this because you are subscri

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-07-12 Thread Jorgen Lundman
@GernotS Working on a theory to a couple of bugs over in OsX port, which might just help here as well. If you have the time/energy, could you see if this patch fixes things with "cache + crypto" and "raw receive" ? https://gist.github.com/lundman/5c269ae5582bac1adf2a58e7b9513c1b -- You are r

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-07-08 Thread Jorgen Lundman
Hmm alas, commit https://github.com/zfsonlinux/zfs/pull/7650/commits/5248401f8bf3d8149ba6e559fa94a075bfdff9d4 depends on https://github.com/zfsonlinux/zfs/commit/a3eeab2de68670a4481eab3d086982aff23b6906 and we have a fair bit of divergence in the property parsing between the two. I'm just here

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-07-04 Thread Jorgen Lundman
@lundman pushed 1 commit. 58e8434 Odd git merge decisions -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/d123482538a05e9ed8dcea8f2872ee72a52b0a3f..58e8434463cc1ffd99b4fedd8995e11ea3c4af7c --

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-07-04 Thread Jorgen Lundman
@lundman pushed 1 commit. d123482 Correct typo in zfs.1m -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/ab2d8ac94cf227207f80ca9b221ef7bd3bcd6e99..d123482538a05e9ed8dcea8f2872ee72a52b0a3f ---

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-07-04 Thread Jorgen Lundman
Dropped and re-added 7632, added 7667 and 7637. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-402581297 -- openzfs: openzfs-d

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-07-04 Thread Jorgen Lundman
@lundman pushed 3 commits. 23eb923 Raw receive fix and encrypted objset security fix 58dd6e4 Add ASSERT to debug encryption key mapping issues ab2d8ac Fix coverity defects: CID 176037 -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/o

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-06-14 Thread Jorgen Lundman
@lundman pushed 1 commit. d9fa7a3 [PATCH] Raw receive fix and encrypted objset security fix -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/3fbbbf14b40989ba17b65966d77cb27abff100c3..d9fa7a3b584f33433e414f

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-06-12 Thread Jorgen Lundman
@lundman pushed 1 commit. 02dceca [PATCH] Make zvol update volsize operation synchronous. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/ed11924afad60b692dee0cf34689e186533900a5..02dceca32e57399589f59d4f

Re: [developer] [openzfs/openzfs] Trying again with sequential scan -- this is simply (#648)

2018-06-10 Thread Jorgen Lundman
1d() vdev_queue_io_remove+0x13c(ff03ecd7dcc0, ff03e90bb7e8) vdev_queue_io_to_issue+0x1cb(ff03ecd7dcc0) vdev_queue_io_done+0x78(ff03e90fd060) zio_vdev_io_done+0xa8(ff03e90fd060) zio_execute+0xfa(ff03e90fd060) taskq_thread+0x318(ff03ecc769e0) thread_start+8() -

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-06-02 Thread Jorgen Lundman
@lundman pushed 1 commit. d95dfde Remove test not yet ported to illumos -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/473f80e35fb25e0778ab1678fa0f4fa7ed3a48c0..d95dfdee9d978010290cfde087b25f4e0da4f56d

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-06-01 Thread Jorgen Lundman
@lundman pushed 2 commits. 5da0a65 Raw receive functions must not decrypt data 473f80e Update the correct abd in l2arc_read_done() -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/9c0a780d61739bd28e15c5d5

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-24 Thread Jorgen Lundman
Ah, so that is the last outstanding issue? Do you want anything squashed? Squashed-to-some, or Squashed-to-one ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-39190

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-15 Thread Jorgen Lundman
latest rebase was non-trivial due to the parallel mount commit. I had to guess a bit. But good news, we are coming up to 2 year anniversary! \o/ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/ope

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-14 Thread Jorgen Lundman
@lundman pushed 1 commit. 1fa5148 Add support for decryption faults in zinject -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/31a00d3962866cf5c0f0c9755b4620a978fc312a..1fa5148fe59c8d1a7347fe5d1d5f5f4362a

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-08 Thread Jorgen Lundman
Not sure about that one, could be the new commits in master triggering something new, is probably beyond my abilities. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecommen

[developer] Re: [openzfs/openzfs] Add SIGINFO feature to zfs send (#638)

2018-05-08 Thread Jorgen Lundman
lundman commented on this pull request. > @@ -70,7 +70,8 @@ int lzc_get_holds(const char *, nvlist_t **); enum lzc_send_flags { LZC_SEND_FLAG_EMBED_DATA = 1 << 0, LZC_SEND_FLAG_LARGE_BLOCK = 1 << 1, - LZC_SEND_FLAG_COMPRESS = 1 << 2 + LZC_SEND_FLAG_COMPRESS = 1 << 2,

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-07 Thread Jorgen Lundman
@lundman pushed 1 commit. dad661b minor dbuf_read_done work -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/7743d9912c456bce8cc6085031ef7080c8c848a3..dad661b040d6e0d69089efc0513a450d004d61ca

[developer] [openzfs/openzfs] Add SIGINFO feature to zfs send (#638)

2018-05-07 Thread Jorgen Lundman
send load: 1.15 cmd: zfs 1523 waiting 0.04u 2.05s 16:29:30948M BOOM@send Signed-off-by: Jorgen Lundman You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/638 -- Commit Summary -- * Add SIGINFO feature to zfs send -- File Changes --

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-07 Thread Jorgen Lundman
Not sure about that, but in that place, ZOL has the following ``` ASSERT(db->db.db_data == NULL); if (db->db_level == 0 && db->db_freed_in_flight) { /* we were freed in flight; disregard any error */ +if (buf == NULL) { +buf =

[developer] Re: [openzfs/openzfs] Large alloc in zdb can cause trouble (#635)

2018-05-07 Thread Jorgen Lundman
https://github.com/openzfsonosx/zfs/commit/ced236a5da6e72ea7bf6d2919fe14e17cffe10f1 Boom, by 10 days! :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/635#issuecomment-387029887

[developer] [openzfs/openzfs] Large alloc in zdb can cause trouble (#635)

2018-05-07 Thread Jorgen Lundman
16MB alloc in zdb_embedded_block() can cause cores in certain situations (clang, gcc55). You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/635 -- Commit Summary -- * Large alloc in zdb can cause trouble -- File Changes -- M usr/src/

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-07 Thread Jorgen Lundman
@lundman pushed 1 commit. 7743d99 DMU objset should not be encrypted -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/099741e7ff87c29c3876debac50acbc99ce0ab26..7743d9912c456bce8cc6085031ef7080c8c848a3 ---

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-02 Thread Jorgen Lundman
Hmm odd it wasnt too big a conflict in `arc.c` but I'll go over it again -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-385909026

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-01 Thread Jorgen Lundman
@lundman pushed 1 commit. 099741e Correct ztest build -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/77c699a32931847d5557f0ebadcec07a680504b1..099741e7ff87c29c3876debac50acbc99ce0ab26 --

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-01 Thread Jorgen Lundman
Nah it's my fault, my VM is super slow, so its faster to rely on this build setup :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-385876826 --

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-01 Thread Jorgen Lundman
@lundman pushed 1 commit. 77c699a Correct merge collision -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/cd8b6763fa2413d2f3950c719a6f4f7024b5a768..77c699a32931847d5557f0ebadcec07a680504b1 --

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-01 Thread Jorgen Lundman
rebased and up to date -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-385841807 -- openzfs: openzfs-developer Permalink: http

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-01 Thread Jorgen Lundman
@lundman pushed 1 commit. a381944 Fix issues found with zfs diff -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/03c0787a23cdd0fc44a47690d69ffcfae64eb72b..a3819442d8617598d8e1463f8b52ea0589fe96cf ---

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-18 Thread Jorgen Lundman
Are you hinting that you want it rebased against master maybe? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-382294674 -- ope

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-18 Thread Jorgen Lundman
Hmm I don't even have `vdev_indirect.c:1356` ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-382291271 -- openzfs: openzfs-de

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-18 Thread Jorgen Lundman
Oppsie, my bad, one sec -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-382289822 -- openzfs: openzfs-developer Permalink: htt

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-17 Thread Jorgen Lundman
@lundman pushed 1 commit. dc23634 Fix issues with raw sends of spill blocks -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/5d6cd7d203a1eb182729d2390aedbe8d09ecf7a8..dc236348dd738254d462a5fdf8bc5e47ad6588

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-16 Thread Jorgen Lundman
@lundman pushed 2 commits. bc5a90b Correct swapped keylocation error messages 5d6cd7d Fix race in dnode_check_slots_free() -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/f46f0922baeffdc1b7b8750a4fe9ed4e

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-12 Thread Jorgen Lundman
@lundman pushed 1 commit. 893c519 receive_spill does not byte swap spill contents -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/2b622bf65fed5df4a70f8b63f9e9b42c4792bfea..893c519c9dcb7eae00acb466c9d19c2c

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-11 Thread Jorgen Lundman
@lundman pushed 1 commit. ef73ffd Move enum zio_encrypt into sys/fs/zfs.h -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/bf72974e371a6b1d097024f7cb567e9ea78fa65b..ef73ffd309419acb8389095d2887b2316cb1ba1d

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-10 Thread Jorgen Lundman
@lundman pushed 1 commit. bf72974 Correct manpage for --raw -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/097d997308675d4d2387d5bb8a786fb09a189dfc..bf72974e371a6b1d097024f7cb567e9ea78fa65b

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-10 Thread Jorgen Lundman
Not sure I'm seeing it. The difference to ZOL is that they have `zfs_main.c` add ``` #include "libzfs_impl.h" ``` But I can not add that to IllumOS, as none of the -I paths include `libzfs_impl.h` nor `sys/zio.h` - are you suggesting I change Makefiles to add the include path? As for existing pr

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-10 Thread Jorgen Lundman
Hmm that's defined in `zio.h` but the `cmd`'s tend not to include the sys/zfs* headers directly? Should they be in `zfs_context`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#is

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-09 Thread Jorgen Lundman
@lundman pushed 1 commit. 097d997 Make encrypted "zfs mount -a" failures consistent -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/da391edb5d7057961eda8585b6d6af08cda5d64d..097d997308675d4d2387d5bb8a786f

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-02 Thread Jorgen Lundman
@lundman pushed 3 commits. bdcf9d7 Encrypted dnode blocks should be prefetched raw f016fc4 Decryption error handling improvements 9b1e59f Remove ASSERT() in l2arc_apply_transforms() -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/ope

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-03-23 Thread Jorgen Lundman
@ahrens My apologies for missing the modes.c line, I have pulled the commit and added to osx. Alas, I can easily make crypto+cache panic happen on osx, (and not so easily on illumos) ``` arc.c arc_read 6180 : ASSERT3( hdr->b_l1hdr.b_buf == ((void *)0)) failed (0xff889975ce88 == 0) ``` --

[developer] Re: [openzfs/openzfs] 9164 assert: newds == os->os_dsl_dataset (#559)

2018-03-14 Thread Jorgen Lundman
Oh hey nice, this closes the old: https://www.illumos.org/issues/6183 thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/559#issuecomment-373218751 --

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-03-12 Thread Jorgen Lundman
@lundman pushed 1 commit. 1229496 Prevent raw zfs recv -F if dataset is unencrypted -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/46f0e13723be73c7000390d30f939148ce345a54..1229496a970e3c29a6340944fc862c

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-03-06 Thread Jorgen Lundman
@lundman pushed 3 commits. c2fed0a Raw receive should change key atomically 57afef4 Raw receives must compress metadnode blocks 3aff17a Add omitted set for os->os_next_write_raw -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-03-05 Thread Jorgen Lundman
@lundman pushed 2 commits. 17d49e9 Raw DRR_OBJECT records must write raw data 590e210 Fix bounds check in zio_crypt_do_objset_hmacs -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/98b8ac08d1a50fbde04fb8a

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-22 Thread Jorgen Lundman
On OsX I added a `cache device` to the crypt test, and I got: ``` panic(cpu 0 caller 0xff8027ec8132): Kernel trap at 0xff7fab62a0cc, type 14=page fault, registers: 0xff8087a43d60 : 0xff8027cfc200 mach_kernel : trap_from_kernel + 0x26 0xff8087a43d80 : 0xff7fab62a0cc net.lun

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-21 Thread Jorgen Lundman
``` it should be like ZOL's l2arc_write_buffers, make it so! Done! ``` More fictionally chat logs to come, hopefully this will address @GernotS issue. Cheers! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-21 Thread Jorgen Lundman
@lundman pushed 1 commit. 7b94083 Correct l2arc_write_buffers() -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/3803144fa6df4913e94a4b35884c90fb08a6eda3..7b9408363a8a3bd53426e6b57773f43afac204ec

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-15 Thread Jorgen Lundman
It is interesting that `l2arc_write_buffers` is one of the places the merge was not smooth. Re-porting the function from clean did not change much alas, adding flag `ARC_FLAG_L2_WRITING` . The IllumOS version has an extra chunk of code that the other platforms have: ```

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-15 Thread Jorgen Lundman
@lundman pushed 1 commit. 5ebecdd Re-port l2arc_write_buffers just in case -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/a3b2b17888259e1af5f0e99ee3eb8333ec43636f..5ebecddbb034b7ff71a75d01be1cd7b4501d9b5

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-08 Thread Jorgen Lundman
(No changes, just fixed conflicts with master) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-364290139 -- openzfs-developer A

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-08 Thread Jorgen Lundman
Well, that's good.. Not sure what to do next then, perhaps @GernotS can provide a dump file, and someone who actually knows how to use mdb (I sure don't) can be coaxed into glancing at it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or v

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-07 Thread Jorgen Lundman
I've run out of obvious looking diffs between ZOL and this commit. Might require actual debugging now. Seems to die pretty early in `arc_buf_remove` but it'd be nice to know where. ZOL also has a `arc_buf_access()` called from `dbuf` but the ZOL commit 0873bb63 just talks about counting stats.

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-07 Thread Jorgen Lundman
Neat, I didn't mention the commit today, since the ZOL tickets just talked about send|recv :) Still unable to reproduce dnode_destroy panic, but the tester here seems to die though -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-06 Thread Jorgen Lundman
@lundman pushed 1 commit. 114b91e Handle compressed buffers in __dbuf_hold_impl() -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/d6cda08bf1d56c7f960d626687818f071ab27250..114b91e4d42657e243d0eb670de58579

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-05 Thread Jorgen Lundman
I was unable to replicate: ``` write: No space left on device 8245278720 bytes transferred in 1880.011589 secs (4385760 bytes/sec) ``` But that could simply be that I don't get dbuf eviction triggered. However I did find some differences between the two versions, perhaps it will help. -- You

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-05 Thread Jorgen Lundman
@lundman pushed 1 commit. d6cda08 Correct differences in arc.c for crypto -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/3fe3c5c86306386a7acb06e153626c635fa27858..d6cda08bf1d56c7f960d626687818f071ab27250

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-02 Thread Jorgen Lundman
@lundman pushed 1 commit. 3fe3c5c Update cryptv0 test pool -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/fda748267547c10116f660c7f842716d67ecaa94..3fe3c5c86306386a7acb06e153626c635fa27858 -

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-02-02 Thread Jorgen Lundman
@lundman pushed 2 commits. 8ba4e1a Change os->os_next_write_raw to work per txg fa283bb Raw sends must be able to decrease nlevels -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/2a59a6d66edd8196f30acc6d

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-01-23 Thread Jorgen Lundman
@lundman pushed 1 commit. d4419bc Only restore the readonly bit when it was readonly -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/22f72c962dca7deb335c90925e8a9070d40ff093..d4419bc1f529dc9233a3432e23a57

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-01-10 Thread Jorgen Lundman
This now includes the ZOL https://github.com/zfsonlinux/zfs/pull/6864 PR as well, so we can test `zfs send --raw` fixes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomme

Re: [developer] Re: non-linear abd_alloc_for_io vs zio_checksum_compute

2017-12-02 Thread Jorgen Lundman
Andriy Gapon wrote: On 23/11/2017 18:05, Andriy Gapon wrote: I've done a little experimentation with a version of abd_alloc_for_io() that returns a chunked abd. zio_checksum_compute() couldn't cope with that in the Another detail that's not directly related to the above is that even now we do

[developer] Re: [openzfs/openzfs] fixed arc_cksum_is_equal() that doesn't take into account ABD-logic (#498)

2017-11-22 Thread Jorgen Lundman
Or maybe I am overselling, perhaps the hours of ABD fixes in raidz was *because* of the crypto changes. But it did lead us to doing something like https://github.com/openzfsonosx/zfs/commit/5995f89c1eeae7f029b3537564780458c2920f44 so we could be sure the wrong buffer was not passed into ABD.

[developer] Re: [openzfs/openzfs] fixed arc_cksum_is_equal() that doesn't take into account ABD-logic (#498)

2017-11-22 Thread Jorgen Lundman
I believe we corrected those over in the crypto PR, and I think there were a few in vdev_raidz's parity work as well, if you want to fix those too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/o

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2017-11-09 Thread Jorgen Lundman
@behlendorf Thanks, now included. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-343345787 -- openzfs-developer Archives: htt

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2017-11-09 Thread Jorgen Lundman
@lundman pushed 1 commit. 6e7e407 Disable crypto tests in ztest -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/c174b022b5328a9e4fd0296d28436b69281bb462..6e7e407fa596dd3bfbc866b6f8f000cf65d48be6

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2017-11-09 Thread Jorgen Lundman
https://github.com/zfsonlinux/zfs/issues/6845 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-34795 -- openzfs-developer Arc

[developer] [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2017-11-01 Thread Jorgen Lundman
d. Reviewed by: Matthew Ahrens Reviewed-by: Brian Behlendorf Reviewed-by: Jorgen Lundman Signed-off-by: Tom Caputi Send / Recv Fixes following b52563 This patch fixes several issues discovered after the encryption patch was merged: Fixed a bug where encrypted da

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#124)

2017-11-01 Thread Jorgen Lundman
Closed #124. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/124#event-1320801076 -- openzfs-developer Archives: https://openzfs.topicbox.com/gr

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#124)

2017-11-01 Thread Jorgen Lundman
Closed in favour of https://github.com/openzfs/openzfs/pull/489 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/124#issuecomment-341079785 -- op

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#124)

2017-10-31 Thread Jorgen Lundman
@ahrens This is the first PR, followed by all fixes, two more PRs and fixes. It has everything in it that ZoL has. I don't think it is so much about what I need, but what you want to happen next. -- You are receiving this because you are subscribed to this thread. Reply to this email directly o

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-12 Thread Jorgen Lundman
Looks like we managed to pass all tests finally. I plan to squash everything into one single commit unless there is some other number of commits people would prefer..? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https:

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-11 Thread Jorgen Lundman
I agree with everything you say, I already have had to change a quite a few things to the $ENV version on osx. It certainly would be nice if such a standard was agreed upon -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-11 Thread Jorgen Lundman
I prefer `print` myself, but there were no uses of `print` in existing zfs-tester test files, whereas there was precedent in using `tr -d` in `zfs_create_014_pos`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://gi

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-11 Thread Jorgen Lundman
@lundman pushed 1 commit. d6a584c Change both echo -n this time -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/124/files/bf0d5b058d816c14a0934bb67bde6b9aa1b82d92..d6a584cd430fe9f66955234035deec46e7cb5ad9

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-11 Thread Jorgen Lundman
@lundman pushed 2 commits. 53406a2 More corrections to testers bf0d5b0 Disable dump on encrypted zvol -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/124/files/14424ba0610e4ae07057a630538a1c1860dcc3a0..bf0d5b058d8

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-10 Thread Jorgen Lundman
@lundman pushed 1 commit. 14424ba Add missing async destroy fix -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/124/files/599316ee7968e43c125cbd1d40bffc91099dbdea..14424ba0610e4ae07057a630538a1c1860dcc3a0

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-10 Thread Jorgen Lundman
Ah well spotted, thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/124#issuecomment-335667635 -- openzfs-developer Archives: https://open

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-10 Thread Jorgen Lundman
@lundman pushed 1 commit. 599316e OpenZFS repo runs delphix.run in tests, so update it to match -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/124/files/fba7a78847ee76f1c86db525e50e44a710575e15..599316ee7968e43c12

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-09 Thread Jorgen Lundman
@lundman pushed 1 commit. fba7a78 Disable crypto tests in ztest -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/124/files/bc464bb4c05d2871ace8dc19c34d35557b95d983..fba7a78847ee76f1c86db525e50e44a710575e15

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-05 Thread Jorgen Lundman
@lundman pushed 1 commit. 1de4adf Correct vdev_raidz calling ereport to use abd. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/124/files/e055647b456151a0081a9ee8b2a873d4b57e5611..1de4adf76c19b8c4dfa43fbe02b89adba

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-05 Thread Jorgen Lundman
@lundman pushed 1 commit. e055647 Full diff against ZOL commits changes -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/124/files/8748ffbae446572cf0e7423671e9a06b29c9e8bb..e055647b456151a0081a9ee8b2a873d4b57e5611

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-04 Thread Jorgen Lundman
This PR has been updated with latest commits up and including Oct 2nd "060e4cf33002c4". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/124#issuecomment-334077937 -

  1   2   >