[developer] Re: [openzfs/openzfs] 6037 zfs(1M) needs to handle unknown uid/gid in context of allow/unallow more gracefully (#690)

2018-09-06 Thread LOLi
> Without the change there would be no way other than recreating a user/group > that occupies the same UID/GID to revoke a granted permission to unknown user. This issue has been reported yesterday in the ZFS on Linux mailing list: it would be nice to get it fixed but maybe we should add a new

[developer] [openzfs/openzfs] 9512 zfs remap poolname@snapname dumps core (#633)

2018-04-30 Thread LOLi
Only filesystems and volumes are valid 'zfs remap' parameters: when passed a snapshot name zfs_remap_indirects() does not handle the EINVAL returned from libzfs_core, which results in failing an assertion and consequently crashing. ``` loli@openindiana:~$ uname -a SunOS openindiana 5.11 master

[developer] [openzfs/openzfs] 9125 mdb's ::zfs_params needs updating (#554)

2018-02-17 Thread LOLi
Running `::zfs_params` on a semi-recent Illumos build (8a051e3a96) produces the following warning: ``` mdb: variable zfetch_block_cap not found: unknown symbol name ``` Full output: ``` loli@openindiana:~$ uname -a SunOS openindiana 5.11 master-0-g8a051e3a96 i86pc i386 i86pc loli@openindiana

[developer] Re: [openzfs/openzfs] XXX Attempt to fix remove_mirror (#534)

2018-02-05 Thread LOLi
condition, sorry i wasn't clear. Full output when the test fails: ``` loli@openindiana:~$ export DISKS='c4t0d0 c4t1d0 c4t2d0' loli@openindiana:~$ ppriv -s EIP=basic -e /opt/zfs-tests/bin/zfstest -c /opt/zfs-tests/runfiles/illumos-8940.run Test: /opt/zfs-tests/tests/functional/removal/remove_mirror

[developer] [openzfs/openzfs] 8942 zfs promote .../%recv should be an error (#512)

2018-01-03 Thread LOLi
If we are in the middle of an incremental 'zfs receive', the child .../%recv will exist. If we run 'zfs promote' .../%recv, it will "work", but then zfs gets confused about the status of the new dataset. Attempting to do this promote should be an error. Similarly renaming .../%recv datasets

[developer] [openzfs/openzfs] 8941 Assertion failed in get_replication() with nested interior VDEVs (#511)

2017-12-31 Thread LOLi
When replacing a faulted device which was previously handled by a spare multiple levels of nested interior VDEVs will be present in the pool configuration: `get_replication()` needs to handle this situation gracefully to let zpool add new devices to the pool: ``` root@openindiana:~#

[developer] [openzfs/openzfs] 8940 Sending an intra-pool resumable send stream may result in EXDEV (#510)

2017-12-30 Thread LOLi
`zfs send -t ` for an incremental send should be able to resume successfully when sending to the same pool: a subtle issue in `zfs_iter_children()` doesn't currently allow this. Because resuming from a token requires "guid" -> "dataset" mapping (`guid_to_name()`), we have to walk the whole

[developer] [openzfs/openzfs] 0000 Buffer overflow in dsl_dataset_name() (#476)

2017-10-09 Thread LOLi
If we're creating a pool with version >= SPA_VERSION_DSL_SCRUB (v11) we need to account for additional space needed by the origin dataset which will also be snapshotted: "poolname"+"/"+"$ORIGIN"+"@"+"$ORIGIN". Enforce this limit in `pool_namecheck()`. Ported from

[developer] Re: [openzfs/openzfs] 0000 Fix range locking in ZIL commit codepath (#462)

2017-09-11 Thread LOLi
I'm sorry, i forgot to report here that "_panic: allocating allocated segment_" is the same bug happening on non-debug builds. I only have a debug build of Illumos, but the troubleshooting was originally done to fix https://github.com/zfsonlinux/zfs/issues/6315 which is a non-debug ZFSonLinux

[developer] [openzfs/openzfs] 8477 Assertion failed in vdev_state_dirty(): spa_writeable(spa) (#420)

2017-07-10 Thread LOLi
Illumos 4080 inadvertently allows `zpool clear` on readonly pools: fix this by reintroducing a check (`POOL_CHECK_READONLY`) in the `zfs_ioc_clear` registration code. Because i don't think we should be allowed to clear readonly pools. Probably. Completely related to this, when we try to `zpool

[developer] [openzfs/openzfs] 8408 dsl_props_set_sync_impl() does not handle nested nvlists correctly (#405)

2017-06-17 Thread LOLi
When iterating over the input nvlist in `dsl_props_set_sync_impl()` when we don't preserve the nvpair name before looking up `ZPROP_VALUE`, so when we later go to process it `nvpair_name()` is always "value" instead of the actual property name. These are properties set on a filesystem when

[developer] Re: [openzfs/openzfs] 8168 race in zfs_create(): null pointer dereference (#373)

2017-05-23 Thread LOLi
When this change was tested on Linux, zfs_create_013_pos did in fact mark those as UNSUPPORTED (http://build.zfsonlinux.org/builders/Amazon%202015.09%20x86_64%20Release%20%28TEST%29/builds/2293/steps/shell_9/logs/log) ``` Test:

[developer] [openzfs/openzfs] 8168 race in zfs_create(): null pointer dereference (#373)

2017-05-06 Thread LOLi
Originally discovered and reported on ZFS on Linux, copy/pasting here relevant contents: If we manage to export the pool on which we are creating a dataset (filesystem or zvol) between ```libzfs`zfs_create()``` entrypoint and ```libzfs`zpool_open()``` call (for which we never check the return