Closed #392 via aaabdc07fcc434413c1e2ae238411a8a4d5bfa9f.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/392#event-1122580323
--
openzfs-develop
Thanks; I'll open the RTI for this later today.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/392#issuecomment-308161200
--
openzfs-developer
A
Looks like it was unrelated after all, everything passed this time.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/392#issuecomment-308071058
--
@gwr Changes look good to me, we need to investigate the test failure. It
looks like maybe the machine running zloop died? @prakashsurya might be able
to help out.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://g
ahrens approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/392#pullrequestreview-43272682
--
openzfs-developer
Archiv
What's next for this? more reviewers? RTI? Thx!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/392#issuecomment-307500204
--
openzfs-developer
gwr commented on this pull request.
> +{
+ nvlist_t*nvl = NULL;
+ int err;
+
+ err = nvlist_alloc(&nvl, NV_UNIQUE_NAME, 0);
+ if (err != 0)
+ return (err);
+
+ (void) nvlist_add_boolean_value(nvl, A_READONLY, 1);
+
+ if (fname
jwk404 commented on this pull request.
> +{
+ nvlist_t*nvl = NULL;
+ int err;
+
+ err = nvlist_alloc(&nvl, NV_UNIQUE_NAME, 0);
+ if (err != 0)
+ return (err);
+
+ (void) nvlist_add_boolean_value(nvl, A_READONLY, 1);
+
+ if (fn
jwk404 approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/392#pullrequestreview-42890480
--
openzfs-developer
Archiv
gwr commented on this pull request.
> +{
+ nvlist_t*nvl = NULL;
+ int err;
+
+ err = nvlist_alloc(&nvl, NV_UNIQUE_NAME, 0);
+ if (err != 0)
+ return (err);
+
+ (void) nvlist_add_boolean_value(nvl, A_READONLY, 1);
+
+ if (fname
jwk404 commented on this pull request.
> +{
+ nvlist_t*nvl = NULL;
+ int err;
+
+ err = nvlist_alloc(&nvl, NV_UNIQUE_NAME, 0);
+ if (err != 0)
+ return (err);
+
+ (void) nvlist_add_boolean_value(nvl, A_READONLY, 1);
+
+ if (fn
The latest test run for this PR passed, see
[here](http://jenkins.open-zfs.org/job/openzfs/job/openzfs/job/PR-392/4/display/redirect)
(not sure why the commit status wasn't updated to reflect that).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directl
my bad - forgot to update the test case itself (it still had "$CHMOD", "$RM"...)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/392#issuecomment-306277518
-
The dos_ro binary should be added to commands.cfg (in the same directory).
default.cfg is no longer used that way.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/392#issuecomment-3061
Looks like a piece of this change got dropped:
```
diff --git a/usr/src/test/zfs-tests/include/default.cfg
b/usr/src/test/zfs-tests/include/default.cfg
index 635f3f0b15..56b41b6250 100644
--- a/usr/src/test/zfs-tests/include/default.cfg
+++ b/usr/src/test/zfs-tests/include/default.cfg
@@ -45,6 +45
this failed the `acl/cifs/cifs_attr_004_pos` test of zftest; is this related to
this patch? I don't recall seeing that fail on any other PRs. looking
[here](http://jenkins.open-zfs.org/job/openzfs/job/openzfs/job/PR-392/1/artifact/run-zfs-tests.log)
I can see the output for that test is:
```
Tes
Thanks for putting this together, @yuripv
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/392#issuecomment-305985005
--
openzfs-developer
Archiv
Looks good to me. I suspect this will also solve an unrelated issue I've seen
with netatalk.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/392#issuecomment-305920296
---
18 matches
Mail list logo
