Updated version of this is here: https://www.illumos.org/rb/r/1224/
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/409#issuecomment-428652593
--
Before merging this you there are a couple recent bug fixes related to large
dnodes you should be aware of and may want to include in this PR.
- https://github.com/zfsonlinux/zfs/pull/6564 - There was an unfortunate
interaction with OpenZFS 8199, the multi-threaded `dmu_object_alloc()`, which
c
ahrens commented on this pull request.
> int err;
- if (dmu_object_info(rwa->os, obj, NULL) != 0)
+ err = dmu_object_info(rwa->os, obj, &doi);
I agree this is unnecessary; I'll revert it.
--
You are receiving this because you are subscribed to this
@ahrens pushed 1 commit.
5955b31 typo
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/409/files/5df44fb5d17d849a3104caf9fcf2bcff83c3c736..5955b3114619f6d79986993d9dedc9d213f63ed0
--
pcd1193182 approved this pull request.
Send receive code looks fine to me, just one small question.
> int err;
- if (dmu_object_info(rwa->os, obj, NULL) != 0)
+ err = dmu_object_info(rwa->os, obj, &doi);
Why change this to add the argument?
--
You ar
grwilson approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/409#pullrequestreview-58659280
--
openzfs-developer
Arch
> There are lots of good comments in the pull request that aren't referenced in
> the actual code. It would be good to incorporate some of these as comments
I agree. I've updated the PR, copying much of the commit message into a
comment in dnode.h.
--
You are receiving this because you are su
ahrens commented on this pull request.
/*
* All forms of zfs create (create, mkdir, mkxattrdir, symlink)
* eventually end up in zfs_mknode(), which assigns the object's
-* creation time and generation number. The generic VOP_CREATE()
-* doesn't have eit
grwilson commented on this pull request.
There are lots of good comments in the pull request that aren't referenced in
the actual code. It would be good to incorporate some of these as comments.
/*
* All forms of zfs create (create, mkdir, mkxattrdir, symlink)
* eventua
Note: this is a port of:
https://github.com/zfsonlinux/zfs/commit/50c957f702ea6d08a634e42f73e8a49931dd8055
and
https://github.com/zfsonlinux/zfs/commit/08f0510d87186575db00269fff17a3409de5ceb6
. I had to make a few small changes to get it to pass lint, which are captured
here: https://github.c
10 matches
Mail list logo
