Closed #422 via 20ef1b6ac3c13799cfc3ef7a6a4c350f97b34c63.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/422#event-1238084697
--
openzfs-develop
grwilson approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/422#pullrequestreview-58790150
--
openzfs-developer
Arch
Dear reviewers: my most recent commit is just a comment change, so no retest is
necessary.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/422#issuecomment-325055352
--
@asomers pushed 1 commit.
3c5ae23 Fix an out-of-date comment as suggested by grwilson
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/422/files/09a25d80346e8685feccde4a312d02114ca7ad12..3c5ae23d880799bd393b09b75eff
asomers commented on this pull request.
> c = vd->vdev_children;
mm = kmem_zalloc(offsetof(mirror_map_t, mm_child[c]), KM_SLEEP);
mm->mm_children = c;
- mm->mm_replacing = (vd->vdev_ops == &vdev_replacing_ops ||
+ /*
+
grwilson commented on this pull request.
> c = vd->vdev_children;
mm = kmem_zalloc(offsetof(mirror_map_t, mm_child[c]), KM_SLEEP);
mm->mm_children = c;
- mm->mm_replacing = (vd->vdev_ops == &vdev_replacing_ops ||
+ /*
+
I discovered the problem using our version of the ZFS test suite. I patched it
in our product back in January 2013, but I have never pushed the patch upstream
(to OpenZFS or FreeBSD) until now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
@asomers Can you tell us about any history of real-world use of this patch,
e.g. in your product or in FreeBSD?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/422#issuecomment-3247610
ahrens approved this pull request.
This looks good to me but I'd also like @grwilson to take a look.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/422#pullrequestreview-58514036
--
What else do we need to do for this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/422#issuecomment-324754857
--
openzfs-developer
Archives:
LGTM.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/422#issuecomment-318613316
--
openzfs-developer
Archives:
https://openzfs.topicbox.com/gro
Can I please get some review on this? Without this change, ZFS will fail to
detect corruption on an active spare, even when you scrub it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pu
12 matches
Mail list logo
