[developer] Re: [openzfs/openzfs] 8520 lzc_rollback_to should support rolling back to origin (#434)

2018-02-07 Thread Prakash Surya
Closed #434 via 78a5a1a25a7da81ed26d113699f3258dabd240ef. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/434#event-1463849593 --

[developer] Re: [openzfs/openzfs] 8520 lzc_rollback_to should support rolling back to origin (#434)

2017-09-11 Thread Andriy Gapon
avg-I commented on this pull request. > + * See if the snapshot is a snapshot of the filesystem +* or the snapshot is an origin of the filesystem. +*/ + if (snapds->ds_dir == ds->ds_dir || +

[developer] Re: [openzfs/openzfs] 8520 lzc_rollback_to should support rolling back to origin (#434)

2017-09-11 Thread Andriy Gapon
avg-I commented on this pull request. - dsl_dataset_name(ds->ds_prev, namebuf); - if (strcmp(namebuf, ddra->ddra_tosnap) != 0) - return (SET_ERROR(EXDEV)); + /* Check if the target snapshot exists at all. */ + error =

[developer] Re: [openzfs/openzfs] 8520 lzc_rollback_to should support rolling back to origin (#434)

2017-09-07 Thread Matthew Ahrens
ahrens commented on this pull request. looks good aside from the comment updates I noted > + * See if the snapshot is a snapshot of the filesystem +* or the snapshot is an origin of the filesystem. +*/ +