ahrens approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/498#pullrequestreview-87678778
--
openzfs-developer
@ahrens does this look good with the latest changes?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/498#issuecomment-356424341
--
ahrens commented on this pull request.
> @@ -1549,6 +1549,8 @@ arc_cksum_is_equal(arc_buf_hdr_t *hdr, zio_t *zio)
void *cbuf = zio_buf_alloc(HDR_GET_PSIZE(hdr));
csize = zio_compress_data(compress, zio->io_abd, cbuf, lsize);
+ abd_t *cdata =
@prakashsurya again the same fail
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/498#issuecomment-347252303
--
openzfs-developer
Archives:
hmm, test-build failed because of
```could not determine the workspace used to perform the build```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/498#issuecomment-346619367
Or maybe I am overselling, perhaps the hours of ABD fixes in raidz was
*because* of the crypto changes. But it did lead us to doing something like
https://github.com/openzfsonosx/zfs/commit/5995f89c1eeae7f029b3537564780458c2920f44
so we could be sure the wrong buffer was not passed into ABD.
I believe we corrected those over in the crypto PR, and I think there were a
few in vdev_raidz's parity work as well, if you want to fix those too.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://www.illumos.org/issues/8856
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/498#issuecomment-346394055
--
openzfs-developer
Archives:
Ramzec commented on this pull request.
> @@ -1567,7 +1569,7 @@ arc_cksum_is_equal(arc_buf_hdr_t *hdr, zio_t *zio)
bzero((char *)cbuf + csize, HDR_GET_PSIZE(hdr) - csize);
ok. will do.
--
You are receiving this because you are subscribed to this thread.
Reply to this
grwilson commented on this pull request.
> @@ -1567,7 +1569,7 @@ arc_cksum_is_equal(arc_buf_hdr_t *hdr, zio_t *zio)
bzero((char *)cbuf + csize, HDR_GET_PSIZE(hdr) - csize);
BTW, this wasn't part of your change but this also looks broken. I believe that
we should be
grwilson approved this pull request.
Changes look good. Make sure you open up an illumos bug for this this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
11 matches
Mail list logo
