Re: [developer] read-only pool, remove vdev

2017-10-17 Thread Andriy Gapon
On 17/10/2017 19:05, George Wilson wrote: > Andriy, > > I'm not familiar with spa_async_thread_vd() (I don't believe that is > upstreamed > yet) so I can't comment on what is the correct thing to do there. Oh, I didn't realize that that part of the code was FreeBSD only. Alexander made the chang

Re: [developer] read-only pool, remove vdev

2017-10-17 Thread George Wilson
Andriy, I'm not familiar with spa_async_thread_vd() (I don't believe that is upstreamed yet) so I can't comment on what is the correct thing to do there. As for spa_async_thread(), I think we can ignore all tasks when the pool is read-only. You'll probably need to update the call to vdev_probe() i

[developer] read-only pool, remove vdev

2017-10-17 Thread Andriy Gapon
Both spa_async_thread() and spa_async_thread_vd() assert that spa_sync_on is true. I think that the logic to ensure that is sound except for one case. Specifically, if a pool is imported read-only, then spa_sync_on is never set to true (which is correct), but spa_async_suspended is not incremente