Re: [OpenZFS Developer] l2arc compression buffers leak

2014-01-14 Thread Matthew Ahrens
On Tue, Jan 14, 2014 at 6:44 AM, Andriy Gapon a...@freebsd.org wrote: There is a FreeBSD mailing list report that seems to point to a potential issue with buffers used for L2ARC compression. This message in the thread should explain my suspicions:

Re: [OpenZFS Developer] l2arc_write_buffers scanning efficiency

2014-01-14 Thread Saso Kiselkov
On 1/14/14, 11:51 AM, Andriy Gapon wrote: Recently I noticed that on one of our systems l2arc_feed_thread was consuming non insignificant amount of CPU time. I looked at some stats (FreeBSD has local changes that add a few kstats for L2ARC) and it seems that the thread was busy scanning

Re: [OpenZFS Developer] l2arc_write_buffers scanning efficiency

2014-01-14 Thread George Wilson
LGTM. - George On 1/14/14 12:57 PM, Saso Kiselkov wrote: On 1/14/14, 11:51 AM, Andriy Gapon wrote: Recently I noticed that on one of our systems l2arc_feed_thread was consuming non insignificant amount of CPU time. I looked at some stats (FreeBSD has local changes that add a few kstats for

Re: [OpenZFS Developer] l2arc_write_buffers scanning efficiency

2014-01-14 Thread Andriy Gapon
on 14/01/2014 19:57 Saso Kiselkov said the following: On 1/14/14, 11:51 AM, Andriy Gapon wrote: Recently I noticed that on one of our systems l2arc_feed_thread was consuming non insignificant amount of CPU time. I looked at some stats (FreeBSD has local changes that add a few kstats for

Re: [OpenZFS Developer] l2arc_write_buffers scanning efficiency

2014-01-14 Thread Niels de Carpentier
on 14/01/2014 19:57 Saso Kiselkov said the following: On 1/14/14, 11:51 AM, Andriy Gapon wrote: Recently I noticed that on one of our systems l2arc_feed_thread was consuming non insignificant amount of CPU time. I looked at some stats (FreeBSD has local changes that add a few kstats for