[OpenZFS Developer] ctldir VN_HOLDS error case?

2014-05-06 Thread Jorgen Lundman
Hello masters, So I have a small question about zfs_ctldir.c's holds being leaked in error cases. Basically, in this case here: https://github.com/illumos/illumos-gate/blob/master/usr/src/uts/common/fs/zfs/zfs_ctldir.c#L813 if (gfs_lookup_dot(vpp, dvp, zfsvfs-z_ctldir, nm) == 0) {

Re: [OpenZFS Developer] ctldir VN_HOLDS error case?

2014-05-06 Thread Jorgen Lundman
Matthew Ahrens wrote: You may be misreading this code. If gfs_lookup_dot() is successful, the vnode is held and we return immediately from the code you quoted. If there was an error (e.g. the name is not . or ..), we continue in this funciton, and *vpp is not a held vnode. Ahh good, that

Re: [OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics

2014-05-06 Thread George Wilson
Steven, I think there is probably another way we can solve this problem but I first want to get a better understanding of the corruption. We have not integrated the TRIM support upstream and I suspect that's the source of most of the problems. Can you confirm that with TRIM disabled that most