Re: [OpenZFS Developer] Review Request 229: account for ashift when choosing buffers to be written to l2arc device

2015-08-26 Thread George Wilson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/229/#review764 --- Ship it! Ship It! - George Wilson On June 25, 2015, 12:34 p.m.,

Re: [OpenZFS Developer] Review Request 229: account for ashift when choosing buffers to be written to l2arc device

2015-08-26 Thread George Wilson
Andriy, Looking now. Thanks, George On Wed, Aug 26, 2015 at 10:05 AM, Andriy Gapon nore...@csiden.org wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/229/ On June 19th, 2015, 12:09 a.m. EEST, *Matthew Ahrens* wrote: Looks good to me. Would

Re: [OpenZFS Developer] rt-rt_space is not zero. range_tree.c:153

2015-08-26 Thread George Wilson
Jorgen, Can you provide some details about the stack trace when you hit this failure. All of the ms_freetrees should be empty by the time you can range_tree_destroy(). So to debug this we need to understand the calling stack to determine why that isn't happening. Thanks, George On Sat, Aug 22,