libzfs_sendrecv.c: 2718-2719, this comment is inaccurate, you set all props
every time.
Several of the other large comments you're adding seem wrong, please
re-check them.
extract_delay_props(), rather than "dontbother", you could see if the
nvlist is empty and if so destroy it.
LGTM.
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/43#issuecomment-161622259___
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
Description edited as I seem to have triggered a github bug when creating the
two PR, where the description from the previous PR was used instead of the
commit message from this.
---
Reply to this email directly or view it on GitHub:
Can one of the admins verify this patch?
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/44#issuecomment-161599659___
developer mailing list
developer@open-zfs.org
Can one of the admins verify this patch?
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/43#issuecomment-161597694___
developer mailing list
developer@open-zfs.org
LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/44#issuecomment-161621968___
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
ASSERT the type of zio's processed by file and disk vdevs, which helps protect
against invalid zio being processed by these vdev types e.g. on FreeBSD which
uses ZIO_TYPE_FREE for TRIM support.
This was included in FreeBSD at part of r274619 (Nov 17 2014).
You can view, comment on, or merge
I have recently discovered that there is another scenario where new holes are
treated as old in a sparse file. This happens, for instance, if on truncates a
file, then writes past the end of file leaving a hole that is large enough to
cover an Ln range (n >= 1), and then partially overwrites
@zettabot go
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/44#issuecomment-161734901___
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
@zettabot go
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/43#issuecomment-161735143___
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
10 matches
Mail list logo