Re: [OpenZFS Developer] [zfs] Now with improved tests -- 4986

2015-12-03 Thread Matthew Ahrens
libzfs_sendrecv.c: 2718-2719, this comment is inaccurate, you set all props every time. Several of the other large comments you're adding seem wrong, please re-check them. extract_delay_props(), rather than "dontbother", you could see if the nvlist is empty and if so destroy it.

Re: [OpenZFS Developer] [openzfs] ASSERT supported zio_types for file and disk vdevs (#43)

2015-12-03 Thread George Wilson
LGTM. --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/43#issuecomment-161622259___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer

Re: [OpenZFS Developer] [openzfs] Fix mutex leak in dmu_objset_find_dp (#44)

2015-12-03 Thread Steven Hartland
Description edited as I seem to have triggered a github bug when creating the two PR, where the description from the previous PR was used instead of the commit message from this. --- Reply to this email directly or view it on GitHub:

Re: [OpenZFS Developer] [openzfs] Fix mutex leak in dmu_objset_find_dp (#44)

2015-12-03 Thread zettabot
Can one of the admins verify this patch? --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/44#issuecomment-161599659___ developer mailing list developer@open-zfs.org

Re: [OpenZFS Developer] [openzfs] ASSERT supported zio_types for file and disk vdevs (#43)

2015-12-03 Thread zettabot
Can one of the admins verify this patch? --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/43#issuecomment-161597694___ developer mailing list developer@open-zfs.org

Re: [OpenZFS Developer] [openzfs] Fix mutex leak in dmu_objset_find_dp (#44)

2015-12-03 Thread George Wilson
LGTM --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/44#issuecomment-161621968___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer

[OpenZFS Developer] [openzfs] ASSERT supported zio_types for file and disk vdevs (#43)

2015-12-03 Thread Steven Hartland
ASSERT the type of zio's processed by file and disk vdevs, which helps protect against invalid zio being processed by these vdev types e.g. on FreeBSD which uses ZIO_TYPE_FREE for TRIM support. This was included in FreeBSD at part of r274619 (Nov 17 2014). You can view, comment on, or merge

Re: [OpenZFS Developer] [openzfs] 6370 ZFS send fails to transmit some holes (#37)

2015-12-03 Thread Boris Protopopov
I have recently discovered that there is another scenario where new holes are treated as old in a sparse file. This happens, for instance, if on truncates a file, then writes past the end of file leaving a hole that is large enough to cover an Ln range (n >= 1), and then partially overwrites

Re: [OpenZFS Developer] [openzfs] Fix mutex leak in dmu_objset_find_dp (#44)

2015-12-03 Thread Matthew Ahrens
@zettabot go --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/44#issuecomment-161734901___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer

Re: [OpenZFS Developer] [openzfs] ASSERT supported zio_types for file and disk vdevs (#43)

2015-12-03 Thread Matthew Ahrens
@zettabot go --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/43#issuecomment-161735143___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer