Re: [OpenZFS Developer] [openzfs] Possible access beyond end of string in zpool comment (#47)

@zettabot go --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/47#issuecomment-165751107___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer

Re: [OpenZFS Developer] [openzfs] Possible access beyond end of string in zpool comment (#47)

LGTM --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/47#issuecomment-165781640___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer

Re: [OpenZFS Developer] [openzfs] Possible access beyond end of string in zpool comment (#47)

I'm SO sorry for introducing that. Dumb question --> is there an easy-to-use kernel isprint() yet? :) Ship it! (Or, if you've enough reviewers, I'll try and make sure to approve this RTI in illumos-gate.) --- Reply to this email directly or view it on GitHub:

Re: [OpenZFS Developer] Need help getting an Illumos dev environment

On 12/17/15 10:29 , Alan Somers wrote: > On Wed, Dec 16, 2015 at 11:39 AM, Alan Somers wrote: >> On Wed, Dec 16, 2015 at 11:27 AM, Robert Mustacchi wrote: >>> On 12/16/15 9:31 , Alan Somers wrote: On Tue, Dec 15, 2015 at 10:49 AM, Dan McDonald

Re: [OpenZFS Developer] [openzfs] Possible access beyond end of string in zpool comment (#47)

@ahrens @grwilson @danmcd It's worth noting that there's a corresponding userland check that would need to be modified as well in order to support unicode: https://github.com/illumos/illumos-gate/blob/9a686fbc186e8e2a64e9a5094d44c7d6fa0ea167/usr/src/lib/libzfs/common/libzfs_pool.c#L582-L593 ---

Re: [OpenZFS Developer] [openzfs] Possible access beyond end of string in zpool comment (#47)

There is no checking that I know of, any nul-terminated byte array works On Friday, December 18, 2015, Dan McDonald wrote: > If the user properties can withstand fuzzing (imagine a delegated dataset > non-root user being able to fuzz), then steal it. Is there such

Re: [OpenZFS Developer] [openzfs] Possible access beyond end of string in zpool comment (#47)

If the user properties can withstand fuzzing (imagine a delegated dataset non-root user being able to fuzz), then steal it. Is there such checking in the user properties? --- Reply to this email directly or view it on GitHub:

[OpenZFS Developer] [openzfs] Merge illumos (#48)

You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/48 -- Commit Summary -- * 6448 Typo in byteorder man page * 3252 Need a proper flock() implementation * 6457 ucopystr can't find its way home * 6358 A faulted pool with only

Re: [OpenZFS Developer] [openzfs] 6513 partially filled holes lose birth time (#46)

@bprotopopov re: dnode_sync(), I'm not sure why we would want to assert that the birth time is filled in (and it might not be, as @pcd1193182 described). We might want to assert that the birth time is *not* filled in (and that the bp's being removed are entirely zeroed out). But I don't think

Re: [OpenZFS Developer] [openzfs] 6370 ZFS send fails to transmit some holes (#37)

> @@ -137,6 +137,11 @@ $TOUCH $mntpnt2/f18 > $RM $mntpnt/h17 > $RM $mntpnt2/h* > > +# Add empty objects to $fs to exercise dmu_traverse code > +for i in `seq 1 100`; do Using seq requires gnu-coreutils. Is that a dependency you really want to drag in? --- Reply to this email directly or

Re: [OpenZFS Developer] [openzfs] 6370 ZFS send fails to transmit some holes (#37)

> @@ -137,6 +137,11 @@ $TOUCH $mntpnt2/f18 > $RM $mntpnt/h17 > $RM $mntpnt2/h* > > +# Add empty objects to $fs to exercise dmu_traverse code > +for i in `seq 1 100`; do Some distros do for virtual methadone to Linux users. OmniOS has it in /bin and in /usr/gnu/bin. If a native illumos

[OpenZFS Developer] outstanding zfs review requests

I have 2 outstanding review requests that I could use feedback on. These have been open for quite a while so I'm probably going to RTI them this weekend. Provide mechanism to artificially limit disk performance https://github.com/openzfs/openzfs/pull/39 This patch hijacks the existing 'zinject

Re: [OpenZFS Developer] [openzfs] 6370 ZFS send fails to transmit some holes (#37)

> @@ -137,6 +137,11 @@ $TOUCH $mntpnt2/f18 > $RM $mntpnt/h17 > $RM $mntpnt2/h* > > +# Add empty objects to $fs to exercise dmu_traverse code > +for i in `seq 1 100`; do Indeed. for i in {1..100}; do --- Reply to this email directly or view it on GitHub:

Re: [OpenZFS Developer] [openzfs] 6370 ZFS send fails to transmit some holes (#37)

> @@ -137,6 +137,11 @@ $TOUCH $mntpnt2/f18 > $RM $mntpnt/h17 > $RM $mntpnt2/h* > > +# Add empty objects to $fs to exercise dmu_traverse code > +for i in `seq 1 100`; do I didn't realize that we delivered GNU utilities into /usr/bin :-1: --- Reply to this email directly or view it on GitHub:

Re: [OpenZFS Developer] [openzfs] 6370 ZFS send fails to transmit some holes (#37)

> @@ -137,6 +137,11 @@ $TOUCH $mntpnt2/f18 > $RM $mntpnt/h17 > $RM $mntpnt2/h* > > +# Add empty objects to $fs to exercise dmu_traverse code > +for i in `seq 1 100`; do The GNU coreutils are part of a standard OmniOS distro, but are in their own package. From a packaging POV, the ZFS test

Re: [OpenZFS Developer] [openzfs] 6370 ZFS send fails to transmit some holes (#37)

> @@ -137,6 +137,11 @@ $TOUCH $mntpnt2/f18 > $RM $mntpnt/h17 > $RM $mntpnt2/h* > > +# Add empty objects to $fs to exercise dmu_traverse code > +for i in `seq 1 100`; do Agreed that if the test suite depends on gnu-coreutils, that should be noted in the packaging. I think the question is: is

Re: [OpenZFS Developer] [openzfs] basic set of casesensitivity/normalization test cases for zfs-tests (#49)

Can one of the admins verify this patch? --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/49#issuecomment-165955113___ developer mailing list developer@open-zfs.org

Re: [OpenZFS Developer] [openzfs] Merge illumos (#48)

Merged #48. --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/48#event-496449077___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer

Re: [OpenZFS Developer] git workflow for github pull requests

On Fri, 18 Dec 2015 20:58:11 -0800, Matthew Ahrens wrote: On Fri, Dec 18, 2015 at 7:21 PM, Yuri Pankov > wrote: Hi, I'm a bit lost with git workflow to open pull request on github. I have illumos/illumos-gate forked for my

[OpenZFS Developer] git workflow for github pull requests

Hi, I'm a bit lost with git workflow to open pull request on github. I have illumos/illumos-gate forked for my account. When I create a branch and push my changes there, trying to create a pull request brings in all other commits not present in openzfs/openzfs. If I clone openzfs/openzfs

Re: [OpenZFS Developer] [openzfs] basic set of casesensitivity/normalization test cases for zfs-tests (#49)

@zettabot go --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/49#issuecomment-165955162___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer

[OpenZFS Developer] [openzfs] basic set of casesensitivity/normalization test cases for zfs-tests (#49)

Create a basic set of casesensitivity/normalization test cases for zfs-tests. Currently lookup and delete are checked. This covers known delete issue - https://www.illumos.org/issues/1300. You can view, comment on, or merge this pull request online at: