Re: [OpenZFS Developer] [openzfs] 6392 zdb: Introduce -V for verbatim import (#22)

2015-11-01 Thread Matthew Ahrens
@ryao It looks like you will need to update zdb_001_neg (see the test results; even without the full log I think the problem is clear). --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/22#issuecomment-152848551

Re: [OpenZFS Developer] [openzfs] 6392 zdb: Introduce -V for verbatim import (#22)

2015-11-01 Thread George Wilson
LGTM --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/22#issuecomment-152831278___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer

Re: [OpenZFS Developer] [openzfs] 6392 zdb: Introduce -V for verbatim import (#22)

2015-10-30 Thread Matthew Ahrens
@zettabot go --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/22#issuecomment-152695859___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer

Re: [OpenZFS Developer] [openzfs] 6392 zdb: Introduce -V for verbatim import (#22)

2015-10-30 Thread Matthew Ahrens
Changes look good to me. @grwilson do you want to take a look? --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/22#issuecomment-152695858___ developer mailing list developer@open-zfs.org http://lists.open-zf

Re: [OpenZFS Developer] [openzfs] 6392 zdb: Introduce -V for verbatim import (#22)

2015-10-30 Thread Matthew Ahrens
> int rewind = ZPOOL_NEVER_REWIND; > + char *spa_config_path_env; > + const char *opts = "bcdhilmMI:suCDRSAFLVXx:evp:t:U:P"; I would suggest that if you're going to move this, you also go ahead and sort it, like https://github.com/openzfs/openzfs/pull/29 proposes. --- Reply to this

[OpenZFS Developer] [openzfs] 6392 zdb: Introduce -V for verbatim import (#22)

2015-10-24 Thread Richard Yao
Reviewed by: Brian Behlendorf Reviewed by: Matthew Ahrens When given a pool name via -e, zdb would attempt an import. If it failed, then it would attempt a verbatim import. This behavior is not always desirable so a -V switch is added to zdb to control the behavior. When specified, a verbatim im