Re: [OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics

2014-05-07 Thread Steven Hartland
- Original Message - From: George Wilson george.wil...@delphix.com To: Steven Hartland kill...@multiplay.co.uk; developer@open-zfs.org Sent: Wednesday, May 07, 2014 3:07 PM Subject: Re: [OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics On 5/7/14, 4:44 AM

Re: [OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics

2014-05-07 Thread George Wilson
On 5/7/14, 10:55 AM, Steven Hartland wrote: - Original Message - From: George Wilson george.wil...@delphix.com To: Steven Hartland kill...@multiplay.co.uk; developer@open-zfs.org Sent: Wednesday, May 07, 2014 3:07 PM Subject: Re: [OpenZFS Developer] zfs zio reordering

Re: [OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics

2014-05-07 Thread Steven Hartland
- Original Message - From: George Wilson george.wil...@delphix.com There are a couple of cases where it can work but I'm going to make it such that requires you to always return back ZIO_PIPELINE_STOP. Otherwise it's makes it too easy to introduce a programming error. For example,

Re: [OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics

2014-05-07 Thread George Wilson
On 5/7/14, 11:46 AM, Steven Hartland wrote: - Original Message - From: George Wilson george.wil...@delphix.com There are a couple of cases where it can work but I'm going to make it such that requires you to always return back ZIO_PIPELINE_STOP. Otherwise it's makes it too easy to

Re: [OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics

2014-05-07 Thread Steven Hartland
- Original Message - From: George Wilson george.wil...@delphix.com On 5/7/14, 11:46 AM, Steven Hartland wrote: - Original Message - From: George Wilson george.wil...@delphix.com There are a couple of cases where it can work but I'm going to make it such that requires you

Re: [OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics

2014-05-07 Thread George Wilson
On 5/7/14, 12:50 PM, Steven Hartland wrote: - Original Message - From: George Wilson george.wil...@delphix.com On 5/7/14, 11:46 AM, Steven Hartland wrote: - Original Message - From: George Wilson george.wil...@delphix.com There are a couple of cases where it can work but

Re: [OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics

2014-05-07 Thread Steven Hartland
- Original Message - From: George Wilson george.wil...@delphix.com On 5/7/14, 11:46 AM, Steven Hartland wrote: - Original Message - From: George Wilson george.wil...@delphix.com There are a couple of cases where it can work but I'm going to make it such that requires you to

Re: [OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics

2014-05-06 Thread George Wilson
Steven, I think there is probably another way we can solve this problem but I first want to get a better understanding of the corruption. We have not integrated the TRIM support upstream and I suspect that's the source of most of the problems. Can you confirm that with TRIM disabled that most

[OpenZFS Developer] zfs zio reordering in zio_vdev_io_start causing panics

2014-04-25 Thread Steven Hartland
I've been working on adding IO priority support for TRIM back into FreeBSD after the import of the new IO scheduling from illumos. Based on avg's initial work and having got my head around the requirements of the new scheduler I came up with the attached zz-zfs-trim-priority.patch. Most of the