> On Nov. 10, 2015, 11:29 p.m., Matthew Ahrens wrote: > > Do you want to open a pull request for this to get the automated testing? > > Andriy Gapon wrote: > I am in the process of setting up a ZFS test suite environment locally. > I'll try to test this change in that environment. > I can also open a PR if that would be more convenient for the community > and you. > What would you recommend? > > Matthew Ahrens wrote: > It's easiest for me if you do all the tests and file the RTI on your own > :-) > > If you want my help with any of that, then open a pull request. > > Andriy Gapon wrote: > Okay, that's fair :-) > ``` > $ /opt/zfs-tests/bin/zfstest -a > Test: /opt/zfs-tests/tests/functional/acl/cifs/setup (run as root) > [00:15] [PASS] > Test: /opt/zfs-tests/tests/functional/acl/cifs/cifs_attr_001_pos (run as > root) [00:16] [PASS] > Test: /opt/zfs-tests/tests/functional/acl/cifs/cifs_attr_002_pos (run as > root) [00:15] [PASS] > ``` > > Matthew Ahrens wrote: > FYI, I'm still happy to see this go upstream. LMK if you need help.
Matt, thanks a lot! I was very close to submitting an RTI, but then some things changed and now I haven't booted my illumos VM in months. It would be good if the change gets committed. Unfortunately, I can not contribute much towards that at the moment. - Andriy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/257/#review870 ----------------------------------------------------------- On Nov. 20, 2015, 12:17 p.m., Andriy Gapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/257/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 12:17 p.m.) > > > Review request for OpenZFS Developer Mailing List and Matthew Ahrens. > > > Bugs: 6052 > https://www.illumos.org/issues/6052 > > > Repository: illumos-gate > > > Description > ------- > > Previously `lzc_create` had a parameter of `dmu_objset_type_t` type that > specified what kind of dataset to create. > Now `lzc_dataset_type` enumeration is used for that purpose. > At present only a filesystem type and a volume type can be specified. > `lzc_dataset_type` values are binary compatible with `dmu_objset_type_t` > values. > > > Diffs > ----- > > usr/src/uts/common/sys/fs/zfs.h 569fae20915dc58bebd875fe5f244a82fdc02a9d > usr/src/lib/libzfs_core/common/libzfs_core.h > bdd6c951ee496dc1e21a297e7a69b1342aecf79b > usr/src/lib/libzfs/common/libzfs_dataset.c > d2f613ca63241bab7b23dfd4b4b1891e0245f660 > usr/src/lib/libzfs_core/common/libzfs_core.c > 22af0f4a7a9fd8ab15cc7880233ba51274ce87d8 > > Diff: https://reviews.csiden.org/r/257/diff/ > > > Testing > ------- > > ZFS Test Suite with the following failures: > ``` > $ egrep 'FAIL|KILL' /var/tmp/test_results/20151116T101807/log > Test: > /opt/zfs-tests/tests/functional/acl/nontrivial/zfs_acl_chmod_inherit_003_pos > (run as root) [00:20] [FAIL] > Test: > /opt/zfs-tests/tests/functional/cli_root/zpool_clear/zpool_clear_001_pos (run > as root) [01:31] [FAIL] > Test: > /opt/zfs-tests/tests/functional/cli_root/zpool_expand/zpool_expand_001_pos > (run as root) [00:14] [FAIL] > Test: /opt/zfs-tests/tests/functional/cli_user/misc/zpool_add_001_neg (run as > avg) [00:01] [FAIL] > Test: /opt/zfs-tests/tests/functional/cli_user/misc/zpool_create_001_neg (run > as avg) [00:00] [FAIL] > Test: /opt/zfs-tests/tests/functional/mdb/mdb_001_pos (run as root) [00:24] > [FAIL] > Test: /opt/zfs-tests/tests/functional/refreserv/refreserv_004_pos (run as > root) [00:00] [FAIL] > Test: /opt/zfs-tests/tests/functional/rootpool/rootpool_002_neg (run as root) > [00:00] [FAIL] > Test: /opt/zfs-tests/tests/functional/rsend/rsend_008_pos (run as root) > [00:01] [FAIL] > Test: /opt/zfs-tests/tests/functional/rsend/rsend_009_pos (run as root) > [00:09] [FAIL] > Test: /opt/zfs-tests/tests/functional/slog/slog_014_pos (run as root) [00:13] > [FAIL] > Test: /opt/zfs-tests/tests/functional/zvol/zvol_swap/zvol_swap_004_pos (run > as root) [00:01] [FAIL] > ``` > Looks like known failures, at least nothing pointing at `zfs create` > > > Thanks, > > Andriy Gapon > > ------------------------------------------- openzfs-developer Archives: https://www.listbox.com/member/archive/274414/=now RSS Feed: https://www.listbox.com/member/archive/rss/274414/28015062-cce53afa Modify Your Subscription: https://www.listbox.com/member/?member_id=28015062&id_secret=28015062-f966d51c Powered by Listbox: http://www.listbox.com
