Re: [Development] Danger when excluding auto tests with pre-processor macro.

2012-11-04 Thread João Abecasis
Olivier Goffart wrote: In the paragraph Use appropriate mechanisms to exclude inapplicable tests of https://qt-project.org/wiki/Writing_Unit_Tests the policy to exclude tests depending on platforms or compiler features is to use pre-processor #ifdef. I just eddited that page to add a Warning

Re: [Development] Danger when excluding auto tests with pre-processor macro.

2012-11-04 Thread Olivier Goffart
On Sunday 04 November 2012 09:22:11 João Abecasis wrote: Olivier Goffart wrote: In the paragraph Use appropriate mechanisms to exclude inapplicable tests of https://qt-project.org/wiki/Writing_Unit_Tests the policy to exclude tests depending on platforms or compiler features is to use

Re: [Development] Danger when excluding auto tests with pre-processor macro.

2012-11-04 Thread Thiago Macieira
On domingo, 4 de novembro de 2012 10.42.39, Olivier Goffart wrote: At some point Jason McDonald was going over all the tests and fixing this, but maybe someone needs to take a second round now... I already let Jason know at that time, and he fixed most of them (commit

Re: [Development] Consistency in Qt headers (extends: 'renaming all QWindow properties that have window in them')

2012-11-04 Thread Sze Howe Koh
On Tue, Oct 30, 2012 at 7:45 PM, Sze Howe Koh szehowe@gmail.com wrote: I'll begin cleaning up the selected Qt 5.0 modules first, then move on to the others later. The renaming of QtMultimedia and QtMultimedia::MetaData has been submitted for review: