Re: [Development] Gerrit is back

2019-05-23 Thread Alessandro Portale
Please accept also my thank You's. The update definitely brings many improvements and much fresh air :) Br, Alessandro Von: Development im Auftrag von Simon Hausmann Gesendet: Donnerstag, 23. Mai 2019 09:32 An: Jukka Jokiniva; development@qt-project.org

Re: [Development] Qt XML and Qt Xml Patterns

2019-05-23 Thread Bernhard Lindner
> It's good that Bernhard has received an official statement. I agree! Thank you! > In general, I think the Qt Company could make a little more effort to > communicate such decisions, educate its user community, and attract new > potential maintainers. Actually, communication should start before

Re: [Development] QList for Qt 6

2019-05-23 Thread Mutz, Marc via Development
On 2019-05-23 10:40, Lars Knoll wrote: [...] 4. Use QVector to implement QList, if sizeof(Foo) <= sizeof(quint64) and Foo is movable. I’m intentionally not using sizeof(void *) here, as types with sizes between 4 and 8 bytes would not have stable references in cross platform code, so I do not

Re: [Development] QList for Qt 6

2019-05-23 Thread Konstantin Shegunov
On Thu, May 23, 2019 at 12:15 PM Shawn Rutledge wrote: > > On 23 May 2019, at 07:51, Konstantin Shegunov > wrote: > > Yes, exactly like, though it'd need to regrow automatically; and on > regrow it may need to normalize the order of elements (hence the > "amortized”). > > When should it regrow?

Re: [Development] QList for Qt 6

2019-05-23 Thread Lars Knoll
> On 23 May 2019, at 11:50, Olivier Goffart wrote: > > On 22.05.19 15:49, Lars Knoll wrote: > [...] >> 2. Move QStringList and QByteArrayList over to inherit from QVector (that >> should be source compatible) >> 3. Rename QStringList to QStringVector (keep QStringList as a compatibility >>

Re: [Development] QList for Qt 6

2019-05-23 Thread Olivier Goffart
On 22.05.19 15:49, Lars Knoll wrote: [...] 2. Move QStringList and QByteArrayList over to inherit from QVector (that should be source compatible) 3. Rename QStringList to QStringVector (keep QStringList as a compatibility name), same for QBAList I wouldn't do that. I'd just make using

Re: [Development] QList for Qt 6

2019-05-23 Thread Shawn Rutledge
> On 23 May 2019, at 07:51, Konstantin Shegunov wrote: > > On Thu, May 23, 2019 at 8:12 AM Mutz, Marc via Development > wrote: > On 2019-05-22 22:38, Konstantin Shegunov wrote: > > What about a rather smart (in terms of storage) circular buffer; a > > vector. Then the push, pop, enqueue and

Re: [Development] QList for Qt 6

2019-05-23 Thread Lars Knoll
On 23 May 2019, at 10:40, Lars Knoll mailto:lars.kn...@qt.io>> wrote: Hi, Been trying to implement this, and of course there are some complications :) On 22 May 2019, at 21:36, Mutz, Marc via Development mailto:development@qt-project.org>> wrote: Hi Lars, On 2019-05-22 15:49, Lars Knoll

Re: [Development] QList for Qt 6

2019-05-23 Thread Lars Knoll
Hi, Been trying to implement this, and of course there are some complications :) > On 22 May 2019, at 21:36, Mutz, Marc via Development > wrote: > > Hi Lars, > > On 2019-05-22 15:49, Lars Knoll wrote: >> Let’s conclude the topic of QList. I do see the concern about silent >> source

Re: [Development] What's the status of a moved-from object?

2019-05-23 Thread Simon Hausmann
Hi, I favor a well-formed (null) state over a partially-formed state. I agree with the suggestion of adding null pointer checks into member functions where applicable. I think a well-formed state is more likely to enable our users to have a productive time. Operating - by accident - on a

Re: [Development] Gerrit is back

2019-05-23 Thread Simon Hausmann
Hi, After a few days of usage and getting used to the new UI, I'd like to say that I'm very impressed! This upgrade went smoothly and the new functionality is a real productivity booster. I love the fact that there's now a usable mobile interface. And that I can edit commits to make small