Re: [Development] Qt 5.14 MinGW debug build doesn't add debug suffix

2020-01-14 Thread Kai Köhne
> -Original Message- > From: Development On Behalf Of > Thiago Macieira > Sent: Tuesday, January 14, 2020 4:33 PM > To: development@qt-project.org > Subject: Re: [Development] Qt 5.14 MinGW debug build doesn't add debug > suffix > > On Tuesday, 14 January 2020 00:02:01 PST Kai Köhne

Re: [Development] Qt 5.14 MinGW debug build doesn't add debug suffix

2020-01-14 Thread Thiago Macieira
On Tuesday, 14 January 2020 00:02:01 PST Kai Köhne wrote: > -debug-and-release was completely disabled in Qt 5.14.0, but will work again > in Qt 5.14.1 (though still not be the default). How will that work? Will it create debug libraries with different names compared to a pure debug build? BTW,

Re: [Development] Code Review Process

2020-01-14 Thread Thiago Macieira
On Tuesday, 14 January 2020 01:10:03 PST Dmitriy Purgin wrote: > A week ago I created a patch adding an std::chrono overload to A week might not be sufficient time for contributors to see your change, as we're all busy. I saw your change coming through, but let it go as QStateMachine is not a

Re: [Development] Are we already allowed to use C++17 in dev?

2020-01-14 Thread Thiago Macieira
On Tuesday, 14 January 2020 01:15:35 PST Olivier Goffart wrote: > I know that. > But since we are supposed to mandate C++17 in dev, what the other path[0] > does is simply to discard this test altogether and add the -std=c++17 > anyway. That patch had a CI test run without macOs, and every

Re: [Development] Code Review Process

2020-01-14 Thread Dmitriy Purgin
Hi Eddy, thanks a lot for looking into this for me. Searching for the contributors to the affected files is a smart idea indeed! Cheers Dmitriy On Tue, Jan 14, 2020 at 11:24 AM Edward Welbourne wrote: > Dmitriy Purgin (14 January 2020 10:10) wrote: > > I'm afraid I did something incorrectly

Re: [Development] Code Review Process

2020-01-14 Thread Edward Welbourne
Dmitriy Purgin (14 January 2020 10:10) wrote: > I'm afraid I did something incorrectly when submitting my first > contribution to the Qt project and I would love to get a feedback if I > did it wrong. [snip] > Is there something I've missed? Should I have created a ticket in Jira > first? Or

Re: [Development] Are we already allowed to use C++17 in dev?

2020-01-14 Thread Olivier Goffart
On 2020-01-13 19:38, Thiago Macieira wrote: On Sunday, 12 January 2020 23:18:40 PST Olivier Goffart wrote: Well it might, since this patch forces the use of C++17 everywhere, regardless of the configure test. which i believe is the problem. There's a reason we wrote the test like that. It was

[Development] Code Review Process

2020-01-14 Thread Dmitriy Purgin
Hi all, I'm afraid I did something incorrectly when submitting my first contribution to the Qt project and I would love to get a feedback if I did it wrong. A week ago I created a patch adding an std::chrono overload to QStateMachine::postDelayedEvent() and submitted it through gerrit to code

Re: [Development] Qt 5.14 MinGW debug build doesn't add debug suffix

2020-01-14 Thread Dmitriy Purgin
Hi Henry, >If you don't to wait for 5.14.1 then I've patched utils.cpp (see the bug > above), you can then rebuild windeployqt so that it works in MinGW > 5.14.0 or download the patched .exe it from here: Thanks for the patch! It's not that important for me that I update, I'm just dropping a new

Re: [Development] Qt 5.14 MinGW debug build doesn't add debug suffix

2020-01-14 Thread Dmitriy Purgin
Hi Kai, > Can you file a bug about this? I’m still hoping to fix all remaining issues for 5.14.1 … I've commented an existing https://bugreports.qt.io/browse/QTBUG-80792 and attached my example to reproduce the d-prefix issue. My attached file appears somehow in the Ticket description though,

Re: [Development] Qt 5.14 MinGW debug build doesn't add debug suffix

2020-01-14 Thread Henry Skoglund
On 2020-01-14 09:02, Kai Köhne wrote: From: Development On Behalf Of Dmitriy Purgin Sent: Tuesday, January 14, 2020 8:46 AM To: Thiago Macieira Cc: Qt development mailing list Subject: Re: [Development] Qt 5.14 MinGW debug build doesn't add debug suffix I've just discovered another

Re: [Development] Qt 5.14 MinGW debug build doesn't add debug suffix

2020-01-14 Thread Kai Köhne
> From: Development On Behalf Of Dmitriy > Purgin > Sent: Tuesday, January 14, 2020 8:46 AM > To: Thiago Macieira > Cc: Qt development mailing list > Subject: Re: [Development] Qt 5.14 MinGW debug build doesn't add debug suffix > > I've just discovered another side-effect of this change. I've