Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Thiago Macieira
On Friday, 18 September 2020 14:51:17 PDT André Pönitz wrote: > > Because we should push our users to adopt new compiler versions. > > What kind of political agenda is that? > > Pushing for newer anything just means we are leaving people behind. > > This might be justified in some cases if

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread André Pönitz
On Fri, Sep 18, 2020 at 11:56:38AM -0700, Thiago Macieira wrote: > On Friday, 18 September 2020 09:38:12 PDT Ville Voutilainen wrote: > > > We should use one of the types from [1]. Yes, it's C++20; we can > > > make our internal API return an integer that is convertible to those types > > > in the

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Bernhard Lindner
> What is it you need? Just some total ordering of variants? The method you > mentioned in > QAbstractItemModel also only does ordering for some types, otherwise falling > back to > strings. I am using QVariant comparison (==, >, <) only for equal types. But not in models. I use it for other

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Bernhard Lindner
> > Has anything changed for Qt6 (especially regarding comparison of equal > > and/or convertible types)? Is the complete deprecation still the latest > > decision? > > Yes, it's changed; no, it's not deprecation. > > What's been removed is the conversion. Aside from the numeric types, >

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Thiago Macieira
On Friday, 18 September 2020 09:38:12 PDT Ville Voutilainen wrote: > > We should use one of the types from [1]. Yes, it's C++20; we can > > make our internal API return an integer that is convertible to those > > types in the front-end API, under #if __has_include(). > > > > [1]

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Ville Voutilainen
On Fri, 18 Sep 2020 at 18:13, Thiago Macieira wrote: > > On Friday, 18 September 2020 06:48:50 PDT Lars Knoll wrote: > > std::optional QVariant::compare(const QVariant ); > > > > Would that be good enough? > > Why the optional? > > We should use one of the types from [1]. Yes, it's C++20; we can

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Thiago Macieira
On Friday, 18 September 2020 01:44:36 PDT Giuseppe D'Angelo via Development wrote: > Il 18/09/20 02:54, Thiago Macieira ha scritto: > > What's been removed is the conversion. Aside from the numeric types, > > comparing two variants of different types will always result in false. If > > you want

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Thiago Macieira
On Friday, 18 September 2020 06:48:50 PDT Lars Knoll wrote: > std::optional QVariant::compare(const QVariant ); > > Would that be good enough? Why the optional? We should use one of the types from [1]. Yes, it's C++20; we can make our internal API return an integer that is convertible to those

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Thiago Macieira
On Friday, 18 September 2020 01:59:50 PDT Albert Astals Cid via Development wrote: > We have a few generic item models and proxy models that implement sorting, > they did so by using operator< of QVariant. > > I want a way to be able to do the same in Qt6 in a way that ideally doesn't > involve

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Thiago Macieira
On Friday, 18 September 2020 01:50:50 PDT Konstantin Tokarev wrote: > In Qt4 times comparison operators for QVariant were missing and from my > experience main limitation was that it wasn't possible to have QVariant as > a key in QMap without defining one manually. Correct. That's because you

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Lars Knoll
On 18 Sep 2020, at 14:19, Albert Astals Cid mailto:albert.astals@kdab.com>> wrote: [snip] I’m not really in favour of adding an operator<() to QVariant again, as it would need to provide some decent ordering, and that would probably cause conflicts with operator=() that does somewhat loose

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Albert Astals Cid via Development
El divendres, 18 de setembre de 2020, a les 13:25:45 CEST, Lars Knoll va escriure: > > On 18 Sep 2020, at 11:23, Albert Astals Cid via Development > > wrote: > > El divendres, 18 de setembre de 2020, a les 11:00:23 CEST, André Somers va > > escriure: > > > >> On 18-09-2020 09:12, Albert

Re: [Development] Proposing Alex Trotsenko as approver

2020-09-18 Thread Lars Knoll
Another +1. Cheers, Lars > On 18 Sep 2020, at 10:52, Joerg Bornemann wrote: > > On 9/17/20 11:37 AM, André Hartmann wrote: > >> I like to propose Alex Trotsenko as approver. > > +1 from me as well > ___ > Development mailing list >

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Lars Knoll
> On 18 Sep 2020, at 11:23, Albert Astals Cid via Development > wrote: > > El divendres, 18 de setembre de 2020, a les 11:00:23 CEST, André Somers va > escriure: >> On 18-09-2020 09:12, Albert Astals Cid via Development wrote: >>> El divendres, 18 de setembre de 2020, a les 2:54:53 CEST,

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Albert Astals Cid via Development
El divendres, 18 de setembre de 2020, a les 11:00:23 CEST, André Somers va escriure: > On 18-09-2020 09:12, Albert Astals Cid via Development wrote: > > El divendres, 18 de setembre de 2020, a les 2:54:53 CEST, Thiago Macieira > > va> > > escriure: > >> On Thursday, 17 September 2020 16:15:47

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Allan Sandfeld Jensen
On Freitag, 18. September 2020 10:28:06 CEST Albert Astals Cid via Development wrote: > El divendres, 18 de setembre de 2020, a les 10:22:16 CEST, Lars Knoll va escriure: > > Sorting and equality are two different things. QVariant has never > > supported > > a lessThan operator. > > Yes, it has

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Giuseppe D'Angelo via Development
Il 18/09/20 10:22, Lars Knoll ha scritto: Sorting and equality are two different things. QVariant has never supported a lessThan operator. That's not accurate. Q5Variant has operator<, and Q5MetaType allowed to register comparators (op== and op<) for a user type. I don't know how much

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread André Somers
On 18-09-2020 09:12, Albert Astals Cid via Development wrote: El divendres, 18 de setembre de 2020, a les 2:54:53 CEST, Thiago Macieira va escriure: On Thursday, 17 September 2020 16:15:47 PDT Bernhard Lindner wrote: Hi! There was a discussion about the decision to deprecate (remove?)

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Albert Astals Cid via Development
El divendres, 18 de setembre de 2020, a les 10:37:36 CEST, Lars Knoll va escriure: > > On 18 Sep 2020, at 10:28, Albert Astals Cid > > wrote: > > El divendres, 18 de setembre de 2020, a les 10:22:16 CEST, Lars Knoll va > > escriure: > > >> Sorting and equality are two different things.

Re: [Development] Proposing Alex Trotsenko as approver

2020-09-18 Thread Joerg Bornemann
On 9/17/20 11:37 AM, André Hartmann wrote: I like to propose Alex Trotsenko as approver. +1 from me as well ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Konstantin Tokarev
18.09.2020, 11:40, "Lars Knoll" : >>  On 18 Sep 2020, at 10:28, Albert Astals Cid >> wrote: >> >>  El divendres, 18 de setembre de 2020, a les 10:22:16 CEST, Lars Knoll va >> escriure: >>>  Sorting and equality are two different things. QVariant has never supported >>>  a lessThan operator.

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Giuseppe D'Angelo via Development
Il 18/09/20 02:54, Thiago Macieira ha scritto: What's been removed is the conversion. Aside from the numeric types, comparing two variants of different types will always result in false. If you want to compare across types, convert one to the other's type or to a common third type. You know what

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Lars Knoll
> On 18 Sep 2020, at 10:28, Albert Astals Cid > wrote: > > El divendres, 18 de setembre de 2020, a les 10:22:16 CEST, Lars Knoll va > escriure: >> Sorting and equality are two different things. QVariant has never supported >> a lessThan operator. > > Yes, it has > >

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Albert Astals Cid via Development
El divendres, 18 de setembre de 2020, a les 10:22:16 CEST, Lars Knoll va escriure: > Sorting and equality are two different things. QVariant has never supported > a lessThan operator. Yes, it has https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qvariant.h?h=5.15#n467 Cheers,

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Lars Knoll
On 18 Sep 2020, at 09:12, Albert Astals Cid via Development mailto:development@qt-project.org>> wrote: El divendres, 18 de setembre de 2020, a les 2:54:53 CEST, Thiago Macieira va escriure: On Thursday, 17 September 2020 16:15:47 PDT Bernhard Lindner wrote: Hi! There was a discussion about

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Allan Sandfeld Jensen
On Freitag, 18. September 2020 02:54:53 CEST Thiago Macieira wrote: > On Thursday, 17 September 2020 16:15:47 PDT Bernhard Lindner wrote: > > Hi! > > > > There was a discussion about the decision to deprecate (remove?) QVariant > > comparison (<,>) in Qt6 completely. > > > > Has anything changed

[Development] 정건일 (Keonil Jeong) is out of office.

2020-09-18 Thread 정건일
Period : 2020/09/18 13:30 ~ 2020/09/18 23:55 [Korea Standard Time] 부재중입니다. 이수철 선임 (soocheol@lge.com) 님께 연락 부탁드립니다. Please contact Soocheol Lee (soocheol@lge.com) ___ Development mailing list Development@qt-project.org

Re: [Development] QVariant comparison in Qt6

2020-09-18 Thread Albert Astals Cid via Development
El divendres, 18 de setembre de 2020, a les 2:54:53 CEST, Thiago Macieira va escriure: > On Thursday, 17 September 2020 16:15:47 PDT Bernhard Lindner wrote: > > Hi! > > > > There was a discussion about the decision to deprecate (remove?) QVariant > > comparison (<,>) in Qt6 completely. > > > >