Re: [Development] QVariant comparison in Qt6

2020-09-22 Thread Thiago Macieira
On Tuesday, 22 September 2020 09:24:44 PDT Andrei Golubev wrote: > Also, you can use std::optional internally in that class as an > underlying storage for the result or/and have a conversion operator to > std::optional if this is a much desired return type, right? Don't use optional internally

Re: [Development] QVariant comparison in Qt6

2020-09-22 Thread Andrei Golubev
Tend to agree with Ville, it would be easier to adopt std::partial_ordering with a proper class in place. Also, you can use std::optional internally in that class as an underlying storage for the result or/and have a conversion operator to std::optional if this is a much desired return type,

Re: [Development] QVariant comparison in Qt6

2020-09-22 Thread Ville Voutilainen
On Tue, 22 Sep 2020 at 17:20, Thiago Macieira wrote: > And especially if there's no impact to how the user uses the API. > > > 1) > > std::optional compare(); > > > > 2) > > enum class Ordering { Less = -1, Equal = 0, Greater = 1, Unordered = 0xff > > }; > > Ordering compare(); > > > > 3) > >

Re: [Development] QVariant comparison in Qt6

2020-09-22 Thread Thiago Macieira
On Tuesday, 22 September 2020 06:55:35 PDT Lars Knoll wrote: > > For internal APIs, please return just a plain int. > > Those compare() methods are meant to be public. The public API does not have to be non-inline library call. > Really? Are we now making API decisions on how well a compiler

Re: [Development] QVariant comparison in Qt6

2020-09-22 Thread Lars Knoll
> On 22 Sep 2020, at 08:54, Thiago Macieira wrote: > > On Monday, 21 September 2020 22:55:16 PDT Lars Knoll wrote: >> I do not want to simply return an int, as the risk that people ignore the >> Unordered state it too big with that. So the other choice would be to add >> an enum in the Qt

Re: [Development] Status of QWebEngine

2020-09-22 Thread Allan Sandfeld Jensen
On Dienstag, 22. September 2020 11:35:07 CEST Benjamin TERRIER wrote: > On Mon, 21 Sep 2020 at 14:10, Allan Sandfeld Jensen > > wrote: > > Use the SHA1s in dependencies.yaml > > That's not very practical to do by hand, but it worked. > Yeah I know. Should be simpler once Qt6 stabilizes more.

Re: [Development] Status of QWebEngine

2020-09-22 Thread Benjamin TERRIER
On Mon, 21 Sep 2020 at 14:10, Allan Sandfeld Jensen wrote: > > Use the SHA1s in dependencies.yaml > > That's not very practical to do by hand, but it worked. Thanks ___ Development mailing list Development@qt-project.org

Re: [Development] How to debug segfaulting test in Coin

2020-09-22 Thread Toni Saario
What comes for external users debugging the segfaults in Coin currently there is only the logs on testresults server. Only related ticket has been https://bugreports.qt.io/browse/QTQAINFRA-990 which resulted in the CORE_FILES_PATH upload process. Create a ticket for Coin project

Re: [Development] How to debug segfaulting test in Coin

2020-09-22 Thread Toni Saario
The CORE_FILES_PATH environment variable describes a path to a directory which will contain the core files in case of a segfault. These are then uploaded to Coin storage at the end of the job. As far as enabling that goes via coin scheduler, setting the CORE_FILES_PATH is possible via the

Re: [Development] QVariant comparison in Qt6

2020-09-22 Thread Thiago Macieira
On Monday, 21 September 2020 22:55:16 PDT Lars Knoll wrote: > I do not want to simply return an int, as the risk that people ignore the > Unordered state it too big with that. So the other choice would be to add > an enum in the Qt namespace (as I need this for QMetaType as well, which >