Re: [Development] Proposals for changes to "Precheck" feature

2022-03-25 Thread Thiago Macieira
On Friday, 25 March 2022 13:42:39 -03 Volker Hilsheimer wrote: > * always rebase the commit before prechecking > > Right now, precheck is a checkout, which means that the precheck is done on > top of the revision that it was pushed from. Since that is not the revision > that it will ultimately int

Re: [Development] Updating x86 SIMD support in Qt

2022-03-25 Thread Lorn Potter
On 19/1/2022 1:01 PM, Thiago Macieira wrote: For Qt 6.4, I'd like to propose we change the way we detect and enable SIMD support. TL;DR: [snip] On a side track. Not knowing too much regarding simd, what would be the best benchmarks to get a comparison of Qt WebAssembly simd support vs. no

Re: [Development] Proposals for changes to "Precheck" feature

2022-03-25 Thread Giuseppe D'Angelo via Development
On 25/03/2022 17:54, Alexandru Croitor wrote: I would prefer a comment-based precheck system instead, and keep the existing precheck as-is. https://bugreports.qt.io/browse/QTQAINFRA-4419 See also the other ideas in that bug report, most notably also allowing to somehow select a subset of pla

Re: [Development] Proposals for changes to "Precheck" feature

2022-03-25 Thread Alexandru Croitor
Hi, > On 25. Mar 2022, at 17:42, Volker Hilsheimer wrote: > > * always rebase the commit before prechecking I have controversial feelings about this one. Sometimes i want it rebased on latest HEAD of the branch in question, sometimes I want the exact parent I chose. You can get merge conflic

[Development] Proposals for changes to "Precheck" feature

2022-03-25 Thread Volker Hilsheimer
Hey ho, We’ve had the convenient “precheck’” button in gerrit for a while now, allowing approvers to kick off a CI-dry-run to check if things would pass an integration before asking for reviews, and without the risk of tearing down a bunch of co-staged changes in case of failure. Two things th