Re: [Development] Using '#pragma once' instead of include guards?

2024-03-05 Thread Marc Mutz via Development
Hi, TL;DR: I'd maintain that #pragma once to mark non-installed headers is a) the least-intrusive change of all that's been proposed, b) targeting the non-public headers only (so don't disturb e.g. the API reviews (or customer's validation...)), which c) are the minority of Qt headers (minimiz

Re: [Development] Using '#pragma once' instead of include guards?

2024-03-05 Thread apoenitz
On Tue, Mar 05, 2024 at 10:43:50AM +, Volker Hilsheimer via Development wrote: > > On 4 Mar 2024, at 15:56, Kai Köhne via Development > > wrote: > > > Hi Marc, > > I've nothing against using '#pragma once' for private/internal headers. > > But you said you mainly want to have this to di

Re: [Development] Using '#pragma once' instead of include guards?

2024-03-05 Thread Alexandru Croitor via Development
> On 5. Mar 2024, at 11:43, Volker Hilsheimer via Development > wrote: > >> On 4 Mar 2024, at 15:56, Kai Köhne via Development >> wrote: >> >> Hi Marc, >> >> I've nothing against using '#pragma once' for private/internal headers. >> >> But you said you mainly want to have this to differen

Re: [Development] Using '#pragma once' instead of include guards?

2024-03-05 Thread Volker Hilsheimer via Development
On 4 Mar 2024, at 15:56, Kai Köhne via Development wrote: Hi Marc, I've nothing against using '#pragma once' for private/internal headers. But you said you mainly want to have this to differentiate between different types of headers. If this is the motivation, I think we can make this differ

Re: [Development] Extending qt_attribution.json files to mark provisioned components

2024-03-05 Thread Volker Hilsheimer via Development
On 4 Mar 2024, at 14:42, Kai Köhne via Development wrote: Hi, I suggest extending our qt_attribution.json format to explicitly mark third-party components not part of the Qt sources, like https://doc.qt.io/qt-6/qtmultimedia-attribution-ffmpeg.html. QUIP-7 change: https://codereview.qt-pr