Re: [Development] A better headersclean test

2015-01-08 Thread Curtis Mitch
.org > Subject: Re: [Development] A better headersclean test > > On Tuesday 06 January 2015 10:14:35 Curtis Mitch wrote: > > > For development I usually do debug builds, so it would be nice to > avoid > > > the extra build time (and extra nagging during the build) most

Re: [Development] A better headersclean test

2015-01-07 Thread Rutledge Shawn
On Jan 6, 2015, at 16:52, Thiago Macieira wrote: > On Tuesday 06 January 2015 10:14:35 Curtis Mitch wrote: >>> For development I usually do debug builds, so it would be nice to avoid >>> the extra build time (and extra nagging during the build) most of the >>> time, and just let CI enforce it, a

Re: [Development] A better headersclean test

2015-01-06 Thread Thiago Macieira
On Tuesday 06 January 2015 10:14:35 Curtis Mitch wrote: > > For development I usually do debug builds, so it would be nice to avoid > > the extra build time (and extra nagging during the build) most of the > > time, and just let CI enforce it, as long as that is reliable. > +1 So I guess both of y

Re: [Development] A better headersclean test

2015-01-06 Thread Curtis Mitch
> For development I usually do debug builds, so it would be nice to avoid the > extra build time (and extra nagging during the build) most of the time, and > just let CI enforce it, as long as that is reliable. +1 ___ Development mailing list Developm

Re: [Development] A better headersclean test

2015-01-05 Thread Rutledge Shawn
On 6 Jan 2015, at 01:06, Thiago Macieira wrote: > On Monday 05 January 2015 23:15:24 Giuseppe D'Angelo wrote: >> Il 02/01/2015 17:55, Thiago Macieira ha scritto: >>> I'm giving it another week due to the Christmas/New Years break, after >>> that I will consider it ML consensus to enable by defau

Re: [Development] A better headersclean test

2015-01-05 Thread Thiago Macieira
On Monday 05 January 2015 23:15:24 Giuseppe D'Angelo wrote: > Il 02/01/2015 17:55, Thiago Macieira ha scritto: > > I'm giving it another week due to the Christmas/New Years break, after > > that I will consider it ML consensus to enable by default. > > Can we make it opt-in instead of opt-out? I d

Re: [Development] A better headersclean test

2015-01-05 Thread Lisandro Damián Nicanor Pérez Meyer
On Monday 05 January 2015 14:27:20 Thiago Macieira wrote: > On Monday 05 January 2015 15:27:24 Lisandro Damián Nicanor Pérez Meyer wrote: > > ACKing that I do not do developer-build for Debian (because "we don't need > > it" [0]) and that my opinion should not have much weight if any, I do > > al

Re: [Development] A better headersclean test

2015-01-05 Thread Thiago Macieira
On Monday 05 January 2015 15:27:24 Lisandro Damián Nicanor Pérez Meyer wrote: > ACKing that I do not do developer-build for Debian (because "we don't need > it" [0]) and that my opinion should not have much weight if any, I do also > think Thiago's idea is a nice one. I do also consider having hea

Re: [Development] A better headersclean test

2015-01-05 Thread Giuseppe D'Angelo
Il 02/01/2015 17:55, Thiago Macieira ha scritto: I'm giving it another week due to the Christmas/New Years break, after that I will consider it ML consensus to enable by default. Can we make it opt-in instead of opt-out? I don't see why all Qt developers should pay by default for the extra com

Re: [Development] A better headersclean test

2015-01-05 Thread Lisandro Damián Nicanor Pérez Meyer
On Wednesday 17 December 2014 19:57:47 Thiago Macieira wrote: > Hello all > > I've previously mentioned this, but I can't find the link in the archives. > > I've implemented a better headersclean check that can't be forgotten. You > can find it at https://codereview.qt-project.org/45533 > > This

Re: [Development] A better headersclean test

2015-01-02 Thread Thiago Macieira
On Wednesday 17 December 2014 19:57:47 Thiago Macieira wrote: > The reason I am asking for this is because having our own headers be clean > of > warnings is a feature. And just like our binary compatibility guarantees, it > should be tested and enforced in the CI, which in turn requires everyone t

Re: [Development] A better headersclean test

2014-12-18 Thread Thiago Macieira
On Thursday 18 December 2014 13:53:38 Giuseppe D'Angelo wrote: > Il 18/12/2014 04:57, Thiago Macieira ha scritto: > > Drawback: > > It increases the build time considerably (25 to 33%) due to having a lot > > more files to compile, and always without PCH. > > Are those files part of the tests? I.e

Re: [Development] A better headersclean test

2014-12-18 Thread Giuseppe D'Angelo
Il 18/12/2014 04:57, Thiago Macieira ha scritto: Drawback: It increases the build time considerably (25 to 33%) due to having a lot more files to compile, and always without PCH. Are those files part of the tests? I.e. -developer-build -nomake tests should not have any performance drawback?

Re: [Development] A better headersclean test

2014-12-18 Thread Olivier Goffart
On Wednesday 17 December 2014 19:57:47 Thiago Macieira wrote: > Hello all > > I've previously mentioned this, but I can't find the link in the archives. > > I've implemented a better headersclean check that can't be forgotten. You > can find it at https://codereview.qt-project.org/45533 > > This

[Development] A better headersclean test

2014-12-17 Thread Thiago Macieira
Hello all I've previously mentioned this, but I can't find the link in the archives. I've implemented a better headersclean check that can't be forgotten. You can find it at https://codereview.qt-project.org/45533 This email is to ask for when it should be enabled: Lars and Ossi in the mail di