Re: [Development] Adoption of virtual_hook()

2012-04-11 Thread jan-arve.saether
april 2012 15:42 To: development@qt-project.org Emne: Re: [Development] Adoption of virtual_hook() Hi, On Apr 11, 2012, at 15:09 , ext Thiago Macieira wrote: > For non-QObject classes which *already* have virtual tables, we should > consider it. Fortunately, those classes are minority in Qt,

Re: [Development] Adoption of virtual_hook()

2012-04-11 Thread harald.fernengel
Hi, On Apr 11, 2012, at 15:09 , ext Thiago Macieira wrote: > For non-QObject classes which *already* have virtual tables, we should > consider it. Fortunately, those classes are minority in Qt, we have very few > of them. grep'ing through the source code, we have several virtual_hooks in Qt:

Re: [Development] Adoption of virtual_hook()

2012-04-11 Thread Thiago Macieira
On quarta-feira, 11 de abril de 2012 12.12.23, lars.kn...@nokia.com wrote: > I was never a really big fan of adding lots of virtual_hook()'s to > classes. vtable entries do come at a cost and in many cases it's not > really required. I am certainly against blindly adding them to all our > classes.

Re: [Development] Adoption of virtual_hook()

2012-04-11 Thread lars.knoll
I was never a really big fan of adding lots of virtual_hook()'s to classes. vtable entries do come at a cost and in many cases it's not really required. I am certainly against blindly adding them to all our classes. Cheers, Lars On 4/11/12 8:19 AM, "ext jan-arve.saet...@nokia.com" wrote: >The "

Re: [Development] Adoption of virtual_hook()

2012-04-11 Thread jan-arve.saether
Hausmann Simon (Nokia-MP/Oslo) wrote on 2012-04-11: > I would say that qt_metacall is our equivalent. We used that with > slots in QStyle for example to achieve the same effect with slightly > more convenience :) > > Simon > Ok, that will cover most of our classes, but we still have polymorphic

Re: [Development] Adoption of virtual_hook()

2012-04-11 Thread simon.hausmann
I would say that qt_metacall is our equivalent. We used that with slots in QStyle for example to achieve the same effect with slightly more convenience :) Simon -- Sendt fra min Nokia N911.04.12 08:19 skrev Saether Jan-Arve (Nokia-MP/Oslo): The "Little Manual of API Design" [1] recommends adding

[Development] Adoption of virtual_hook()

2012-04-10 Thread jan-arve.saether
The "Little Manual of API Design" [1] recommends adding a virtual_hook() that can be used later on if we need to extend the class without BIC. Lots of classes does not have this hook. Isn't this something we should fix before Qt5 is out? Jan-Arve [1]: Little Manual of API Design, http://chaos