[Development] Asking for a FF exception for ICU based QStringConverter

2022-06-08 Thread Fabian Kosmale
Hi, unfortunately, we did not manage to get a QStringConverter backend based on ICU into Qt in time for FF (https://codereview.qt-project.org/c/qt/qtbase/+/393373). This is a feature strongly requested by KDE as an enabler for their KDE Frameworks 6 port [1] and from various users in APAC, where

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-08 Thread Lars Knoll
Given that the change doesn’t interfere with existing functionality, this is ok. But please try to finish and get the change merged as soon as possible. Cheers, Lars > On 8 Jun 2022, at 16:17, Fabian Kosmale wrote: > > Hi, > > unfortunately, we did not manage to get a QStringConverter backend

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-08 Thread Thiago Macieira
On Wednesday, 8 June 2022 07:17:29 PDT Fabian Kosmale wrote: > - There are concerns that mixing Qt versions might lead to an unbounded > memory leak with the current implementation. I don't think that's actually > the case (but if it is, then we need a different enough approach that this > most lik

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-08 Thread Giuseppe D'Angelo via Development
Hi, On 08/06/2022 18:40, Thiago Macieira wrote: On Wednesday, 8 June 2022 07:17:29 PDT Fabian Kosmale wrote: - There are concerns that mixing Qt versions might lead to an unbounded memory leak with the current implementation. I don't think that's actually the case (but if it is, then we need a

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-08 Thread Thiago Macieira
On Wednesday, 8 June 2022 10:10:20 PDT Giuseppe D'Angelo via Development wrote: > > To be clear for everyone: this can happen (depending on where we introduce > > the new API) if some code is using QStringConverter with codec names that > > it currently doesn't support. This is likely to be very l

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Giuseppe D'Angelo via Development
Il 09/06/22 01:48, Thiago Macieira ha scritto: d) Because if this, code using QStringConverter with non-builtin encodings will leak resources unless it's recompiled for 6.4. No source changes are necessary. I am saying that (d) is an acceptable situation because of (a) and (b), and in spite of

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Fabian Kosmale
that is for the discussion. Regards, Fabian Von: Development im Auftrag von Giuseppe D'Angelo via Development Gesendet: Donnerstag, 9. Juni 2022 11:36 An: development@qt-project.org Betreff: Re: [Development] Asking for a FF exception for ICU based QStrin

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Giuseppe D'Angelo via Development
Hi, On 09/06/2022 11:57, Fabian Kosmale wrote: QSettings doesn't have a way to change the codec at all as far as I can tell, and is UTF-8 only, so I'm not sure how relevant that is for the discussion. Just replying to this point: it's another API that used to accept an encoding in Qt 5 (setI

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Volker Krause
On Thursday, 9 June 2022 11:36:21 CEST Giuseppe D'Angelo via Development wrote: > Il 09/06/22 01:48, Thiago Macieira ha scritto: > > d) Because if this, code using QStringConverter with non-builtin encodings > > will leak resources unless it's recompiled for 6.4. No source changes are > > necessar

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Alexander Akulich
Hi everyone, On Wed, Jun 8, 2022 at 5:18 PM Fabian Kosmale wrote: > > What remains to be done: > - There are concerns that mixing Qt versions might lead to an unbounded > memory leak with the current implementation. I can't find any precedent but if we *really* want then probably we can get the

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Lars Knoll
> On 9 Jun 2022, at 19:16, Alexander Akulich wrote: > > Hi everyone, > > On Wed, Jun 8, 2022 at 5:18 PM Fabian Kosmale wrote: >> >> What remains to be done: >> - There are concerns that mixing Qt versions might lead to an unbounded >> memory leak with the current implementation. > > I can

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Thiago Macieira
On Thursday, 9 June 2022 10:16:19 PDT Alexander Akulich wrote: > Hi everyone, > > On Wed, Jun 8, 2022 at 5:18 PM Fabian Kosmale wrote: > > What remains to be done: > > - There are concerns that mixing Qt versions might lead to an unbounded > > memory leak with the current implementation. > I can'

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Alexander Akulich
On Thu, Jun 9, 2022 at 10:14 PM Thiago Macieira wrote: > > Doesn't work for libraries. > Can you explain please? I see this correspond to 5.0.0 until QCoreApplication constructor called but I thought it would be 'better than a leak'. QCoreApplicationPrivate::app_compile_version is a part of QtCore

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Thiago Macieira
On Thursday, 9 June 2022 12:36:25 PDT Alexander Akulich wrote: > On Thu, Jun 9, 2022 at 10:14 PM Thiago Macieira > > wrote: > > Doesn't work for libraries. > > Can you explain please? Libraries don't call QCoreApplication's constructor. The application may have been recompiled and thus will in