Hi all,
I'm afraid I did something incorrectly when submitting my first
contribution to the Qt project and I would love to get a feedback if I did
it wrong.
A week ago I created a patch adding an std::chrono overload to
QStateMachine::postDelayedEvent() and submitted it through gerrit to code
rev
Dmitriy Purgin (14 January 2020 10:10) wrote:
> I'm afraid I did something incorrectly when submitting my first
> contribution to the Qt project and I would love to get a feedback if I
> did it wrong.
[snip]
> Is there something I've missed? Should I have created a ticket in Jira
> first? Or should
Hi Eddy,
thanks a lot for looking into this for me. Searching for the contributors
to the affected files is a smart idea indeed!
Cheers
Dmitriy
On Tue, Jan 14, 2020 at 11:24 AM Edward Welbourne
wrote:
> Dmitriy Purgin (14 January 2020 10:10) wrote:
> > I'm afraid I did something incorrectly wh
On Tuesday, 14 January 2020 01:10:03 PST Dmitriy Purgin wrote:
> A week ago I created a patch adding an std::chrono overload to
A week might not be sufficient time for contributors to see your change, as
we're all busy. I saw your change coming through, but let it go as
QStateMachine is not a cl
