Re: [Development] Danger when excluding auto tests with pre-processor macro.

2013-01-31 Thread Olivier Goffart
On Sunday 04 November 2012 12:26:12 Thiago Macieira wrote: On domingo, 4 de novembro de 2012 10.42.39, Olivier Goffart wrote: At some point Jason McDonald was going over all the tests and fixing this, but maybe someone needs to take a second round now... I already let Jason know at

Re: [Development] Danger when excluding auto tests with pre-processor macro.

2013-01-31 Thread Sergio Ahumada
On 01/31/2013 02:18 PM, Olivier Goffart wrote: On Sunday 04 November 2012 12:26:12 Thiago Macieira wrote: On domingo, 4 de novembro de 2012 10.42.39, Olivier Goffart wrote: At some point Jason McDonald was going over all the tests and fixing this, but maybe someone needs to take a second round

Re: [Development] Danger when excluding auto tests with pre-processor macro.

2013-01-31 Thread Olivier Goffart
On Thursday 31 January 2013 20:50:50 Sergio Ahumada wrote: https://bugreports.qt-project.org/browse/QTBUG-29431 Great :-) is this documented somewhere so we don't do this again ? I had modified https://qt-project.org/wiki/Writing_Unit_Tests before I sent the original mail. -- Olivier

Re: [Development] Danger when excluding auto tests with pre-processor macro.

2012-11-04 Thread João Abecasis
Olivier Goffart wrote: In the paragraph Use appropriate mechanisms to exclude inapplicable tests of https://qt-project.org/wiki/Writing_Unit_Tests the policy to exclude tests depending on platforms or compiler features is to use pre-processor #ifdef. I just eddited that page to add a Warning

Re: [Development] Danger when excluding auto tests with pre-processor macro.

2012-11-04 Thread Olivier Goffart
On Sunday 04 November 2012 09:22:11 João Abecasis wrote: Olivier Goffart wrote: In the paragraph Use appropriate mechanisms to exclude inapplicable tests of https://qt-project.org/wiki/Writing_Unit_Tests the policy to exclude tests depending on platforms or compiler features is to use

Re: [Development] Danger when excluding auto tests with pre-processor macro.

2012-11-04 Thread Thiago Macieira
On domingo, 4 de novembro de 2012 10.42.39, Olivier Goffart wrote: At some point Jason McDonald was going over all the tests and fixing this, but maybe someone needs to take a second round now... I already let Jason know at that time, and he fixed most of them (commit

[Development] Danger when excluding auto tests with pre-processor macro.

2012-11-03 Thread Olivier Goffart
Hi, In the paragraph Use appropriate mechanisms to exclude inapplicable tests of https://qt-project.org/wiki/Writing_Unit_Tests the policy to exclude tests depending on platforms or compiler features is to use pre-processor #ifdef. I just eddited that page to add a Warning there. the MOC does