Re: [Development] Move assignment without move constructors

2016-05-25 Thread Marc Mutz
On Monday 23 May 2016 22:45:28 Thiago Macieira wrote: > Em segunda-feira, 23 de maio de 2016, às 20:40:36 PDT, Giuseppe D'Angelo > > escreveu: > > Any takers for the task? > > I've already added it for QDateTime: > https://codereview.qt-project.org/159085 > > It's part of the short date

Re: [Development] Move assignment without move constructors

2016-05-23 Thread Thiago Macieira
Em segunda-feira, 23 de maio de 2016, às 20:40:36 PDT, Giuseppe D'Angelo escreveu: > Any takers for the task? I've already added it for QDateTime: https://codereview.qt-project.org/159085 It's part of the short date time work. -- Thiago Macieira - thiago.macieira (AT) intel.com

Re: [Development] Move assignment without move constructors

2016-05-23 Thread Giuseppe D'Angelo
Il 23/05/2016 19:50, Konstantin Tokarev ha scritto: 23.05.2016, 19:25, "Giuseppe D'Angelo" : Il 23/05/2016 18:11, Konstantin Tokarev ha scritto: Hello, I've stumbled upon QPixmap having operator=(QPixmap&&) but missing QPixmap(QPixmap&&), however it seems

Re: [Development] Move assignment without move constructors

2016-05-23 Thread Allan Sandfeld Jensen
On Monday 23 May 2016, Konstantin Tokarev wrote: > 23.05.2016, 19:25, "Giuseppe D'Angelo" : > > Il 23/05/2016 18:11, Konstantin Tokarev ha scritto: > >> Hello, > > > >> I've stumbled upon QPixmap having operator=(QPixmap&&) but missing QPixmap(QPixmap&&), however it

Re: [Development] Move assignment without move constructors

2016-05-23 Thread Konstantin Tokarev
23.05.2016, 19:25, "Giuseppe D'Angelo" : > Il 23/05/2016 18:11, Konstantin Tokarev ha scritto: >>  Hello, >> >>  I've stumbled upon QPixmap having operator=(QPixmap&&) but missing >> QPixmap(QPixmap&&), however it seems like there are a lot of Qt classes in >> the

Re: [Development] Move assignment without move constructors

2016-05-23 Thread Thiago Macieira
On segunda-feira, 23 de maio de 2016 18:25:14 PDT Giuseppe D'Angelo wrote: > > Is there any good reason for these classes to not have move constructor, > > or is it just an unfortunate omission? > Because the implementation of a move constructor for those classes > requires the private class to

Re: [Development] Move assignment without move constructors

2016-05-23 Thread Giuseppe D'Angelo
Il 23/05/2016 18:11, Konstantin Tokarev ha scritto: Hello, I've stumbled upon QPixmap having operator=(QPixmap&&) but missing QPixmap(QPixmap&&), however it seems like there are a lot of Qt classes in the same situation, for example: [snip] Is there any good reason for these classes to

[Development] Move assignment without move constructors

2016-05-23 Thread Konstantin Tokarev
Hello, I've stumbled upon QPixmap having operator=(QPixmap&&) but missing QPixmap(QPixmap&&), however it seems like there are a lot of Qt classes in the same situation, for example: QDir QFileInfo QProcessEnvironment QStorageInfo QUrlQuery QMimeType QCollatorSortKey QCommandLineOption