Re: [Development] Proposals for changes to "Precheck" feature

2022-03-26 Thread Oswald Buddenhagen
On Sat, Mar 26, 2022 at 08:12:31AM -0300, Thiago Macieira wrote: On Saturday, 26 March 2022 04:57:08 -03 Oswald Buddenhagen wrote: (it would be nearly trivial to implement now - just use git-gpick.) There are also cases when changes in the middle of a series have been integrated, but the head

Re: [Development] Proposals for changes to "Precheck" feature

2022-03-26 Thread Thiago Macieira
On Saturday, 26 March 2022 04:57:08 -03 Oswald Buddenhagen wrote: > yes, it should do cherry-picking like the actual integrations do. but > that would mean work, so it wasn't done. > (it would be nearly trivial to implement now - just use git-gpick.) Indeed but normal integrations don't do anythin

Re: [Development] Proposals for changes to "Precheck" feature

2022-03-26 Thread Oswald Buddenhagen
On Fri, Mar 25, 2022 at 09:39:27PM -0300, Thiago Macieira wrote: When you have multiple changes you've submitted, you could pre-check the last one and get a result for all of them. That use-case will go away with rebasing. nobody said that dependencies would be ignored. But that was already

Re: [Development] Proposals for changes to "Precheck" feature

2022-03-25 Thread Thiago Macieira
On Friday, 25 March 2022 13:42:39 -03 Volker Hilsheimer wrote: > * always rebase the commit before prechecking > > Right now, precheck is a checkout, which means that the precheck is done on > top of the revision that it was pushed from. Since that is not the revision > that it will ultimately int

Re: [Development] Proposals for changes to "Precheck" feature

2022-03-25 Thread Giuseppe D'Angelo via Development
On 25/03/2022 17:54, Alexandru Croitor wrote: I would prefer a comment-based precheck system instead, and keep the existing precheck as-is. https://bugreports.qt.io/browse/QTQAINFRA-4419 See also the other ideas in that bug report, most notably also allowing to somehow select a subset of pla

Re: [Development] Proposals for changes to "Precheck" feature

2022-03-25 Thread Alexandru Croitor
Hi, > On 25. Mar 2022, at 17:42, Volker Hilsheimer wrote: > > * always rebase the commit before prechecking I have controversial feelings about this one. Sometimes i want it rebased on latest HEAD of the branch in question, sometimes I want the exact parent I chose. You can get merge conflic

[Development] Proposals for changes to "Precheck" feature

2022-03-25 Thread Volker Hilsheimer
Hey ho, We’ve had the convenient “precheck’” button in gerrit for a while now, allowing approvers to kick off a CI-dry-run to check if things would pass an integration before asking for reviews, and without the risk of tearing down a bunch of co-staged changes in case of failure. Two things th