Re: [Development] QRect::contains and undocumented(?) edge

2022-04-21 Thread Allan Sandfeld Jensen
On Donnerstag, 21. April 2022 16:09:37 CEST Thiago Macieira wrote: > On Thursday, 21 April 2022 06:22:57 PDT Tomi Pannila wrote: > > Is there a possibility to add a picture to Qt documentation where you > > have a rectangle grid and shade the > > edge cells with some color to identify them as

Re: [Development] QRect::contains and undocumented(?) edge

2022-04-21 Thread Giuseppe D'Angelo via Development
On 21/04/2022 16:09, Thiago Macieira wrote: It has some unintuitive defects and flaws, but they can't be fixed because this class is OLD. We can improve documentation, but that's all. If drawing the chess board as a stand-in for the pixel helps understand, then it might be a good idea. There

Re: [Development] QRect::contains and undocumented(?) edge

2022-04-21 Thread Thiago Macieira
On Thursday, 21 April 2022 06:22:57 PDT Tomi Pannila wrote: > Is there a possibility to add a picture to Qt documentation where you > have a rectangle grid and shade the > edge cells with some color to identify them as edges? If I'm the only > one confused of the term edge, not edge cell, in

Re: [Development] QRect::contains and undocumented(?) edge

2022-04-21 Thread Tomi Pannila
Hi Eirik, I start to understand your point of view. You view edge from programming point of view? Like if you have a chess board, an edge cell is one where one cannot take one cell step to all directions? If I would have to point an edge of a chess board, I would point to the physical edge.

Re: [Development] QRect::contains and undocumented(?) edge

2022-04-21 Thread Eirik Aavitsland
On 4/20/22 17:50, Tomi Pannila wrote: Hi Lars and Eirik, thank you for the explanations. I guess Eirik kind of guessed right that I view QRect from $\mathbb{R}^2$ point of view. I'm a mathematician and this is the most natural point of view for me. For me, rectangles have edges=boundary

Re: [Development] QRect::contains and undocumented(?) edge

2022-04-20 Thread Giuseppe D'Angelo via Development
Hi, On 20/04/2022 17:50, Tomi Pannila wrote: thank you for the explanations. I guess Eirik kind of guessed right that I view QRect from $\mathbb{R}^2$ point of view. I'm a mathematician and this is the most natural point of view for me. For me, rectangles have edges=boundary which are measure

Re: [Development] QRect::contains and undocumented(?) edge

2022-04-20 Thread Tomi Pannila
Hi Lars and Eirik, thank you for the explanations. I guess Eirik kind of guessed right that I view QRect from $\mathbb{R}^2$ point of view. I'm a mathematician and this is the most natural point of view for me. For me, rectangles have edges=boundary which are measure zero. To Lars >>

Re: [Development] QRect::contains and undocumented(?) edge

2022-04-20 Thread Eirik Aavitsland
Hi Tomi, I'm sure there are many things that could be improved in both doc and code here, but let me try to explain how this was intended at least could you please explain how your method "QRect::contains(const QRect , bool proper)" at

Re: [Development] QRect::contains and undocumented(?) edge

2022-04-20 Thread Lars Knoll
Hi Tomi, > On 19 Apr 2022, at 21:49, Tomi Pannila wrote: > > Hi Qt developers, > > could you please explain how your method "QRect::contains(const QRect , > bool proper)" at > https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qrect.cpp?h=dev > satisfies your API design principles >

[Development] QRect::contains and undocumented(?) edge

2022-04-19 Thread Tomi Pannila
Hi Qt developers, could you please explain how your method "QRect::contains(const QRect , bool proper)" at https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qrect.cpp?h=dev satisfies your API design principles 1. Have clear and simple semantics 2. Be intuitive 3. Be easy to