Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-21 Thread Jason McDonald
On Thu, Jul 11, 2019 at 10:29 PM Volker Hilsheimer wrote: > That there is no overload that takes modifiers and keys is also strange. > > > Most likely this omission is simply because nobody ever asked for such > an overload. I'm fairly sure that that part of testlib existed before > modifiers an

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-11 Thread Volker Hilsheimer
On 11 Jul 2019, at 10:26, Elvis Stansvik mailto:elvst...@gmail.com>> wrote: Den tors 11 juli 2019 kl 05:54 skrev Jason McDonald mailto:macadd...@gmail.com>>: Welcome back Jason :) On Tue, Jul 9, 2019 at 1:39 AM Shawn Rutledge mailto:shawn.rutle...@qt.io>> wrote: On 8 Jul 2019, at 16:24, Vol

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-11 Thread Edward Welbourne
Jason McDonald (11 July 2019 05:53) wrote: > I also recall that there used to be a wiki page that listed some > best-practices for writing unit tests. If that list still exists > somewhere, this advice should be added there. Possibly: https://wiki.qt.io/Writing_good_tests Eddy. __

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-11 Thread Elvis Stansvik
Den tors 11 juli 2019 kl 05:54 skrev Jason McDonald : > > On Tue, Jul 9, 2019 at 1:39 AM Shawn Rutledge wrote: > > > On 8 Jul 2019, at 16:24, Volker Hilsheimer > > > wrote: > > > > > > Hi, > > > > > > Executive summary: > > > > > > * QTest::mouseMove seems to be broken > > > * when simulating QE

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-11 Thread Jason McDonald
On Thu, Jul 11, 2019 at 5:57 PM Palaraja, Kavindra wrote: > On 11.07.19, 05:55, "Development on behalf of Jason McDonald" > wrote: > > > > I also recall that there used to be a wiki page that listed some > best-practices for writing unit tests. If that list still exists > somewh

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-11 Thread Palaraja, Kavindra
On 11.07.19, 05:55, "Development on behalf of Jason McDonald" wrote: I also recall that there used to be a wiki page that listed some best-practices for writing unit tests. If that list still exists somewhere, this advice should be added there. Did you mean this page: https://

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-10 Thread Jason McDonald
On Tue, Jul 9, 2019 at 1:39 AM Shawn Rutledge wrote: > > On 8 Jul 2019, at 16:24, Volker Hilsheimer wrote: > > > > Hi, > > > > Executive summary: > > > > * QTest::mouseMove seems to be broken > > * when simulating QEvent::MouseMove events by constructing event objects, > > always construct them

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-09 Thread Gatis Paeglis
sts in future. From: Development on behalf of Friedemann Kleint Sent: Tuesday, July 9, 2019 8:33 AM To: development@qt-project.org Subject: Re: [Development] QTestlib: how not to test mouseMoveEvent handling Hi, AFAIK Gatis is working this (see

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-08 Thread Friedemann Kleint
Hi, AFAIK Gatis  is working this (see https://bugreports.qt.io/browse/QTBUG-69414 ). There is a magic define widgets/widgets/qcombobox/qcombobox.pro:4:DEFINES += QTEST_QPA_MOUSE_HANDLING widgets/widgets/qmenu/qmenu.pro:9:    DEFINES += QTEST_QPA_MOUSE_HANDLING which apparently changes behavior

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-08 Thread Volker Hilsheimer
On 8 Jul 2019, at 17:38, Shawn Rutledge mailto:shawn.rutle...@qt.io>> wrote: On 8 Jul 2019, at 16:24, Volker Hilsheimer mailto:volker.hilshei...@qt.io>> wrote: Hi, Executive summary: * QTest::mouseMove seems to be broken * when simulating QEvent::MouseMove events by constructing event obje

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-08 Thread Elvis Stansvik
Den mån 8 juli 2019 kl 16:26 skrev Volker Hilsheimer : > > Hi, > > Executive summary: > > * QTest::mouseMove seems to be broken > * when simulating QEvent::MouseMove events by constructing event objects, > always construct them with global position > > > The details: > > While trying to fix https:

Re: [Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-08 Thread Shawn Rutledge
> On 8 Jul 2019, at 16:24, Volker Hilsheimer wrote: > > Hi, > > Executive summary: > > * QTest::mouseMove seems to be broken > * when simulating QEvent::MouseMove events by constructing event objects, > always construct them with global position > > > The details: > > While trying to fix h

[Development] QTestlib: how not to test mouseMoveEvent handling

2019-07-08 Thread Volker Hilsheimer
Hi, Executive summary: * QTest::mouseMove seems to be broken * when simulating QEvent::MouseMove events by constructing event objects, always construct them with global position The details: While trying to fix https://bugreports.qt.io/browse/QTBUG-76765 to not update the mouse cursor when t