Re: [Development] Qt Multimedia: proposing behavior change to QAudioSink::resume

2023-02-06 Thread Volker Hilsheimer via Development
On 1 Feb 2023, at 14:01, Lars Knoll wrote: I agree. Let’s change behaviour and move it to active after a call to resume(). It also behaves the same in push and pull mode in that case. Cheers, Lars Thanks, done now in https://codereview.qt-project.org/c/qt/qtmultimedia/+/458410 which is

Re: [Development] Qt Multimedia: proposing behavior change to QAudioSink::resume

2023-02-01 Thread Lars Knoll
I agree. Let’s change behaviour and move it to active after a call to resume(). It also behaves the same in push and pull mode in that case. Cheers, Lars > On 31 Jan 2023, at 13:11, Tor Arne Vestbø via Development > wrote: > > Hi, > > This does indeed look like an oversight, where the

Re: [Development] Qt Multimedia: proposing behavior change to QAudioSink::resume

2023-01-31 Thread Tor Arne Vestbø via Development
Hi, This does indeed look like an oversight, where the behavior was perhaps modeled under the assumption the buffers were empty at the time of suspend(). I would expect the state to return back to the same state the sink had when calling suspend(). Cheers, Tor Arne > On 30 Jan 2023, at

[Development] Qt Multimedia: proposing behavior change to QAudioSink::resume

2023-01-30 Thread Volker Hilsheimer via Development
Hi, TL;DR: I’d like to change QAudioSink::resume() to always change the sink to Active state, no matter how the sink was start()’ed. QAudioSink provides low-level access to an audio device, allowing applications to provide PCM data. The class operates in one of two modes: in pull mode, the