Re: [Development] Qt pi

2017-01-11 Thread Edward Welbourne
Lars Knoll: > plan sounds good, just go ahead :) I've opened QTBUG-58083 for the sake of tracking it. Anyone with further comments is welcome to look there. On IRC, peppe has pointed out using L may get narrowing warnings from some compilers. So I'll start with using M_PI and Math.PI more

Re: [Development] Qt pi

2017-01-11 Thread Lars Knoll
Hi Eddy, plan sounds good, just go ahead :) Cheers, Lars > On 11 Jan 2017, at 15:35, Edward Welbourne wrote: > > Hi all, > > In the course of testing 5.8.0, I was puzzled by an example hard-coding > a value for pi, rather than re-using one from some public header as I

[Development] Qt pi

2017-01-11 Thread Edward Welbourne
Hi all, In the course of testing 5.8.0, I was puzzled by an example hard-coding a value for pi, rather than re-using one from some public header as I expected. To my surprise, the standard library only provides M_PI as a POSIX extension. It turns out we do have a qmath.h that, sensibly enough,