Re: [Development] XDG icon theme support

2014-03-31 Thread Alberto Mardegan
On 03/30/2014 03:56 PM, Gladhorn Frederik wrote: > A fix for this would certainly be appreciated. > http://qt-project.org/wiki/Gerrit-Introduction > > On Saturday 29. March 2014 14.56.16 Rex Dieter wrote: >> Ruslan Nigmatullin wrote: >>> If the changes will be done and accepted is there any hope t

Re: [Development] XDG icon theme support

2014-03-31 Thread Olivier Goffart
On Saturday 29 March 2014 14:56:16 Rex Dieter wrote: > Ruslan Nigmatullin wrote: > > If the changes will be done and accepted is there any hope to have them in > > Qt 5.2.* > > It's a bug fix rather than a new feature, so yeah, I'd expect it could be > included in a subsequent bugfix release (assu

Re: [Development] XDG icon theme support

2014-03-30 Thread Ruslan Nigmatullin
Hello, 30.03.2014, 16:56, "Gladhorn Frederik" : > A fix for this would certainly be appreciated. > http://qt-project.org/wiki/Gerrit-Introduction Thanks, here are the commits: https://codereview.qt-project.org/82185 https://codereview.qt-project.org/82186 > On Saturday 29. March 2014 14.56.16 Re

Re: [Development] XDG icon theme support

2014-03-30 Thread Gladhorn Frederik
A fix for this would certainly be appreciated. http://qt-project.org/wiki/Gerrit-Introduction On Saturday 29. March 2014 14.56.16 Rex Dieter wrote: > Ruslan Nigmatullin wrote: > > If the changes will be done and accepted is there any hope to have them in > > Qt 5.2.* > > It's a bug fix rather tha

Re: [Development] XDG icon theme support

2014-03-29 Thread Rex Dieter
Ruslan Nigmatullin wrote: > If the changes will be done and accepted is there any hope to have them in > Qt 5.2.* It's a bug fix rather than a new feature, so yeah, I'd expect it could be included in a subsequent bugfix release (assuming there is one). May be worth actually filing a bug to both

[Development] XDG icon theme support

2014-03-28 Thread Ruslan Nigmatullin
Hi friends, Current Qt's implementation of QIcon::fromTheme violates xdg icon naming specification ( http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html ). By specification if icon "drive-removable-media-usb" is not found implementation should fallback to "drive-remo