[Development] codereview, merge please

2019-02-15 Thread Martin Koller
Hi, I made a patch here https://codereview.qt-project.org/#/c/249171/ but it's still not merged. Did I forget something ? -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html e-mail /\

Re: [Development] codereview, merge please

2019-02-15 Thread Andy Shaw
Since it has the +2 you can click on the "Merge patch 2 to staging" now, is that button showing up for you? Andy -Opprinnelig melding- Fra: Development på vegne av Martin Koller Dato: fredag 15. februar 2019 11:04 Til: "development@qt-project.org" Emne: [Dev

Re: [Development] codereview, merge please

2019-02-15 Thread Martin Koller
Thanks! > Andy > > -Opprinnelig melding- > Fra: Development på vegne av Martin > Koller > Dato: fredag 15. februar 2019 11:04 > Til: "development@qt-project.org" > Emne: [Development] codereview, merge please > > Hi, > > I made a

Re: [Development] codereview, merge please

2019-02-15 Thread Frederik Gladhorn
ng- > > Fra: Development på vegne av Martin > > Koller Dato: fredag 15. februar 2019 11:04 > > Til: "development@qt-project.org" > > Emne: [Development] codereview, merge please > > > > Hi, > > > > I made a patch here >

Re: [Development] codereview, merge please

2019-02-20 Thread Martin Koller
pment på vegne av Martin > Koller > Dato: fredag 15. februar 2019 11:04 > Til: "development@qt-project.org" > Emne: [Development] codereview, merge please > > Hi, > > I made a patch here > https://codereview.qt-proj

Re: [Development] codereview, merge please

2019-02-20 Thread Kari Oikarinen
On 21.2.2019 9.08, Martin Koller wrote: > On Freitag, 15. Februar 2019 11:08:18 CET Andy Shaw wrote: >> Since it has the +2 you can click on the "Merge patch 2 to staging" now, is >> that button showing up for you? > > So now I did merge it to staging, but I got a "Qt CI Bot" mail stating that