Re: [Development] renaming all QWindow properties that have window in them

2012-10-22 Thread Oswald Buddenhagen
On Mon, Oct 22, 2012 at 10:08:14AM +0200, Samuel Rødal wrote: On 19 October 2012 21:56, Oswald Buddenhagen oswald.buddenha...@digia.com wrote: i don't see why this shouldn't apply equally to qml. if it poses a problem in a particular case, it is most likely indicative of a serious API

[Development] renaming all QWindow properties that have window in them

2012-10-19 Thread Rutledge Shawn
QWindow has properties like windowTitle, windowIcon, windowModality, windowState and so on, which are named that way to be familiar to users of QWidget. However it causes some silliness in Qt Quick: QQuickWindow inherits QWindow, and that means it inherits those properties too (even though

Re: [Development] renaming all QWindow properties that have window in them

2012-10-19 Thread Samuel Rødal
On 10/19/2012 06:46 PM, Rutledge Shawn wrote: QWindow has properties like windowTitle, windowIcon, windowModality, windowState and so on, which are named that way to be familiar to users of QWidget. However it causes some silliness in Qt Quick: QQuickWindow inherits QWindow, and that means

Re: [Development] renaming all QWindow properties that have window in them

2012-10-19 Thread Konstantin Ritt
my +1 to renaming (didn't review the patches, though) Konstantin 2012/10/19 Samuel Rødal samuel.ro...@digia.com: On 10/19/2012 06:46 PM, Rutledge Shawn wrote: QWindow has properties like windowTitle, windowIcon, windowModality, windowState and so on, which are named that way to be familiar

Re: [Development] renaming all QWindow properties that have window in them

2012-10-19 Thread Oswald Buddenhagen
On Fri, Oct 19, 2012 at 04:46:01PM +, Rutledge Shawn wrote: QWindow has properties like windowTitle, windowIcon, windowModality, windowState and so on, which are named that way to be familiar to users of QWidget. correct. http://doc.qt.digia.com/qq/qq13-apis.html#theartofnaming , general

Re: [Development] renaming all QWindow properties that have window in them

2012-10-19 Thread Shawn Rutledge
On 19 October 2012 21:56, Oswald Buddenhagen oswald.buddenha...@digia.com wrote: On Fri, Oct 19, 2012 at 04:46:01PM +, Rutledge Shawn wrote: QWindow has properties like windowTitle, windowIcon, windowModality, windowState and so on, which are named that way to be familiar to users of

Re: [Development] renaming all QWindow properties that have window in them

2012-10-19 Thread Thiago Macieira
On sexta-feira, 19 de outubro de 2012 22.18.25, Shawn Rutledge wrote: So pos is bad because it's abbreviated. And I suspect we may have problems with renaming windowState to state, because in QML that usually refers to the state-machine state (driving animated transitions etc.) Should we be