Re: [Development] Q_FOREACH, again

2023-08-14 Thread Ahmad Samir
On 14/8/23 21:46, Thiago Macieira wrote: On Monday, 14 August 2023 10:32:36 PDT Marc Mutz via Development wrote: It does _not_ have any influence on user code. Except where accidentally the QT_NO_FOREACH gets copied to the library's CMake INTERFACE. Then it does. This happened for

[Development] Using DMA instead of SHM in non OpenGL apps (Linux/Wayland)

2023-08-14 Thread Eduardo Hopperdietzel
Hello Kai, Thank you for your reply. After following the links you provided, I believe that implementing the DMA feature should take place within the following file: https://code.qt.io/cgit/qt/qtwayland.git/tree/src/client/qwaylandshmbackingstore.cpp Here's my proposed plan for this

Re: [Development] Q_FOREACH, again

2023-08-14 Thread Thiago Macieira
On Monday, 14 August 2023 10:32:36 PDT Marc Mutz via Development wrote: > It does _not_ have any influence on user code. Except where accidentally the QT_NO_FOREACH gets copied to the library's CMake INTERFACE. Then it does. This happened for QT_NO_CONTEXTLESS_CONNECT when it was applied to

Re: [Development] Q_FOREACH, again

2023-08-14 Thread Marc Mutz via Development
Forgot to add sample commits for each of the cases. Added inline below. Also, please use topic:Q_FOREACH in Gerrit. Module maintainers: if your module's .cmake.conf doesn't already contain the QT_NO_FOREACH=1, and no Gerrit change is up that adds it, either add it yourself to check locally or

[Development] Q_FOREACH, again

2023-08-14 Thread Marc Mutz via Development
Hi, I've uploaded a patch series that makes QT_NO_FOREACH the default and whitelists any existing uses of Q_FOREACH/foreach as can be seen in the culminating patch of the series: https://codereview.qt-project.org/c/qt/qtbase/+/495115 The intention of this patch series is not to fix all uses,

Re: [Development] RFC: CMake's automoc option to warn about missing moc includes; or not have mocs_compilation.cpp

2023-08-14 Thread Friedrich W. H. Kossebau
Hi, Am Donnerstag, 13. Juli 2023, 23:16:07 CEST schrieb Friedrich W. H. Kossebau: > I would like to propose some new features to CMake's automoc, around > enforcing explicit moc includes, and to do this with support of the > respective Qt developers, so first hear their comments or, best, get

Re: [Development] Failed to run configure.bat in qt/qt5 repository on Windows?

2023-08-14 Thread Edward Welbourne via Development
Haowei Hsu (14 August 2023 13:27) wrote: > The reason why I run vcvarsall.bat is to let CMake find MSVC compilers. Understandable, just not given by README.md > As for init-repository, I didn't see its instructions in README.md [...] > Where is it? https://github.com/qt/qt5/blob/dev/README.git

Re: [Development] QAbstractItemModel's meta-object got changed in QtQuick

2023-08-14 Thread Axel Spoerl via Development
Hi, The meta object doesn’t change during execution. The messages probably mean, that upon app close, the custom class (inheriting from QObject) is already deleted. Only a QObject is left, which is what className() correctly reports. Maybe throw a qDebug() in the custom class destructor, to

[Development] QAbstractItemModel's meta-object got changed in QtQuick

2023-08-14 Thread Ziming Song
Hi, I’m playing with QtQuick TreeView with custom QAbstractItemModel in C++. The program runs fine, except some error logs when program exits: qt.core.qobject.connect: QObject::disconnect: No such signal QObject::rowsAboutToBeRemoved(QModelIndex,int,int) qt.core.qobject.connect:

Re: [Development] Failed to run configure.bat in qt/qt5 repository on Windows?

2023-08-14 Thread Haowei Hsu
Hello, Edward. These instructions do not appear in README.md; it contains, for example, > no mention of vcvarsall.bat and its instructions for updating quite > explicitly mention running init-repository. See README.git for the > details of how to clone and set up an initial checkout of Qt. Note

[Development] [Announce] Qt Creator 11.0.2 released

2023-08-14 Thread List for announcements regarding Qt releases and development via Announce via Development
We are happy to announce the release of Qt Creator 11.0.2! https://www.qt.io/blog/qt-creator-11.0.2-released David Schulz Software Engineer The Qt Company GmbH Rudower Chaussee 13 D-12489 Berlin david.sch...@qt.io +49 30 63 92 32 56 http://qt.io Geschäftsführer: Mika Pälsi,

Re: [Development] Unity Build on CI for Qt Base for 3 Platforms

2023-08-14 Thread Friedrich W. H. Kossebau
Hi, Am Freitag, 11. August 2023, 22:14:13 CEST schrieb Marc Mutz via Development: > All my -unity-build-batch-size 100'000 patches except for one are now > merged: https://codereview.qt-project.org/q/topic:unity-build > > I'm currently testing without the unmerged one, because it won't apply >

Re: [Development] C++20 comparisons @ Qt (was: Re: C++20 @ Qt)

2023-08-14 Thread Ivan Solovev via Development
I'm now re-reading the discussion, and I think that I missed one thing previously, so let me comment on that. > What I meant is that the product API of using the macros are the set of > operators. The methods that those operators called are not API and users are > not expected to use them in

Re: [Development] Failed to run configure.bat in qt/qt5 repository on Windows?

2023-08-14 Thread Edward Welbourne via Development
Haowei Hsu (13 August 2023 14:08) wrote: > Recently, I tried to configure the qt/qt5 > repository. The following commands are what I use to configure the > project according to its README.md: > > 1. git clone --recursive https://github.com/qt/qt5.git > 2. chdir qt5

[Development] Nominating Kwanghyo Park as approver

2023-08-14 Thread Tomi Korpipää via Development
Hi, I'd like to nominate Kwanghyo Park for approver status. He is the main developer for Surface3D graphs for the QtGraphs module, and has been contributing to QtDataVisualization, QtQuick3D, and QtLottie as well. https://codereview.qt-project.org/q/owner:kwanghyo.park%2540qt.io