Re: [Development] Q_FOREACH, again

2023-08-14 Thread Ahmad Samir
On 14/8/23 21:46, Thiago Macieira wrote: On Monday, 14 August 2023 10:32:36 PDT Marc Mutz via Development wrote: It does _not_ have any influence on user code. Except where accidentally the QT_NO_FOREACH gets copied to the library's CMake INTERFACE. Then it does. This happened for

Re: [Development] Q_FOREACH, again

2023-08-14 Thread Thiago Macieira
On Monday, 14 August 2023 10:32:36 PDT Marc Mutz via Development wrote: > It does _not_ have any influence on user code. Except where accidentally the QT_NO_FOREACH gets copied to the library's CMake INTERFACE. Then it does. This happened for QT_NO_CONTEXTLESS_CONNECT when it was applied to

Re: [Development] Q_FOREACH, again

2023-08-14 Thread Marc Mutz via Development
Forgot to add sample commits for each of the cases. Added inline below. Also, please use topic:Q_FOREACH in Gerrit. Module maintainers: if your module's .cmake.conf doesn't already contain the QT_NO_FOREACH=1, and no Gerrit change is up that adds it, either add it yourself to check locally or

[Development] Q_FOREACH, again

2023-08-14 Thread Marc Mutz via Development
Hi, I've uploaded a patch series that makes QT_NO_FOREACH the default and whitelists any existing uses of Q_FOREACH/foreach as can be seen in the culminating patch of the series: https://codereview.qt-project.org/c/qt/qtbase/+/495115 The intention of this patch series is not to fix all uses,