[PATCH V12 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-22 Thread Byungho An
From: Vipul Pandya This patch adds ethtool related functions. Signed-off-by: Vipul Pandya Neatening-by: Joe Perches Signed-off-by: Byungho An --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25 +- drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c | 509 +++- driv

[PATCH V12 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-22 Thread Byungho An
From: Vipul Pandya This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya Neatening-by: Joe Perches Signed-off-by: Byungho An --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h |5 +++ drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c | 20 + drivers

[PATCH V12 1/7] sxgbe: Add device-tree binding support document

2014-03-22 Thread Byungho An
From: Siva Reddy This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam Signed-off-by: Byungho An --- .../devicetree/bindings/net/samsung-sxgbe.txt | 52 1 file changed, 52 insertions(+) create mode 100644 Docu

[PATCH V12 3/7] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-22 Thread Byungho An
From: Vipul Pandya Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya Neatening-by: Joe Perches Signed-off-by: Byungho An --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h |1 + drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.c |2 +- drivers/net/e

[PATCH V12 7/7] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-22 Thread Byungho An
From: Byungho An Signed-off-by: Byungho An --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported L: linux-samsung-...@vger.kernel.

[PATCH V12 0/7] add new Samsung SXGBE driver

2014-03-22 Thread Byungho An
Hi all, This is 12th posting for SAMSUNG SXGBE driver. Changes since v1: - changed name of driver to SXGbE as per Ben's comment - squashed Joe's neatening for many stuff in original patches Changes since v2: - updated and split binding document as per Mark's comment - clean up codes as per Joe's

[PATCH V12 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-22 Thread Byungho An
From: Girish K S Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S Neatening-by: Joe Perches Signed-off-by: Byungho An --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 53 +++ drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Vince Bridgers : > On Sat, Mar 22, 2014 at 1:23 AM, Byungho An wrote: > > From: Siva Reddy > > > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). [snip] > > + /* Stop Advertising 1000BASE Capability if interface is not GMII */ > > + if ((phy_iface == PHY_INTERFACE

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Vince Bridgers : > See comments inline > > On Sat, Mar 22, 2014 at 1:23 AM, Byungho An wrote: > > From: Siva Reddy > > > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). > > [snip] > > + /* program desc registers */ > > + writel(dma_tx >> 32, > > +

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Tomasz Figa : > On 22.03.2014 22:55, Byungho An wrote: > > > > Tomasz Figa : > > [snip] > > >>> + if (priv->irq <= 0) { > >>> + dev_err(dev, "sxgbe common irq parsing failed\n"); > >>> + sxgbe_drv_remove(ndev); > >>> + return -EINVAL; > >>> + } > >>> + > >>> + /* Get th

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Vince Bridgers : > On Sat, Mar 22, 2014 at 1:23 AM, Byungho An wrote: > > From: Siva Reddy > > > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). > > [snip] > > +static int sxgbe_init_rx_buffers(struct net_device *dev, > > +struct sxgbe_rx_nor

Re: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Tomasz Figa
On 22.03.2014 22:55, Byungho An wrote: Tomasz Figa : [snip] + if (priv->irq <= 0) { + dev_err(dev, "sxgbe common irq parsing failed\n"); + sxgbe_drv_remove(ndev); + return -EINVAL; + } + + /* Get the TX/RX IRQ numbers */ + fo

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Tomasz Figa : > Hi, > > I have reviewed the non-net-specific parts of this driver, e.g. platform driver > and Device Tree code. Please see my comments inline. > > On 22.03.2014 07:23, Byungho An wrote: > > From: Siva Reddy > > > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe)

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Francois Romieu wrote : > Byungho An : > [...] > > +static int sxgbe_init_rx_buffers(struct net_device *dev, > > +struct sxgbe_rx_norm_desc *p, int i, > > +unsigned int dma_buf_sz, > > +struct sxgbe_rx_queue *rx_

RE: [PATCH V10 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Francois Romieu wrote: > Byungho An : > [...] > > > Nit: you may consider reorganizing the variables in an inverted xmas > > > tree fashion at some point. > > Does it look better? No problem. > > Marginally if not more. Consider it a guideline to avoid unusual or ugly layout. OK. I'll consider

Re: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Joe Perches
On Sat, 2014-03-22 at 14:01 -0500, Vince Bridgers wrote: > See comments inline Do please trim your comments instead of quoting the _whole_ email. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Mark Brown
On Sat, Mar 22, 2014 at 08:08:03PM +0100, Carlo Caione wrote: > On Sat, Mar 22, 2014 at 11:42:01AM -0700, Dmitry Torokhov wrote: > > > drivers/mfd/axp20x.c:172:18: warning: assignment makes integer > > > frompointer without a cast [enabled by default] > > You need to cast to long, otherwise you w

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Carlo Caione
On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown wrote: > On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: >> On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: > >> > > + of_id = of_match_device(axp20x_of_match, &i2c->dev); >> > > + if (!of_id) { >> > > + dev_err(&i2c->dev

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Carlo Caione
On Sat, Mar 22, 2014 at 11:42:01AM -0700, Dmitry Torokhov wrote: > On Sat, Mar 22, 2014 at 07:13:36PM +0100, Carlo Caione wrote: > > On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown wrote: > > > On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: > > >> On Tue, Mar 18, 2014 at 03:59:19PM +000

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Dmitry Torokhov
On Sat, Mar 22, 2014 at 07:13:36PM +0100, Carlo Caione wrote: > On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown wrote: > > On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: > >> On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: > > > >> > > + of_id = of_match_device(axp20x_of_matc

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Carlo Caione
On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown wrote: > On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: >> On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: > >> > > + of_id = of_match_device(axp20x_of_match, &i2c->dev); >> > > + if (!of_id) { >> > > + dev_err(&i2c->dev

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Mark Brown
On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: > On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: > > > + of_id = of_match_device(axp20x_of_match, &i2c->dev); > > > + if (!of_id) { > > > + dev_err(&i2c->dev, "Unable to setup AXP20X data\n"); > > > + return

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Carlo Caione
On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: > > +static struct mfd_cell axp20x_cells[] = { > > + { > > + .name = "axp20x-pek", > > + .num_resources = ARRAY_SIZE(axp20x_pek_resources), > > + .resources = axp20x_pek_resources, > > + },

[PATCH 2/7] gpio: dwapb: correct gpio-cells in binding document

2014-03-22 Thread Sebastian Andrzej Siewior
The example uses gpio-cells = 1 while it should be two (it is even mentioned in the text above). Cc: devicetree@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior --- Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 1/7] ARM: dts: socfpga: add gpio pieces

2014-03-22 Thread Sebastian Andrzej Siewior
The cycloneV has three gpio controllers, the first two with 29 gpios, the last one with 27. This patch adds the three controller with the gpio driver which is now sitting the gpio tree. Cc: devicetree@vger.kernel.org Acked-by: Alan Tull Signed-off-by: Sebastian Andrzej Siewior --- v1…v2:

[RESEND PATCH v3 0/3] Introduce fdtgrep for subsetting and hashing FDTs

2014-03-22 Thread Simon Glass
This series adds two new functions, fdt_first_region() and fdt_next_regions() which map FDT parts such as nodes and properties to their regions in the FDT binary. The function is then used to implement a grep utility for FDTs. The core code is quite simple and small, but it grew a little due to th

Re: [linux-sunxi] Re: [PATCH v2 6/8] ARM: sunxi: dt: Add x-powers-axp209.dtsi file

2014-03-22 Thread Carlo Caione
On Tue, Mar 18, 2014 at 10:04:50AM +0100, Maxime Ripard wrote: > On Sat, Mar 15, 2014 at 04:43:43PM +0100, Carlo Caione wrote: > > This dtsi describes the axp209 PMIC, and is to be included from inside > > the i2c controller node to which the axp209 is connected. > > > > Signed-off-by: Hans de Goe

Re: [linux-sunxi] Re: [PATCH v2 2/8] mfd: AXP20x: Add bindings documentation

2014-03-22 Thread Carlo Caione
On Tue, Mar 18, 2014 at 09:45:05AM +0100, Maxime Ripard wrote: > On Sat, Mar 15, 2014 at 04:43:39PM +0100, Carlo Caione wrote: > > Bindings documentation for the AXP20x driver. In this file also two > > sub-nodes (PEK and regulators) are documented. > > PEK doesn't look to be documented, either in

Re: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Tomasz Figa
Hi, I have reviewed the non-net-specific parts of this driver, e.g. platform driver and Device Tree code. Please see my comments inline. On 22.03.2014 07:23, Byungho An wrote: From: Siva Reddy This patch adds support for Samsung 10Gb ethernet driver(sxgbe). - sxgbe core initialization - Tx

[PATCH 4/5] DT: I2C: Add trivial bindings used by kirkwood boards

2014-03-22 Thread Andrew Lunn
Add a number of eeproms and temperature sensors/fan controllers used by kirkwood boards. Signed-off-by: Andrew Lunn --- .../devicetree/bindings/i2c/trivial-devices.txt | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-dev

[PATCH 2/5] DT: bindings: add missing Marvell Kirkwood SoC documentation

2014-03-22 Thread Andrew Lunn
Marvell Kirkwood SoC binding have not yet been documented. Add the documentation including the supported SoCs and boards. Signed-off-by: Andrew Lunn --- .../devicetree/bindings/arm/marvell,kirkwood.txt | 97 ++ 1 file changed, 97 insertions(+) create mode 100644 Documentat

[PATCH 3/5] ARM: Kirkwood: Fix Atmel vendor prefix

2014-03-22 Thread Andrew Lunn
The documented vendor prefix for Atmel is 'atmel' not 'at' as used in these .dts[i] files. The i2c framework actually ignores the prefix, so making this change does not cause compatibility issues. Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/kirkwood-laplug.dts | 2 +- arch/arm/boot/dt

[PATCH 0/5] Kirkwood DT Documentation

2014-03-22 Thread Andrew Lunn
This patchset fixes up a number of issues found by checkpatch in the kirkwood DT files or binding Documentation. Vendor Prefixes are documented, missing prefixes are added, incorrect prefixes are corrected, and Kirkwood SoCs are documented. Note that some of these patches contain UTF-8 characters,

[PATCH 1/5] DT: Vendor: Add prefixes used by Kirkwood devices

2014-03-22 Thread Andrew Lunn
Add a number of vendor prefixes by kirkwood devices. These are not all stock tickers, but have been in use for a while so changing would not be easy. Signed-off-by: Andrew Lunn --- Documentation/devicetree/bindings/vendor-prefixes.txt | 13 - 1 file changed, 12 insertions(+), 1 delet

[PATCH 5/5] ARM: Kirkwood: DT: Add missing vendor prefix

2014-03-22 Thread Andrew Lunn
Add vendor prefixes to compatible strings where they are missing. Both the I2C and MTD framework ignore the prefix, so adding them has no effect on backwards compatibility. Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/kirkwood-b3.dts | 2 +- arch/arm/boot/dts/kirkwood-cloudbox.

Re: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Francois Romieu
Byungho An : [...] > +static int sxgbe_init_rx_buffers(struct net_device *dev, > + struct sxgbe_rx_norm_desc *p, int i, > + unsigned int dma_buf_sz, > + struct sxgbe_rx_queue *rx_ring) > +{ > + struct sxgbe_

Re: [PATCH 3/3] ARM: dts: socfpga: add gpio pieces

2014-03-22 Thread Sebastian Andrzej Siewior
On 03/21/2014 11:15 PM, delicious quinoa wrote: > snps,nr-gpios = <27>; > > As noted on other thread, gpio2 is 27 wide, despite what the > documentation says. When I made that change and remove your other two > patches the gpios worked for me on a cyclone5 devkit board. > > So if you fix the "#g

Re: [PATCH V10 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Francois Romieu
Byungho An : [...] > > Nit: you may consider reorganizing the variables in an inverted xmas tree > > fashion at some point. > Does it look better? No problem. Marginally if not more. Consider it a guideline to avoid unusual or ugly layout. [...] > > > +priv->ioaddr + SXGBE_MDIO_C

Re: [PATCH] ARM: dts: imx6: add support for Ka-Ro TX6 modules

2014-03-22 Thread Shawn Guo
On Wed, Mar 19, 2014 at 02:29:44PM +0100, Lothar Waßmann wrote: > This patch adds support for the Ka-Ro electronics GmbH TX6 modules. > There are five distinct module types with either i.MX6Q or i.MX6DL and > LVDS or LCD display interface and one DTS file for a complete system > with an i.MX6DL bas

Re: [PATCH 3/3] net: hisilicon: new hip04 ethernet driver

2014-03-22 Thread Arnd Bergmann
On Saturday 22 March 2014 09:18:35 zhangfei wrote: > >> +static void hip04_tx_reclaim(struct net_device *ndev, bool force) > >> +{ > >> + struct hip04_priv *priv = netdev_priv(ndev); > >> + unsigned tx_head = priv->tx_head; > >> + unsigned tx_tail = priv->tx_tail; > >> + struct tx_desc *desc =