Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-09 Thread Alexey Klimov
Hi Ramakrishna, On Sun, Sep 6, 2015 at 8:23 PM, Ramakrishna Pallala wrote: > Add new charger driver support for BQ24261 charger IC. > > BQ24261 charger driver relies on extcon notifications to get the > charger cable type and based on that it will set the charging parameters. > > Signed-off-by: R

Re: [PATCH v12 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-09-03 Thread Alexey Klimov
ioremap_resource(nfc->dev, res); > + if (IS_ERR(nfc->regs)) > + return PTR_ERR(nfc->regs); > + > + nfc->clk = devm_clk_get(&pdev->dev, NULL); > + if (IS_ERR(nfc->clk)) > + return PTR_ERR(nfc->clk); > + >

Re: [PATCH 2/5] net: add Hisilicon Network Subsystem hnae framework support

2015-08-17 Thread Alexey Klimov
Hi Kenneth, just small minor question. On Fri, Aug 14, 2015 at 1:30 PM, Kenneth Lee wrote: > HNAE (Hisilicon Network Acceleration Engine) is a framework to provide a > unified ring buffer interface for Hisilicon Network Acceleration Engines. > > With the interface, upper layer can work as ethern

Re: [PATCH 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-23 Thread Alexey Klimov
us IRQ - was a channel > requested?\n"); > + > + return ret; > +} With such usage of ret variable can it happen that handling of last but one channel/instance will set ret to IRQ_WAKE_THREAD and at the same time handling of last channel/instance will set ret to IRQ_HANDLED dur

Re: [PATCH v5 2/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-07-01 Thread Alexey Klimov
cpu); > + > + ret = PTR_ERR(proc_reg); > + goto out_free_resources; > + } > + > + /* Both presence and absence of sram regulator are valid cases. */ > + sram_reg = regulator_get_exclusive(cpu_dev, "sram"

Re: [PATCH v2 3/4] spi: mediatek: Add spi bus for Mediatek MT8173

2015-06-30 Thread Alexey Klimov
Hi Leilk, could you please few minor comments below? On Mon, Jun 29, 2015 at 4:04 PM, Leilk Liu wrote: > This patch adds basic spi bus for MT8173. > > Signed-off-by: Leilk Liu > Signed-off-by: Eddie Huang > --- > drivers/spi/Kconfig | 9 + > drivers/spi/Makefile | 1 + > drivers

Re: [PATCH v9 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-18 Thread Alexey Klimov
d); > + struct led_classdev_flash *fled_cdev = v4l2_flash->fled_cdev; > + struct led_classdev *led_cdev = &fled_cdev->led_cdev; > + int ret = 0; > + > + mutex_lock(&led_cdev->led_access); > + > + if (!v4l2_fh_is_si