Re: [RFC PATCH 1/1] PM / domains: Add support for virtual power domains

2015-01-30 Thread amit daniel kachhap
Hi Karol, I guess this patch series is not complete and use case implementation will be more helpful for clarity. Also I can think of another way in which this complete implementation can be done with pd name as something pd-virt. This pd can be handled differently inside the platform specific

Re: [PATCH RFC v2 07/12] PM / Domains: export pm_genpd_lookup_name

2014-11-28 Thread amit daniel kachhap
On Thu, Nov 27, 2014 at 7:50 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 25 November 2014 at 09:48, amit daniel kachhap amit.dan...@samsung.com wrote: On Tue, Nov 25, 2014 at 1:05 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 24 November 2014 at 14:04, Amit Daniel Kachhap amit.dan

Re: [PATCH RFC v2 06/12] driver: soc: exynos-pmu: Add exynos7 power domain on/off ops

2014-11-25 Thread amit daniel kachhap
On Tue, Nov 25, 2014 at 1:00 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 24 November 2014 at 14:04, Amit Daniel Kachhap amit.dan...@samsung.com wrote: This patch uses the restructuring done in PD handlers and adds PD on/off/status handlers for exynos7. In this SoC, some extra settings

Re: [PATCH RFC v2 07/12] PM / Domains: export pm_genpd_lookup_name

2014-11-25 Thread amit daniel kachhap
On Tue, Nov 25, 2014 at 1:05 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 24 November 2014 at 14:04, Amit Daniel Kachhap amit.dan...@samsung.com wrote: This API may be needed to set the power domain parent/child relationship in the power domain platform driver. The parent relationship

Re: [PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain

2014-11-25 Thread amit daniel kachhap
On Tue, Nov 25, 2014 at 1:29 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 24 November 2014 at 14:04, Amit Daniel Kachhap amit.dan...@samsung.com wrote: This patch adds supports for parent power domain. This will ensure invoking of parent/child power domain on/off in a correct sequence

[PATCH RFC v2 00/12] soc: samsung: Modify and enhance power domain driver

2014-11-24 Thread Amit Daniel Kachhap
Amit Daniel Kachhap (12): arm: exynos: Add platform driver support for power domain driver soc: exynos: Move exynos power domain file to driver/soc/samsung folder soc: samsung: exynos-pmu: Register exynos pd driver as a mfd client soc: samsung: Re-structure PMU driver to create pd on/off

[PATCH RFC v2 01/12] arm: exynos: Add platform driver support for power domain driver

2014-11-24 Thread Amit Daniel Kachhap
once and registered with the power domain subsystem. - Existing DT bindings are used. Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- arch/arm/mach-exynos/pm_domains.c | 40 +++-- 1 file changed, 25

[PATCH RFC v2 02/12] soc: exynos: Move exynos power domain file to driver/soc/samsung folder

2014-11-24 Thread Amit Daniel Kachhap
-by: Amit Daniel Kachhap amit.dan...@samsung.com --- arch/arm/mach-exynos/Makefile |1 - drivers/soc/samsung/Kconfig|9 + drivers/soc/samsung/Makefile |3 ++- .../soc/samsung}/pm_domains.c |0

[PATCH RFC v2 03/12] soc: samsung: exynos-pmu: Register exynos pd driver as a mfd client

2014-11-24 Thread Amit Daniel Kachhap
This is used to probe exynos power domain. This method can be also used for probing other PMU client drivers like pm sleep etc. Currently no platform data is supplied but can be easily extended when required. Reviewed-by: Pankaj Dubey pankaj.du...@samsung.com Signed-off-by: Amit Daniel Kachhap

[PATCH RFC v2 04/12] soc: samsung: Re-structure PMU driver to create pd on/off handlers

2014-11-24 Thread Amit Daniel Kachhap
. This restructuring will be useful for SoC's where certain extra operation need to implemented along with PD on/off operation or if some PD registers are different. There is no functionality change for the existing SoC's. Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/soc/samsung

[PATCH RFC v2 05/12] soc: samsung: pm_domain: Use unique compatible name for power domain

2014-11-24 Thread Amit Daniel Kachhap
. This change will not affect the existing DT bindings. Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- .../bindings/arm/exynos/power_domain.txt |8 drivers/soc/samsung/pm_domains.c | 10 +- 2 files

[PATCH RFC v2 06/12] driver: soc: exynos-pmu: Add exynos7 power domain on/off ops

2014-11-24 Thread Amit Daniel Kachhap
compatible name feature to distinguish between power domains. Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/soc/samsung/exynos-pmu.c| 105 +++ include/linux/soc/samsung/exynos-regs-pmu.h | 17 + 2 files changed, 122 insertions(+) diff

[PATCH RFC v2 07/12] PM / Domains: export pm_genpd_lookup_name

2014-11-24 Thread Amit Daniel Kachhap
-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/base/power/domain.c |3 ++- include/linux/pm_domain.h |7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index fb83d4a..b0e1c2f 100644 --- a/drivers

[PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain

2014-11-24 Thread Amit Daniel Kachhap
This patch adds supports for parent power domain. This will ensure invoking of parent/child power domain on/off in a correct sequence. In exynos7 SOC's, power domain controllers have parent and child hierarchy. Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan

[PATCH RFC v2 09/12] drivers: soc: pm_domain: Modify the parent clocks bindings

2014-11-24 Thread Amit Daniel Kachhap
. Because of this change only exynos5420 SoC DT bindings are affected. The complete example is shown in the DT documentation section. Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- .../bindings/arm/exynos/power_domain.txt | 18 +- drivers/soc/samsung/pm_domains.c

[PATCH RFC v2 11/12] drivers: soc: samsung: Add support for clock rate save/restore in power domain

2014-11-24 Thread Amit Daniel Kachhap
While turning power domain to on/off, some clocks rates might change and need to be saved/restored in the Exynos7 SOC. This patch adds the framework for saving those clocks before power off and restoring it back after power on operation. Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com

[PATCH RFC v2 12/12] arm64: Kconfig: Enable PM_GENERIC_DOMAINS for exynos7

2014-11-24 Thread Amit Daniel Kachhap
Use power domain driver for Exynos7 SOC's Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- arch/arm64/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 30bd4d5..b102d0b 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64

[PATCH RFC v2 10/12] drivers: soc: samsung: Add support for clock enabling in power domain

2014-11-24 Thread Amit Daniel Kachhap
domain suspend/resume interface. Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- .../bindings/arm/exynos/power_domain.txt | 12 ++ drivers/soc/samsung/pm_domains.c | 138 +++- 2 files changed, 146 insertions(+), 4 deletions(-) diff --git

Re: [PATCHv3] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250

2014-08-19 Thread amit daniel kachhap
: Zhang Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Cc: Amit Daniel Kachhap amit.dan...@samsung.com The changes looks fine, Reviewed-by: Amit Daniel Kachhap amit.dan...@samsung.com Thanks, Amit --- Changes from v2: - Fix build break because of missing 'or' operation

Re: [PATCH] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-19 Thread amit daniel kachhap
...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Cc: Amit Daniel Kachhap amit.dan...@samsung.com Reviewed-by: Amit Daniel Kachhap amit.dan...@samsung.com Thanks, Amit --- drivers/thermal/samsung/exynos_tmu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/thermal

Re: [RESEND PATCH] thermal: samsung: Add TMU support for Exynos3250 SoC

2014-07-22 Thread amit daniel kachhap
On Mon, Jul 21, 2014 at 11:34 AM, Zhang Rui rui.zh...@intel.com wrote: On Fri, 2014-07-18 at 09:00 +0900, Chanwoo Choi wrote: This patch adds the registers, bit fields and compatible strings required to support for the 1 TMU channels on Exynos3250. Signed-off-by: Chanwoo Choi

Re: [PATCH v6 15/23] regulator: max77686: Setup DVS-related GPIOs on probe

2014-07-11 Thread amit daniel kachhap
On Fri, Jul 11, 2014 at 7:33 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Amit, On 07/10/2014 12:08 PM, amit daniel kachhap wrote: On Fri, Jul 4, 2014 at 3:25 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: MAX77686 PMIC support Dyamic Voltage

Re: [PATCH v7 08/24] mfd: max77686: Add Dynamic Voltage Scaling (DVS) support

2014-07-11 Thread amit daniel kachhap
On Fri, Jul 11, 2014 at 7:15 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Amit, On 07/10/2014 11:59 AM, amit daniel kachhap wrote: On Sat, Jul 5, 2014 at 1:54 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Some regulators on the MAX77686 PMIC

Re: [PATCH v7 08/24] mfd: max77686: Add Dynamic Voltage Scaling (DVS) support

2014-07-10 Thread amit daniel kachhap
. This patch adds support to configure the DVSx and SELBx lines from DT and to setup and read the GPIO lines connected to them. The entire series looks nice. Few minor comments from my side. I guess still one more version in needed as per other ppls comment. You may add, Reviewed-by: Amit Daniel

Re: [PATCH v6 15/23] regulator: max77686: Setup DVS-related GPIOs on probe

2014-07-10 Thread amit daniel kachhap
On Fri, Jul 4, 2014 at 3:25 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: MAX77686 PMIC support Dyamic Voltage Scaling (DVS) on a set of Buck regulators. A number of GPIO are connected to these lines and are requested by the mfd driver. Setup the GPIO pins from the