Re: [PATCH v4] EDAC: Add ARM64 EDAC

2015-10-30 Thread Brijesh Singh
Hi, >> I have looked at possibility of pushing correctable error logging in the >> firmware; but given current hardware limitation it seems like OS is the best >> place to implement it. Let me summaries the issues we are running into: >> >> * Correctable errors does not generate any interrupt: >>

Re: [PATCH v4] EDAC: Add ARM64 EDAC

2015-10-30 Thread Brijesh Singh
Hi Mark, >> + >> +Required properties: >> +- compatible: Should be "arm,cortex-a57-edac" or "arm,cortex-a53-edac" >> + >> +Example: >> +edac { >> +compatible = "arm,cortex-a57-edac"; >> +}; >> + > > This is insufficient for big.LITTLE, no interrupt is possible, and we > haven'

[PATCH v4] EDAC: Add ARM64 EDAC

2015-10-28 Thread Brijesh Singh
Add support for Cortex A57 and A53 EDAC driver. Signed-off-by: Brijesh Singh CC: robh...@kernel.org CC: pawel.m...@arm.com CC: mark.rutl...@arm.com CC: ijc+devicet...@hellion.org.uk CC: ga...@codeaurora.org CC: dougthomp...@xmission.com CC: b...@alien8.de CC: mche...@osg.samsung.com CC

Re: [PATCH v3] EDAC: Add ARM64 EDAC

2015-10-27 Thread Brijesh Singh
Thanks for review Steve. On 10/27/2015 02:08 PM, Stephen Boyd wrote: >> +config EDAC_CORTEX_ARM64 >> +tristate "ARM Cortex A57/A53" >> +depends on EDAC_MM_EDAC && ARM64 >> +default n > > n is the default so this can be removed. > noted >> +.driver = { >> +.name = DRV

[PATCH v3] EDAC: Add ARM64 EDAC

2015-10-27 Thread Brijesh Singh
Add support for Cortex A57 and A53 EDAC driver. Signed-off-by: Brijesh Singh CC: robh...@kernel.org CC: pawel.m...@arm.com CC: mark.rutl...@arm.com CC: ijc+devicet...@hellion.org.uk CC: ga...@codeaurora.org CC: dougthomp...@xmission.com CC: b...@alien8.de CC: mche...@osg.samsung.com CC

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-23 Thread Brijesh Singh
> So I checked the x86 code: the driver is always loaded as soon as the > hardware is there (looking at PCI device IDs from the on-chip > northbridge, for instance). The trick here is to have the Kconfig option > defaulting to "=n", so a kernel builder would have to explicitly enable > this. Andro

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Brijesh Singh
Hi Mauro, On 10/21/2015 04:25 PM, Mauro Carvalho Chehab wrote: > Em Wed, 21 Oct 2015 15:41:37 -0500 > Brijesh Singh escreveu: > >> Add support for Cortex A57 and A53 EDAC driver. >> >> Signed-off-by: Brijesh Singh >> CC: robh...@kernel.org >> CC: pawel.m

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Brijesh Singh
Hi Andre, On 10/21/2015 06:52 PM, Andre Przywara wrote: > On 21/10/15 21:41, Brijesh Singh wrote: >> Add support for Cortex A57 and A53 EDAC driver. > > Hi Brijesh, > > thanks for the quick update! Some comments below. > >> >> Signed-off-by: Brijesh Si

[PATCH v2] EDAC: Add ARM64 EDAC

2015-10-21 Thread Brijesh Singh
Add support for Cortex A57 and A53 EDAC driver. Signed-off-by: Brijesh Singh CC: robh...@kernel.org CC: pawel.m...@arm.com CC: mark.rutl...@arm.com CC: ijc+devicet...@hellion.org.uk CC: ga...@codeaurora.org CC: dougthomp...@xmission.com CC: b...@alien8.de CC: mche...@osg.samsung.com CC

Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC

2015-10-21 Thread Brijesh Singh
On 10/21/2015 05:01 AM, Andre Przywara wrote: > Hi, > > On 21/10/15 10:35, Borislav Petkov wrote: >> On Wed, Oct 21, 2015 at 09:55:43AM +0800, Hanjun Guo wrote: >>> So I think the meaning of those error register is the same, but the way >>> of handle it may different from SoCs, for single bit er

Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC

2015-10-20 Thread Brijesh Singh
On 10/20/2015 12:41 PM, Mark Rutland wrote: > On Tue, Oct 20, 2015 at 07:36:39PM +0200, Borislav Petkov wrote: >> On Tue, Oct 20, 2015 at 06:26:55PM +0100, Mark Rutland wrote: Btw, how much of this is implementing generic A57 functionality? >>> >>> The driver is entirely A57 generic. >>> >>>

Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC

2015-10-20 Thread Brijesh Singh
x27;d. > Noted. > On Mon, Oct 19, 2015 at 02:23:17PM -0500, Brijesh Singh wrote: >> Add support for the AMD Seattle SoC EDAC driver. >> >> Signed-off-by: Brijesh Singh >> --- >> .../devicetree/bindings/edac/amd-seattle-edac.txt | 15 + >> drivers/edac/Kcon