Francois Romieu rom...@fr.zoreil.com:
Byungho An bh74...@samsung.com :
[...]
How about below ?
The for loops should be unrolled.
(style: no need to join before branching)
I must go to work, so you'll have to fill the dots in the code below:
priv = sxgbe_drv_probe((pdev-dev
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 52
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Byungho An bh74...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
MAINTAINERS |9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b7befe7..aeb81f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7536,6 +7536,15 @@ S: Supported
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 16
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe
codes for irqs as per Francois's comment
- removed unsupported functions for ehttoolirq as per Ben's comment
Byungho An (1):
MAINTAINERS: add maintainer for Samsung sxgbe driver
Girish K S (1):
net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe
Siva Reddy (2):
sxgbe
Francois Romieu rom...@fr.zoreil.com :
+static int sxgbe_platform_probe(struct platform_device *pdev)
[...]
+ /* Get the SXGBE common INT information */
+ priv-irq = irq_of_parse_and_map(node, 0);
+ if (priv-irq = 0) {
+ dev_err(dev, sxgbe common irq parsing failed\n);
mdio_read/write codes as per Francois's comment
- changed irq acquisition error path as per Francois's comment
- updated mdio and platform related codes as per Tomasz'comment
- clean up dma related codes as per Vince's comment
Changes since v12:
- fixed typo
Byungho An (1):
MAINTAINERS: add
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Byungho An bh74...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
MAINTAINERS |9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b7befe7..aeb81f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7536,6 +7536,15 @@ S: Supported
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 52
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25
and depends statement from vendor sub-section as per
Dave's comment
Changes since v9:
- removed adv-add-map, force-sf-dma-modei and force-thresh-dma-mode from
binding documnet as per Mark's comment
Changes since v10:
- clean up codes as per Francois's comment
Byungho An (1):
MAINTAINERS
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 52
From: Byungho An bh74...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
MAINTAINERS |9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b7befe7..aeb81f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7536,6 +7536,15 @@ S: Supported
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe
Francois Romieu rom...@fr.zoreil.com wrote:
Byungho An bh74...@samsung.com :
[...]
Nit: you may consider reorganizing the variables in an inverted xmas
tree fashion at some point.
Does it look better? No problem.
Marginally if not more. Consider it a guideline to avoid unusual
Francois Romieu rom...@fr.zoreil.com wrote :
Byungho An bh74...@samsung.com :
[...]
+static int sxgbe_init_rx_buffers(struct net_device *dev,
+struct sxgbe_rx_norm_desc *p, int i,
+unsigned int dma_buf_sz
Tomasz Figa tomasz.f...@gmail.com :
Hi,
I have reviewed the non-net-specific parts of this driver, e.g. platform
driver
and Device Tree code. Please see my comments inline.
On 22.03.2014 07:23, Byungho An wrote:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support
Tomasz Figa tomasz.f...@gmail.com :
On 22.03.2014 22:55, Byungho An wrote:
Tomasz Figa tomasz.f...@gmail.com :
[snip]
+ if (priv-irq = 0) {
+ dev_err(dev, sxgbe common irq parsing failed\n);
+ sxgbe_drv_remove(ndev);
+ return -EINVAL;
+ }
+
+ /* Get
Vince Bridgers vbridgers2...@gmail.com :
See comments inline
On Sat, Mar 22, 2014 at 1:23 AM, Byungho An bh74...@samsung.com wrote:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
[snip]
+ /* program desc registers
Vince Bridgers vbridgers2...@gmail.com :
On Sat, Mar 22, 2014 at 1:23 AM, Byungho An bh74...@samsung.com wrote:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
[snip]
+ /* Stop Advertising 1000BASE Capability if interface
mdio_read/write codes as per Francois's comment
- changed irq acquisition error path as per Francois's comment
- updated mdio and platform related codes as per Tomasz'comment
- clean up dma related codes as per Vince's comment
Byungho An (1):
MAINTAINERS: add maintainer for Samsung sxgbe driver
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe
From: Byungho An bh74...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
MAINTAINERS |9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b7befe7..aeb81f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7536,6 +7536,15 @@ S: Supported
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 52
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
Mark Rutland mark.rutl...@arm.com wrote:
On Thu, Mar 20, 2014 at 05:26:06PM +, Byungho An wrote:
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet
driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe
Mark Rutland mark.rutl...@arm.com wrote:
+Example:
+
+ aliases {
+ ethernet0 = sxgbe0;
+ };
+
+ sxgbe0: ethernet@1a04 {
+ compatible = samsung,sxgbe-v2.0a;
+ reg = 0 0x1a04 0 0x1;
+ interrupt-parent = gic;
+
Mark Rutland mark.rutl...@arm.com wrote :
On Wed, Mar 19, 2014 at 10:32:48PM +, Byungho An wrote:
Mark Rutland mark.rutl...@arm.com :
On Tue, Mar 18, 2014 at 04:27:46PM +, Byungho An wrote:
Mark Rutland mark.rutl...@arm.com :
Hi,
As a general note it's helpful
Vince Bridgers vbridgers2...@gmail.com wrote :
On Wed, Mar 19, 2014 at 9:26 PM, Byungho An bh74...@samsung.com
wrote:
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches
and depends statement from vendor sub-section as per
Dave's comment
Changes since v9:
- removed adv-add-map, force-sf-dma-modei and force-thresh-dma-mode from
binding document and updated platform_get_irq as per Mark's comment
Byungho An (1):
MAINTAINERS: add maintainer for Samsung sxgbe
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 52
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25
From: Byungho An bh74...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
MAINTAINERS |9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b7befe7..aeb81f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7536,6 +7536,15 @@ S: Supported
Francois Romieu rom...@fr.zoreil.com :
Byungho An bh74...@samsung.com :
[...]
+static int sxgbe_hw_init(struct sxgbe_priv_data * const priv) {
struct sxgbe_ops *hw = priv-hw;
+ u32 ctrl_ids;
[...]
+struct sxgbe_priv_data *sxgbe_dvr_probe(struct device *device,
nit: s/dvr
Rayagond Kokatanur rayag...@vayavyalabs.com wrote :
On Thu, Mar 20, 2014 at 7:56 AM, Byungho An bh74...@samsung.com wrote:
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening
Joe's comment
Changes since v6:
- updated TSO related functions as per Rayagond's comment
- updated binding document as per Mark's comment
- removed WoL patch from this patch set
Changes since v7:
- updated TSO related functions as per Rayagond's comment
Byungho An (1):
MAINTAINERS: add
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25
From: Byungho An bh74...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
MAINTAINERS |9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b7befe7..aeb81f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7536,6 +7536,15 @@ S: Supported
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 60
David Miller da...@davemloft.net :
From: Byungho An bh74...@samsung.com
Date: Thu, 20 Mar 2014 10:25:59 -0700
+config NET_VENDOR_SAMSUNG
+ bool Samsung Ethernet device
+ default y
+ depends on HAS_IOMEM HAS_DMA
+ select PHYLIB
+ select CRC32
+ select PTP_1588_CLOCK
and depends statement from vendor sub-section as per
Dave's comment
Byungho An (1):
MAINTAINERS: add maintainer for Samsung sxgbe driver
Girish K S (1):
net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe
Siva Reddy (2):
sxgbe: Add device-tree binding support document
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 60
Rayagond Kokatanur rayag...@vayavyalabs.com wrote:
On Wed, Mar 19, 2014 at 11:02 AM, Byungho An bh74...@samsung.com wrote:
[snip]
/* save the skb address */
tqueue-tx_skbuff[entry] = skb;
if (!is_jumbo) {
- tx_desc-tdes01 = dma_map_single(priv
Mark Rutland mark.rutl...@arm.com :
On Tue, Mar 18, 2014 at 04:27:46PM +, Byungho An wrote:
Mark Rutland mark.rutl...@arm.com :
Hi,
As a general note it's helpful for devicetree to be Cc'd on the
entire
series
(though the binding document should be a separate patch
Joe's comment
Changes since v6:
- updated TSO related functions as per Rayagond's comment
- updated binding document as per Mark's comment
- removed WoL from this patch set
Byungho An (1):
MAINTAINERS: add maintainer for Samsung sxgbe driver
Girish K S (1):
net: sxgbe: add EEE(Energy
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 60
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Byungho An bh74...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
MAINTAINERS |9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b7befe7..aeb81f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7536,6 +7536,15 @@ S: Supported
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe
Mark Rutland mark.rutl...@arm.com :
Hi,
As a general note it's helpful for devicetree to be Cc'd on the entire
series
(though the binding document should be a separate patch) as it provides
useful
context for reviewing the binding.
OK.
On Tue, Mar 18, 2014 at 06:47:13AM +, Byungho
- removed reference of net_device.{irq, base_addr}
Changes since v4:
- updated binding document and DT related function per Mark's comment
Byungho An (1):
MAINTAINERS: add maintainer for Samsung sxgbe driver
Girish K S (2):
net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.h
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 52
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe
From: Girish K S ks.g...@samsung.com
This patch adds support for wake up on magic frame arrival.
Also remote wake up on all other packets (unicast, multicast broadcast) is
supported.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho
Joe Perches j...@perches.com wrote :
On Tue, 2014-03-18 at 11:19 -0700, Byungho An wrote:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
More trivia, nothing that should stop this from being applied and updated
later
Florian Fainelli f.faine...@gmail.com wrote :
2014-03-18 11:19 GMT-07:00 Byungho An bh74...@samsung.com:
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed
Florian Fainelli f.faine...@gmail.com wrote:
2014-03-18 11:19 GMT-07:00 Byungho An bh74...@samsung.com:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
- sxgbe core initialization
- Tx and Rx support
- MDIO support
- ISRs
Florian Fainelli f.faine...@gmail.com wrote :
2014-03-18 15:16 GMT-07:00 Byungho An bh74...@samsung.com:
Florian Fainelli f.faine...@gmail.com wrote:
2014-03-18 11:19 GMT-07:00 Byungho An bh74...@samsung.com:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support
From: Byungho An bh74...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
MAINTAINERS |9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b7befe7..aeb81f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7536,6 +7536,15 @@ S: Supported
- removed reference of net_device.{irq, base_addr}
Changes since v4:
- updated binding document and DT related function as per Mark's comment
Changes since v5:
- updated binding document and DT related function as per Florian's comment
- fixed typo and shortened code as per Joe's comment
Byungho
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
From: Girish K S ks.g...@samsung.com
This patch adds support for wake up on magic frame arrival.
Also remote wake up on all other packets (unicast, multicast broadcast) is
supported.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet)in 10G ethernet driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 58
From: Vipul Pandya vipul.pan...@samsung.com
Enable TSO during initialization for each DMA channels
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Neatening-by: Joe Perches j...@perches.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.h
From: Siva Reddy siva.kal...@samsung.com
This patch adds binding document for SXGBE ethernet driver via device-tree.
Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
.../devicetree/bindings/net/samsung-sxgbe.txt | 53
Mark Rutland mark.rutl...@arm.com :
On Wed, Mar 12, 2014 at 01:28:00PM +, Byungho An wrote:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
- sxgbe core initialization
- Tx and Rx support
- MDIO support
- ISRs for Tx
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds ethtool related functions.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/xgmac_common.h | 28 +-
drivers/net/ethernet/samsung/xgmac_ethtool.c
From: Girish K S ks.g...@samsung.com
Added support for the EEE(Energy Efficient Ethernet)
in 10G ethernet driver.
Signed-off-by: Girish K S ks.g...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/xgmac_common.h | 54 +
drivers/net/ethernet
From: Byungho An bh74...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
MAINTAINERS |9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c6d0e93..10cb617 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7526,6 +7526,15 @@ S: Supported
From: Vipul Pandya vipul.pan...@samsung.com
This patch adds TX and RX checksum offload support.
Signed-off-by: Vipul Pandya vipul.pan...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net/ethernet/samsung/xgmac_common.h |6 +++-
drivers/net/ethernet/samsung
From: Girish K S ks.g...@samsung.com
This patch adds support for wake up on magic frame arrival.
Also remote wake up on all other packets (unicast, multicast
broadcast) is supported.
Signed-off-by: Girish K S ks.g...@samsung.com
Signed-off-by: Byungho An bh74...@samsung.com
---
drivers/net
98 matches
Mail list logo
